Revs 4635-4637: comms log appears on every communication.

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Capt. Murphy
Commodore
Commodore
Posts: 1127
Joined: Fri Feb 25, 2011 8:46 am
Location: UK South Coast.

Revs 4635-4637: comms log appears on every communication.

Post by Capt. Murphy »

Morning,

The changes in these revisions seem to have had the effect of making the comms log appear every time a communication is received. Was this intentional? It's a bit intrusive.
[EliteWiki] Capt. Murphy's OXPs
External JavaScript resources - W3Schools & Mozilla Developer Network
Win 7 64bit, Intel Core i5 with HD3000 (driver rev. 8.15.10.2696 - March 2012), Oolite 1.76.1
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: Revs 4635-4637: comms log appears on every communication

Post by Eric Walch »

Capt. Murphy wrote:
Morning,

The changes in these revisions seem to have had the effect of making the comms log appear every time a communication is received. Was this intentional? It's a bit intrusive.
??? What you see is standard behaviour since at least Oolite 1.65. Console messages go only to the console but all comms messages trigger the comms log as well. You can suppress this behaviour with a special key in the hud. Probably your normal hud had this key and you now tested a game with default hud settings?
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Re: Revs 4635-4637: comms log appears on every communication

Post by Kaks »

CSOTB Capt. Murphy, the behaviour you saw before was a regression bug, one that went unnoticed for a while now.

It was affecting windows PCs (and possibly linux ones too) but not macs due to the different way uninitialised booleans are handled in the different platforms.

To get 'back' to the behaviour you're used to:

Code: Select all

comm_log_gui { automatic = no; }
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
User avatar
Capt. Murphy
Commodore
Commodore
Posts: 1127
Joined: Fri Feb 25, 2011 8:46 am
Location: UK South Coast.

Re: Revs 4635-4637: comms log appears on every communication

Post by Capt. Murphy »

Thanks gents,

After posting I gathered that it was probably supposed to do that having looked again at the code and the long-ago revision (3780?) where you added the Hud.plist keys.
[EliteWiki] Capt. Murphy's OXPs
External JavaScript resources - W3Schools & Mozilla Developer Network
Win 7 64bit, Intel Core i5 with HD3000 (driver rev. 8.15.10.2696 - March 2012), Oolite 1.76.1
Post Reply