Flasher setting causing a CTD on windows (solved)

[Frame]

I tried to use a colors array for flashers like this on 1.75.3

Code: Select all

{
				type = flasher;
				size = 30;
				colors = ("1,1,1,1","1,1,1,1","1,1,1,1");
				frequency = 1;
				phase = -10;
				position =(-55.161,449.19,1201.008);
			}

That however will crash Oolite.. I Tried shifting it its position in the subentity list in the shipdata.plist file but with the same result..

Now before i go post it as a bug, is it me that is setting up the array wrong ?

Cheers Frame...

EDIT

Found my error, been starring at it for an hour, and just after the post i saw it

Code: Select all

colors = ("1,1,1,1","1,1,1,1","1,1,1,1");

should be

Code: Select all

colors = ("1 1 1 1","1 1 1 1","1 1 1 1");

[JensAyton]

Now before i go post it as a bug, is it me that is setting up the array wrong ?

Yes; it should be an array of arrays of numbers (or other colour specifiers), not an array of strings. Of course, it shouldn’t crash whatever you give it.

Edit: fixed in r4582.

[Frame]

Now before i go post it as a bug, is it me that is setting up the array wrong ?

Yes; it should be an array of arrays of numbers (or other colour specifiers), not an array of strings. Of course, it shouldn’t crash whatever you give it.

Edit: fixed in r4582.

Ninjaed

[JensAyton]

Of course, it shouldn’t crash whatever you give it.

I’d like to emphasise this once again: if your plists or scripts crash the game, don’t try to work around it. Report a bug. Always.