Some bugs I found

[wild turkey]

Hi,

First of all I'd like to say thanks to all the developers for this excellent version of Elite. But unfortunately I have found some bugs.

The system I'm running on is:

AMD Athlon 64 X2 Dual Core 4800+
Ubuntu 7.10 64 Bit
Oolite 1.71.2 Compiled using the instructions found on the wiki.

I have these OXPs installed

Assassins.oxp
a-wing.oxp
behemoth.oxp
b-wing.oxp
custsounds.oxp
Freaky Thargoids 3.oxp
Interceptor.oxp
lambda.oxp
MedusaHud.oxp
RandomHits.oxp
Cobra.oxp
System_Redux.oxp
thargoid_wars 4.2.oxp
Thorgorn_Threat.oxp
TIE.oxp
tiger.oxp
X-Wing.oxp
YOUR_AD_HERE.oxp
YOUR_AD_HERE_set_A.oxp
YOUR_AD_HERE_set_B.oxp
YOUR_AD_HERE_set_C.oxp
YOUR_AD_HERE_set_D.oxp
y-wing.oxp

When I force a Misjump I get lots of the following messages in the console-

Code: Select all

2008-07-10 13:08:34.308 oolite[12932] [exception]: ***** Exception during [update:entity[<ShipEntity 0x6f9ac10>{"Thargoid Warship"}]] in [Universe update:] : NSInvalidArgumentException : Tried to add nil to array *****

2008-07-10 13:08:34.308 oolite[12932] *** NSTimer ignoring exception 'NSInvalidArgumentException' (reason 'Tried to add nil to array') raised during posting of timer with target 0xb48070 and selector 'performGameTick:'

At this point the graphics freeze at end of the count down. But the game is still running. You can here if you fire weapons etc. If you got enough fuel you can witch jump to your destination and the game will continue on as if nothing has happened ie the graphics work again.

I also have a problem with the random hits oxp. Although I don't know if the problem is caused by RH or something else. The problem is bits of the space bar keep appearing in space. You can blow them up and collect a bounty.

Launching missiles doesn't work properly mostly they just blowup as soon as they are launched. This happens with my ship (Tiger MK1) but I have seen other ships launch missiles at me and they just blow up without me hitting the ECM.

None of the bugs are stopping me from enjoying the game.

Regards,
WT

[CaptKev]

When I force a Misjump I get lots of the following messages in the console-

Code: Select all

2008-07-10 13:08:34.308 oolite[12932] [exception]: ***** Exception during [update:entity[<ShipEntity 0x6f9ac10>{"Thargoid Warship"}]] in [Universe update:] : NSInvalidArgumentException : Tried to add nil to array *****

2008-07-10 13:08:34.308 oolite[12932] *** NSTimer ignoring exception 'NSInvalidArgumentException' (reason 'Tried to add nil to array') raised during posting of timer with target 0xb48070 and selector 'performGameTick:'

Hi wild turkey and Welcome.

This could be an issue with System Redux, please download the replacement script here then copy it to your Config folder.

[another_commander]

Hi wild turkey

Try doing a misjump without any OXPs and see if the error repeats. I seem to recall that this was fixed in trunk, but I could be thinking of a different bug. If you can, build the 1.72 trunk and try to reproduce the error with and without OXPs. If the problem persists in trunk, please report back.

[JensAyton]

More generally, if any OXP reproducibly causes exception messages like that, we really want to know about it (and of course need a copy of the version of the OXP causing the problem, and a saved game if specific circumstances are needed to reproduce it).

[LittleBear]

Eric has also reported bits of the random hits bar (ie subentries) floating about randomly and also other sub-entries from native and OXP .plist. I haven't encountered this on my system and I'd thought is was some oddity with subentries in the game rather than the shipdata itself. The entry for the space bar (in full) is:-

Code: Select all

<!-- Template for the Space Bar - not used in game as all bars are like-shiped to this one so they can be given different names-->

<key>griff_spacebar_subent_template</key>
<dict>
<key>ai_type</key>
<string>dumbAI.plist</string>
<key>name</key>
<string>SpaceBar</string>
<key>roles</key>
<string>griff_spacebar_subent</string>
</dict>

<key>random_hits_griff_spacebar</key>
<dict>
<key>like_ship</key>
<string>coriolis-station</string>
<key>has_npc_traffic</key>
<true/>
<key>unpiloted</key>
<false/>
<key>max_flight_pitch</key>
<real>0.0</real>
<key>max_flight_roll</key>
<real>0.0</real>
<key>energy_recharge_rate</key>
<real>100</real>
<key>max_energy</key>
<real>500000</real>
<key>name</key>
<string>A Seedy Space Bar</string>
<key>ai_type</key>
<string>randomhitsbarAI.plist</string>
<key>beacon</key>
<string>B-Space Bar</string>
<key>hasShipyard</key> 
<true/>
<key>max_defense_ships</key>
<integer>0</integer>
<key>scanner_range</key>
<real>25000</real>
<key>max_police</key>
<integer>0</integer>
<key>max_scavengers</key>
<integer>0</integer>
<key>has_ecm</key>
<real>1.0</real>
<key>equipment_price_factor</key>
<real>1.14</real>
<key>equivalent_tech_level</key>
<integer>10</integer>
<key>rotating</key>
<false/>
<key>model</key>
<string>griff_spacebar_mainsection.dat</string>
<key>roles</key>
<string>random_hits_griff_spacebar station(0.00001)</string>
<key>scanClass</key>
<string>CLASS_STATION</string>
<key>subentities</key>
<array>
<string>griff_spacebar_entrysection           0 0 0 1 0 0 0</string>
<string>griff_spacebar_backsection              0 0 0 1 0 0 0</string>
<string>griff_spacebar_rock                  0 0 0 1 0 0 0</string>
<string>griff_spacebar_solarpanel             0 0 0 1 0 0 0</string>
<string>griff_spacebar_pipe                 0 0 0 1 0 0 0</string>
<string>griff_spacebar_platform                0 0 0 1 0 0 0</string>
<string>griff_spacebar_dockingbay             0 0 690.7914 1 0 0 0</string>
<string>griff_spacebar_Arexack_Heretic_Neonsign 0 0 0 1 0 0 0</string>
<string>griff_spacebar_turretbase				0 0 0 1 0 0 0</string>
<string>griff_spacebar_turret_gun1	 33.9888   365.5728 13.6262   0.3090  0.9510   0       0      </string>		
<string>griff_spacebar_turret_gun2	 317.2431 -257.8024 47.479    0.4669 -0.8253  -0.2761 -0.1562 </string>	
<string>griff_spacebar_turret_gun3	 220.7015  238.8506 347.669   0.8387  0.4366  -0.1503  0.2888 </string>
<string>griff_spacebar_turret_gun4	 419.4826  49.1899  278.1015  0.7561  0.1268  -0.6233 -0.1538 </string>
<string>griff_spacebar_turret_gun5	-74.9758   197.6022 471.9254  0.7928  0.5867   0.0982 -0.1327 </string>
<string>griff_spacebar_turret_gun6	-203.6626 -298.641  29.9343  -0.2051  0.03432 -0.9647 -0.1614 </string>
<string>griff_spacebar_turret_gun7	-363.4611  120.1162 224.2068  0.8241  0        0.5664  0      </string>	
<string>griff_spacebar_turret_gun8	-13.8952  -207.442  485.8795  0.9137 -0.3785   0.1366 -0.0566 </string>	
<string>griff_spacebar_turret_gun9	-247.8852 -259.1076 259.9212  0.7960 -0.4689   0.1942  0.3297 </string>	
</array>
<key>shaders</key>
<dict>
<key>griff_spacebar_mainhull.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_mainhull.png</string>
</array>
<key>vertex_shader</key>
<string>ahruman-generic.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar.fragment</string>
</dict>
</dict>   
</dict>

<key>griff_spacebar_entrysection</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_subent_template</string>
<key>model</key>
<string>griff_spacebar_dockingsection.dat</string>
<key>shaders</key>
<dict>
<key>griff_spacebar_mainhull.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_mainhull.png</string>
</array>
<key>vertex_shader</key>
<string>ahruman-generic.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar.fragment</string>
</dict>
</dict>   
</dict>

<key>griff_spacebar_backsection</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_subent_template</string>
<key>model</key>
<string>griff_spacebar_backsection.dat</string>
<key>shaders</key>
<dict>
<key>griff_spacebar_mainhull.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_mainhull.png</string>
</array>
<key>vertex_shader</key>
<string>ahruman-generic.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar.fragment</string>
</dict>
</dict>   
</dict>

<key>griff_spacebar_rock</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_subent_template</string>
<key>model</key>
<string>griff_spacebar_rock-smoothed.dat</string>
<key>smooth</key>
<true/>
<key>shaders</key>
<dict>
<key>griff_spacebar_rock.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_rock.png</string>
</array>
<key>vertex_shader</key>
<string>ahruman-generic.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar_rock.fragment</string>
</dict>
</dict>   
</dict>   
   
<key>griff_spacebar_solarpanel</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_subent_template</string>
<key>model</key>
<string>griff_spacebar_solarpanel.dat</string>
<key>smooth</key>
<true/>      
<key>shaders</key>
<dict>
<key>griff_spacebar_mainhull.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_mainhull.png</string>
</array>
<key>vertex_shader</key>
<string>ahruman-generic.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar_solarpanel.fragment</string>
</dict>
</dict>   
</dict>      

<key>griff_spacebar_pipe</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_subent_template</string>
<key>model</key>
<string>griff_spacebar_pipe.dat</string>
<key>smooth</key>
<true/>         
<key>shaders</key>
<dict>
<key>griff_spacebar_platformpipe.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_platformpipe.png</string>
</array>
<key>vertex_shader</key>
<string>ahruman-generic.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar_rock.fragment</string>
</dict>
</dict>   
</dict>   
   
<key>griff_spacebar_platform</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_subent_template</string>
<key>model</key>
<string>griff_spacebar_platform.dat</string>
<key>shaders</key>
<dict>
<key>griff_spacebar_platformpipe.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_platformpipe.png</string>
</array>
<key>vertex_shader</key>
<string>ahruman-generic.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar.fragment</string>
</dict>
</dict>   
</dict>
   
<key>griff_spacebar_dockingbay</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_subent_template</string>
<key>model</key>
<string>griff_spacebar_dockingbay.dat</string>
<key>roles</key>
<string>docking-slit</string>
<key>shaders</key>
<dict>
<key>griff_spacebar_dockingbay.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_dockingbay.png</string>
</array>
<key>vertex_shader</key>
<string>griff_spacebar_dockingbay.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar_dockingbay.fragment</string>
</dict>
</dict>   
</dict>   
   
<key>griff_spacebar_Arexack_Heretic_Neonsign</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_subent_template</string>
<key>model</key>
<string>griff_spacebar_ah_sign.dat</string>
<key>shaders</key>
<dict>
<key>A_H_wormhole_animation.png</key>
<dict>
<key>textures</key>
<array>
<string>A_H_wormhole_animation.png</string>
</array>
<key>vertex_shader</key>
<string>griff_spacebar_Arexack_Heretic_Neon_sign.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar_Arexack_Heretic_Neon_sign.fragment</string>
<key>uniforms</key>
<dict>
<key>uTime</key>      
<string>timeElapsedSinceSpawn</string>
</dict>
</dict>
</dict>
</dict>

<key>griff_spacebar_turretbase</key>
<dict>
<key>ai_type</key>
<string>dumbAI.plist</string>
<key>model</key>
<string>griff_spacebar_turret_base.dat</string>
<key>name</key>
<string>SpaceBar</string>
<key>smooth</key> 
<true/>		
<key>roles</key>
<string>griff_spacebar_subent</string>
<key>shaders</key>
<dict>
<key>griff_spacebar_turret.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_turret.png</string>
<string>griff_spacebar_turret_effects.png</string>
</array>
<key>vertex_shader</key>
<string>ahruman-generic.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar_turret.fragment</string>
<key>uniforms</key> 
<dict> 
<key>laser_heat_level</key> 
<string>laserHeatLevel</string> 
</dict> 				
</dict>
</dict>			
</dict>		

<key>griff_spacebar_turret_gun1</key>
<dict>
<key>ai_type</key>
<string>nullAI.plist</string>
<key>model</key>
<string>griff_spacebar_turret_gun.dat</string>
<key>name</key>
<string>SpaceBar</string>
<key>roles</key>
<string>SpaceBar_turret</string>
<key>smooth</key> 
<true/>	
<key>thrust</key>
<real>2</real>
<key>weapon_energy</key>
<real>15</real>
<key>laser_color</key>
<string>redColor</string>
<key>setup_actions</key>
<array>
<string>initialiseTurret</string>
</array>
<key>shaders</key>
<dict>
<key>griff_spacebar_turret.png</key>
<dict>
<key>textures</key>
<array>
<string>griff_spacebar_turret.png</string>
<string>griff_spacebar_turret_effects.png</string>
</array>
<key>vertex_shader</key>
<string>ahruman-generic.vertex</string>
<key>fragment_shader</key>
<string>griff_spacebar_turret.fragment</string>
<key>uniforms</key> 
<dict> 
<key>laser_heat_level</key> 
<string>laserHeatLevel</string> 
</dict>
</dict>
</dict>	
</dict>		

<key>griff_spacebar_turret_gun2</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_turret_gun1</string>
<key>laser_color</key>
<string>whiteColor</string>
</dict>

<key>griff_spacebar_turret_gun3</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_turret_gun1</string>
<key>laser_color</key>
<string>blueColor</string>
</dict>

<key>griff_spacebar_turret_gun4</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_turret_gun1</string>
<key>laser_color</key>
<string>yellowColor</string>
</dict>

<key>griff_spacebar_turret_gun5</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_turret_gun1</string>
<key>laser_color</key>
<string>orangeColor</string>
</dict>

<key>griff_spacebar_turret_gun6</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_turret_gun1</string>
<key>laser_color</key>
<string>cyanColor</string>
</dict>

<key>griff_spacebar_turret_gun7</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_turret_gun1</string>
<key>laser_color</key>
<string>magentaColor</string>
</dict>

<key>griff_spacebar_turret_gun8</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_turret_gun1</string>
<key>laser_color</key>
<string>greenColor</string>
</dict>

<key>griff_spacebar_turret_gun9</key>
<dict>
<key>like_ship</key>
<string>griff_spacebar_turret_gun1</string>
<key>laser_color</key>
<string>purpleColor</string>
</dict>

Each version is then like_shiped to this template so that each bar has a different name, tech level, prices and stuff:-

Code: Select all

<!-- The Space Bars used in game -->

<key>random_hits_griff_spacebar1</key>
<dict>
<key>like_ship</key>
<string>random_hits_griff_spacebar</string>
<key>roles</key>
<string>random_hits_spacebar1 station(0.00001)</string>
<key>name</key>
<string>The Blue Parrot</string>
<key>equipment_price_factor</key>
<real>1.12</real>
<key>equivalent_tech_level</key>
<integer>9</integer>
</dict>

and so on for all the varients.

[Griff]

is this because the spacebar 'like_ship's a 'like_ship'ed ship? (an oolite tongue twister!).
the is_template key might fix this when then next Oolite test comes out.
is_template info from the progress thread: https://bb.oolite.space/viewtopic.php?t=3231&start=217

[LittleBear]

Mmm dunno maybe. Beheamoth OXP also does this though (cribbed the idea of like_shiping to a template from there).

[Eric Walch]

I can trigger a similar log file:

Code: Select all

Oolite [exception] -[Universe update:] (Universe.m:5383): ***** Exception during [update:entity[<StationEntity 0x1c46400>{"Coriolis Station"}]] in [Universe update:] : NSInvalidArgumentException : *** -[NSCFArray addObject:]: attempt to insert nil *****
Oolite [system] (null): *** NSTimer discarding exception '*** -[NSCFArray addObject:]: attempt to insert nil' that raised during firing of timer with target 65f550 and selector 'performGameTick:'
Oolite [exception] -[Universe update:] (Universe.m:5383): ***** Exception during [update:entity[<ShipEntity 0x1a91600>{"Thargoid Warship"}]] in [Universe update:] : NSInvalidArgumentException : *** -[NSCFArray addObject:]: attempt to insert nil *****
Oolite [system] (null): *** NSTimer discarding exception '*** -[NSCFArray addObject:]: attempt to insert nil' that raised during firing of timer with target 65f550 and selector 'performGameTick:'

It goes on an on and keeps trying to add Thargoids. I just removed all OXP's except a new one I was writing on. It's a very basic one. It only contains one planetInfo.plist:

Code: Select all

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>Planet_Achenar</key>
	<dict>
		<key>orientation</key>
		<string>1.0 0.0 0.0 0.0</string>
		<key>polar_color_factor</key>
		<string>2.5</string>
		<key>position</key>
		<string>-50000 1000 263000</string>
		<key>radius</key>
		<string>2500</string>
		<key>rotational_velocity</key>
		<string>0.04</string>
		<key>seed</key>
		<string>1 2 3 4 5 6</string>
		<key>texture</key>
		<string>Planet_Achenar.png</string>
	</dict>
	<key>interstellar: 0 48 144</key>
	<dict>
		<key>script_actions</key>
		<array>
			<string>addMoon: Planet_Achenar</string>
		</array>
	</dict>
</dict>
</plist>

The planet definitions are literally copied from Assassains, so should be okay as they proofed to work there. And when used with oolite 1.65 the planet is there. Add ships this way in an very specific interstellar space location betwee two systems was introduced around oolite 1.52. The above bug is triggered with a addMoon or addPlanet command.

[LittleBear]

In turn, I'd C&Ped them from Murgh's Diso OXP, so they should be ok.

[JensAyton]

I can trigger a similar log file:

Thank you. Replicated in 1.71.2, but not in either development branch; now that I see it happening, I remember fixing it before. :-)

[wild turkey]

Hi wild turkey and Welcome.

Thank you. Nice to be here.

This could be an issue with System Redux, please download the replacement script here then copy it to your Config folder.

Thank you for your suggestion but it didn't fix the problem. But I do get the folowing error message in console with the new version of the scrip.

Code: Select all

2008-07-11 03:57:17.215 oolite[11705] [script.javaScript.exception.102]: ***** JavaScript exception: SyntaxError: missing variable name
2008-07-11 03:57:17.215 oolite[11705] [script.javaScript.exception.102]:       /home/wild/.Oolite/AddOns/System_Redux.oxp/Config/script.js, line 16:    var this.system_info = new Array(
2008-07-11 03:57:17.215 oolite[11705] [script.javaScript.load.failed]: ***** Error loading JavaScript script /home/wild/.Oolite/AddOns/System_Redux.oxp/Config/script.js -- compilation failed
2008-07-11 03:57:17.289 oolite[11705] [script.load.world.listAll]: Loaded 11 world scripts: "assassins", "Behemoth-script01", "oolite-cloaking-device" 1.71.2, "oolite-constrictor-hunt" 1.71.2, "oolite-nova" 1.71.2, "oolite-thargoid-plans" 1.71.2, "oolite-trumbles" 1.71.2, "Pi-Forty-Two Con stores", "Random_Hits", "thargoid_wars", "Thargorn_Witchspace_Battle"
2008-07-11 03:57:18.945 oolite[11705] [dataCache.willWrite]: About to write data cache.
2008-07-11 03:57:18.977 oolite[11705] [dataCache.write.success]: Wrote data cache.

I also tried this script with V1.72 1690 and get the same error.

Thanks for your help.

[wild turkey]

Hi wild turkey

Try doing a misjump without any OXPs and see if the error repeats. I seem to recall that this was fixed in trunk, but I could be thinking of a different bug. If you can, build the 1.72 trunk and try to reproduce the error with and without OXPs. If the problem persists in trunk, please report back.

Hi,

I built V1.72 and the problem is fixed in that version. Also the problem with random bits of the space bar appearing in space has not happened in this version either so far. But I have not had the chance to test it extensively.

The problem with the missiles exploding as soon as they are launched is still there. I watched another Tiger MK1 launch 3 missiles at me in rapid succession and all 3 exploded as soon as they were launched without me hitting the ECM.

I then tried to launch 3 missiles at him and they all exploded as soon as they launched.

Thanks everyone for the help. Now for some more "play testing".

Here little Thargoids...... I'm going to kill you little Thargoids....

[caracal]

I built V1.72 and the problem is fixed in that version. Also the problem with random bits of the space bar appearing in space has not happened in this version either so far. But I have not had the chance to test it extensively.

I also saw the same effect, space bar bits appearing in random places (rather funny at times!) under 1.65, and possibly 1.71.2, and it went away when I built from svn. Been playing it for a couple weeks now with no random sub-entities appearing, so I'd call it fixed. I saw the same thing with asteroids too, with them flying around, trying to dock with stations, even trying to attack me (!) but I had so many OXPs installed, and de-installed the majority of them at around the same time I upgraded my app version, so didn't report it because I didn't have enough data, and because it went away.

The problem with the missiles exploding as soon as they are launched is still there.

Haven't seen this one, thank Holy Giles!

[CaptKev]

This could be an issue with System Redux, please download the replacement script here then copy it to your Config folder.

Thank you for your suggestion but it didn't fix the problem. But I do get the folowing error message in console with the new version of the scrip.

Sorry, my fault , could you download it again from here please.

[Commander McLane]

The problem with missiles immediatly exploding after launch has started either in 1.70 or in 1.71 and has been reported a couple of times.

One guess about its cause is that the value of missile_launch_position is ignored and/or set wrong, causing the missile to collide with the launching ship and not surviving this collision. I seems to happen more often with Tigers (also NPC-variant, although I seem to recall that even in 1.65 its missiles tended to explode instantly; probably the missile_launch_position was always too close to the ship).

In a similar bug the values of weapon_position_foo are ignored since 1.71, and the position defaults to 0, causing either invisible lasers or strange optical effects on ships with corresponding view_position_foos of 0. (Has also been repeatedly reported, but not fixed yet.)