MincePie.oxp

[aracer]

I made this as an add-on for santa.oxp - see https://bb.oolite.space/viewtopic.php?t=2671 for first announcement. Rather than totally hi-jack that thread, here's the first beta version. It does all seem to work, but this is my first attempt at an OXP, so I've probably missed something - will go to release if I don't get any major problem reports (have some minor enhancements I can roll in to that). Also only tested on a Windows (Vista) PC - do I need to do anything funny with line endings etc. to make it work on other platforms?

Doesn't really do anything important - if anything is even more pointlessly trivial than santa.oxp, but a little enhancement to that, which I hope some might like.

Here's the link: http://www.box.net/shared/8hek3kak8b

[aracer]

Slightly updated version incorporating suggestions from Eric Walch now uploaded - same download link.

[Griff]

Great work on the OXP!
25Cr.! crikey, that's one posh mince pie, is it from WaitrOose?
I think i'm going to get the plating on my cobra MK III replaced with mince pie pastry, these things are tougher than constrictor hulls!

[Screet]

I think i'm going to get the plating on my cobra MK III replaced with mince pie pastry, these things are tougher than constrictor hulls!

Sounds as if they're made by dwarves in order to be used as weapons to replace their good old "bread"

Screet

[Norby]

This mini mission pack now also available in oxz form in the magager.

[Cholmondely]

This has been defined as a Mission.

Might it be better classified as an Activity (feeding Santa Mince Pies) or as Miscellaneous?

[MrFlibble]

Noticed these in the Latest.log

Code: Select all

[script.javaScript.exception.notFunction]: ***** JavaScript exception (mincePieStartup 1.0 beta): TypeError: player.ship.hasEquipment is not a function
[script.javaScript.exception.notFunction]:       /home/flibble/Oolite/GameData/.ManagedAddOns/oolite.oxp.Chris.MincePie.oxz/Scripts/mincePieStartup.js, line 26.

Here's from line 26.

Code: Select all

       while (player.ship.hasEquipment("EQ_MINCE_PIE_MINE")) {
            player.ship.removeEquipment("EQ_MINCE_PIE_MINE");
            mincePiesRemoved++;
        }

[Wildeblood]

Noticed these in the Latest.log

Code: Select all

[script.javaScript.exception.notFunction]: ***** JavaScript exception (mincePieStartup 1.0 beta): TypeError: player.ship.hasEquipment is not a function
[script.javaScript.exception.notFunction]:       /home/flibble/Oolite/GameData/.ManagedAddOns/oolite.oxp.Chris.MincePie.oxz/Scripts/mincePieStartup.js, line 26.

Here's from line 26.

Code: Select all

       while (player.ship.hasEquipment("EQ_MINCE_PIE_MINE")) {
            player.ship.removeEquipment("EQ_MINCE_PIE_MINE");
            mincePiesRemoved++;
        }

Try:

while (player.ship.equipmentStatus("EQ_MINCE_PIE_MINE") === "EQUIPMENT_OK") {

[MrFlibble]

That gets it.

I've tarted up the oxz a bit. Bumped to 1.2 in manifest. pngcrushed the texture, and waved the dos2unix wand. Should I upload it somehow/somewhere?

Edit: No rush. It's seasonal

[Wildeblood]

Should I upload it somehow/somewhere?

That comment/question makes me wonder if you have a login on the wiki, OR NOT?

[MrFlibble]

Should I upload it somehow/somewhere?

That comment/question makes me wonder if you have a login on the wiki, OR NOT?

I do, and I think I grok how to get an oxz on there, and expect I'll be able to suss how to do same for an upgrade, but I feel I should iron out a few other bits I just found first:

Code: Select all

$ grep -i mince Latest.log 
    ~/Oolite/GameData/AddOns/oolite.oxp.Chris.MincePie-1.2.oxz
17:21:28.922 [oxp-standards.deprecated]: Script /home/flibble/Oolite/GameData/AddOns/oolite.oxp.Chris.MincePie-1.2.oxz/Scripts/mincePieStartup.js does not "use strict";
    mincePieStartup 1.0 beta
17:22:25.052 [oxp-standards.deprecated]: TL99 is deprecated for EQ_MINCE_PIE_MINE
17:22:26.295 [oxp-standards.deprecated]: TL99 is deprecated for EQ_MINCE_PIE_MINE
# last line repeats a lot

I have to go out, but will bury my head in those tomorrow. Clues appreciated.