AI turns Scavengers into Miners With a Pulse Laser

[Frame]

Not sure where to report anymore so Ill do it here.

I started playing Oolite a bit again

in 1.90, official download: So, if you get an asteroid, or an asteroid that spawns near the mainStation and you mine it into a boulder and then a splinter, then the station launches scavengers as expected.

But upon not finding more loot, they turn to be Miners if there is any Mineble object nearby, and with Pulse Lasers as their only weapon. That is a bad thing as they will destroy all Asteroids or boulders instead of mining them.

Looking into the Scavenger script i find this.

Code: Select all

/* Branch for mining ships: if we can usefully mine asteroids, do so */
		{
			condition: ai.conditionScannerContainsMiningOpportunity,
			configuration: ai.configurationAcquireScannedTarget,
			behaviour: ai.behaviourMineTarget,
			reconsider: 20
		},
	

So i suggest that scavengers and miners get their own dedicated AIscript. Scavengers is not able to mine since they got a Pulse Laser as their main weapon.

Cheers.

[maik]

I started playing Oolite a bit again

Welcome back

[Frame]

I started playing Oolite a bit again

Welcome back

Thanks.

[Cholmondely]

Not sure where to report anymore so Ill do it here.

I started playing Oolite a bit again

in 1.90, official download: So, if you get an asteroid, or an asteroid that spawns near the mainStation and you mine it into a boulder and then a splinter, then the station launches scavengers as expected.

But upon not finding more loot, they turn to be Miners if there is any Mineble object nearby, and with Pulse Lasers as their only weapon. That is a bad thing as they will destroy all Asteroids or boulders instead of mining them.

Looking into the Scavenger script i find this.

Code: Select all

/* Branch for mining ships: if we can usefully mine asteroids, do so */
		{
			condition: ai.conditionScannerContainsMiningOpportunity,
			configuration: ai.configurationAcquireScannedTarget,
			behaviour: ai.behaviourMineTarget,
			reconsider: 20
		},
	

So i suggest that scavengers and miners get their own dedicated AIscript. Scavengers is not able to mine since they got a Pulse Laser as their main weapon.

Cheers.

Bump!

Did anything ever happen about this?

[cim]

condition: ai.conditionScannerContainsMiningOpportunity, contains

Code: Select all

if (!this.ship.forwardWeapon == "EQ_WEAPON_MINING_LASER")
	{
		return false;
	}

so should always return false for a scavenger with a pulse laser, and never set off the mining. That was the idea, and why they weren't supposed to need separate AIs.

However, I think there's a typo in that - it should probably read

Code: Select all

if (this.ship.forwardWeapon != "EQ_WEAPON_MINING_LASER")
	{
		return false;
	}

instead.

(Resources/Scripts/oolite-priorityai.js line 2261 - give the change a go and see if it works?)

[another_commander]

cim's change has been committed to master. I tested the suspect syntax with an online javascript compiler and a minimal test case and it was always falling through to the end of the function regardless of what the value of the forward weapon was. With cim's change applied, it works as intended.

[Cholmondely]

cim's change has been committed to master. I tested the suspect syntax with an online javascript compiler and a minimal test case and it was always falling through to the end of the function regardless of what the value of the forward weapon was. With cim's change applied, it works as intended.

Thank you for doing this...