[RELEASE] ILS Instrument Landing System v1.13

[dybal]

Version 1.13 is available on the Expansion Manager or here.

Changes:

• Calculate Dock world-coordinates orientation by concatenating its orientation in station model-coordinates with the Station orientation in world-coordinates.

• Get direction of Dock widest dimension (depth excluded) based on Docks dimensions and world-coordinates orientation (general case, should work for all kinds of dock's placement on station models).

• Use Dock's heading instead of Station's heading to get the position to aim on approach (should allow docking bays in the aft of the dockable).

• Change rotation sync logic: if the ship's rotation is lagging, rotates in the same direction as the station; if it's advanced, rotate against the station; this avoids rotating too much inside the dock if a longer interval between FCB calls gets the ship sufficiently out-of-sync to start correcting again (the "let's rotate once more now we are inside the dock" bug...).

• If the ship is approaching fast, start rotation sync farther away and rotate as much as possible in each FCB, otherwise do it more leisurely (for the visual beauty...might be still too fast for that and need some tuning).

I'm pretty sure I nailed that last rotation after entering the docking bay, but I'm not sure about the NPCs splashing themselves on the station's face... the bug fixes in v1.12 did deal with some cases (the off-centre docking bays and some station models where the widest dimension of the dock obtained by ILS to align the ships was incorrect), and I didn't find anything else in the code for NPC steering that could cause the splashing... if anybody sees it happening with v1.13, please let me know (the model of station they are splashing themselves on would be very useful to know, and a savefile docked at that station even more so - I don't know how to edit a savefile to change the system/station where the ship is).

[Cholmondely]

Version 1.13 is available on the Expansion Manager or here.

Changes:

• Calculate Dock world-coordinates orientation by concatenating its orientation in station model-coordinates with the Station orientation in world-coordinates.

• Get direction of Dock widest dimension (depth excluded) based on Docks dimensions and world-coordinates orientation (general case, should work for all kinds of dock's placement on station models).

• Use Dock's heading instead of Station's heading to get the position to aim on approach (should allow docking bays in the aft of the dockable).

• Change rotation sync logic: if the ship's rotation is lagging, rotates in the same direction as the station; if it's advanced, rotate against the station; this avoids rotating too much inside the dock if a longer interval between FCB calls gets the ship sufficiently out-of-sync to start correcting again (the "let's rotate once more now we are inside the dock" bug...).

• If the ship is approaching fast, start rotation sync farther away and rotate as much as possible in each FCB, otherwise do it more leisurely (for the visual beauty...might be still too fast for that and need some tuning).

I'm pretty sure I nailed that last rotation after entering the docking bay, but I'm not sure about the NPCs splashing themselves on the station's face... the bug fixes in v1.12 did deal with some cases (the off-centre docking bays and some station models where the widest dimension of the dock obtained by ILS to align the ships was incorrect), and I didn't find anything else in the code for NPC steering that could cause the splashing... if anybody sees it happening with v1.13, please let me know (the model of station they are splashing themselves on would be very useful to know, and a savefile docked at that station even more so - I don't know how to edit a savefile to change the system/station where the ship is).

My most recent transmogrification to two-dimensionality occurred while trying to dock at a Tigershark Liner (http://wiki.alioth.net/index.php/Liners) when this wonderful .oxp decided to fly me through the side of the liner to get to the docking bay! Since I'd not tried this recently - and could only see a small portion of the liner, I did not realise what was happening!

I do understand that with only two fast action keys that there is little point having an on/off switch for the ILS (unless one is playing Ironman). But when a newer version of Oolite comes out (with more fast action keys), this .oxp is crying out for such a switch.

You have a 150,000 cr ship .... grumble, grumble ...

[dybal]

You can switch if off by untargetting the dockable ('u' in the default keyboard configuration). Granted, Telescope does make that rather difficult... I switch weapons on when I start docking procedures so Telescope would let me keep the target of my choosing (which might be no target!).

Right now there are two caveats to ILS:

• It doesn't deal with moving (and by moving I don't mean rotating) dockables. That's a big problem if the dockable has a forward facing docking bay and keep moving when you try to dock. You can use it with Deep Space Dredgers because they stop moving (and trying to avoid a collision) for a while when receiving a docking clearance request, and since they don't required docking clearance you can keep asking for docking clearance to keep them static, but Liners do require docking clearance, and the only way to make them stop that I know is by using docking computers (in fact, docking with Liners and fast-docking when towing large ships are my only use for docking computers). I have no ideas of how to improve this.
• It doesn't deal with the dockable physical limits impinging in your trajectory at all, so if you engage ILS from the wrong position (behind or close to the sides of the dockable, it might steer you right through the dockable to reach the docking lane. I have some ideas to improve this, but I want to conclude my work on several other OXPs before tackling it.

Only use ILS with Liners if the Liner is stopped, or you are way ahead of it in its heading and roughly aligned with the docking lane to start, and be ready to un-target and bail out.

EDIT: rule-of-thumb about positions to engage ILS: if you can't see the docking bay, you are in a bad position to engage ILS.

[Norby]

My suggestions about the last two problems:
1. Moving dockables should be stopped when receive an ILS request, like sending a radio message about "Hey, I would like to dock, so stop moving!". When targeted by ILS then set ship.maxSpeed=0 on the dockable, then restore when docked or untargeted.
2. The trajectory should avoid a sphere around the dockable which sized to the double of ship.collisionRadius of the dockable. As you said there is a narrow (about 30 degree) cone before the dock where the ship should approach the dock. I think when the landing ship enter into the nearby sphere using ILS out of the best cone, then should turn away from the dockable and leave the sphere. You can achieve this either by targeting some waypoints placed around the dockable, or just travel out of a larger (3x) sphere before switch back to the standard ILS approach.

[Cholmondely]

I still think a simple on/off switch is the real necessity!

Actually, it would be good to have that control for ILS and for the various automatic targetting systems too! (telescope has a complex version).

[dybal]

My suggestions about the last two problems:
1. Moving dockables should be stopped when receive an ILS request, like sending a radio message about "Hey, I would like to dock, so stop moving!". When targeted by ILS then set ship.maxSpeed=0 on the dockable, then restore when docked or untargeted.

For some unfathomable reason, changing the dockable maxSpeed to 0 didn't occur to me

2. The trajectory should avoid a sphere around the dockable which sized to the double of ship.collisionRadius of the dockable. As you said there is a narrow (about 30 degree) cone before the dock where the ship should approach the dock. I think when the landing ship enter into the nearby sphere using ILS out of the best cone, then should turn away from the dockable and leave the sphere. You can achieve this either by targeting some waypoints placed around the dockable, or just travel out of a larger (3x) sphere before switch back to the standard ILS approach.

That's basically what I had in mind (the waypoint variation, with the waypoint in the docking bay's "face" plane...)

I still think a simple on/off switch is the real necessity!

That would turn ILS into a primeable equipment... as you can see here, for some people the list of primeable equipment we have is already too large to cycle through.... in fact, some months back Milo got some OXP authors to change their OXP's quipments so they were not primeable anymore (Cargo Stopper and Xenon HUD mode come to mind)

[Cholmondely]

My suggestions about the last two problems:
1. Moving dockables should be stopped when receive an ILS request, like sending a radio message about "Hey, I would like to dock, so stop moving!". When targeted by ILS then set ship.maxSpeed=0 on the dockable, then restore when docked or untargeted.

For some unfathomable reason, changing the dockable maxSpeed to 0 didn't occur to me

2. The trajectory should avoid a sphere around the dockable which sized to the double of ship.collisionRadius of the dockable. As you said there is a narrow (about 30 degree) cone before the dock where the ship should approach the dock. I think when the landing ship enter into the nearby sphere using ILS out of the best cone, then should turn away from the dockable and leave the sphere. You can achieve this either by targeting some waypoints placed around the dockable, or just travel out of a larger (3x) sphere before switch back to the standard ILS approach.

That's basically what I had in mind (the waypoint variation, with the waypoint in the docking bay's "face" plane...)

I still think a simple on/off switch is the real necessity!

That would turn ILS into a primeable equipment... as you can see here, for some people the list of primeable equipment we have is already too large to cycle through.... in fact, some months back Milo got some OXP authors to change their OXP's quipments so they were not primeable anymore (Cargo Stopper and Xenon HUD mode come to mind)

Two points:
* As I hope I said above, it only makes sense for when there are more fast priming buttons than the 2 we have at the moment.
* I have been killed by pirates once in the past month (I know when to run!). But I have been killed by ILS at least 5 times!

[Norby]

For some unfathomable reason, changing the dockable maxSpeed to 0 didn't occur to me

Maybe need to force it by set velocity to zero. At last resort set the position and orientation to saved values in each frame.

That would turn ILS into a primeable equipment

How about two ILS equipment? The "Auto ILS" could be the current non-primable variant, and a simple "ILS" could get primable property, then players buy what they like.

[dybal]

Two points:
* As I hope I said above, it only makes sense for when there are more fast priming buttons than the 2 we have at the moment.
* I have been killed by pirates once in the past month (I know when to run!). But I have been killed by ILS at least 5 times!

Yep, if we had more fast-priming keys, ILS could work as the docking computer: target the station you mean to dock with, then activate it.

For some unfathomable reason, changing the dockable maxSpeed to 0 didn't occur to me

Maybe need to force it by set velocity to zero. At last resort set the position and orientation to saved values in each frame.

I will give it a try, I think setting maxSpeed to 0 will work.

That would turn ILS into a primeable equipment

How about two ILS equipment? The "Auto ILS" could be the current non-primable variant, and a simple "ILS" could get primable property, then players buy what they like.

Yep, that will work now, and I'm always in favour of giving the player the final choice!

That's a roadmap for the next ILS version

And hopefully, doing the waypoint thing will solve the NPCs splashing themselves on the back of the station...

[Cholmondely]

1) Looking at this page of posts, most of the issues should be sorted by Phkb's work on increasing the number of Fast Activation/Priming buttons for Oolite v.1.92. If there is then a primable ILS which can be turned on and off, and if the same is made true for Telescope, then it just becomes another easy item for the player to manage. So the super idea of having two purchasable variants of ILS (the current and a new primable one) would "future-proof" this oxp. (Also mentioned on cag's [Beta] Release of Telescope 2.0 thread).

2) But there is another problem which is (for me) a major immersions breaker. Once I've been near the Main Orbital Station I get messages about other ships setting their ILS to the Main Orbital S'n. Within scanner range of the "MOS", good! But when I'm 100,000 "kuː ʊm" distant on the far side of the solar system, this seems bizarre to say the least! Surely there must be some way of limiting these messages?

3) It would be good to have a description about how one docks on the tails of another ILS user (maybe even a You Tube video!). I don't want to risk my ship, so have never tried it: I'm a tad unsure about the description on the ILS wiki page...

If you target the station while another ship is using ILS then you lock on the landing ship - a help to find where it is. If you keep the station in your crosshairs when the current ship arrives into the dock then you get the right to use ILS regardless of whether there are others in the queue.

[hiran]

If someone is touching the ILS OXP it might be nice to mark compatibility issue with the Imperial Star Destroyer. And/or vice versa.

https://bb.oolite.space/viewtopic.php?p=275063#p275063

[RockDoctor]

If someone is touching the ILS OXP it might be nice to mark compatibility issue with the Imperial Star Destroyer. And/or vice versa.

https://bb.oolite.space/viewtopic.php?p=275063#p275063

I've never met an ISD, but I tried ILS-ing onto a Leviathan a few times before mussing it's paintwork. Are these things deliberately taking avoiding action, or is ILS just not able to track the moving "glide path" of a Lebviathan quickly enough?

[Slartibartfast]

hi

tweak to make the ILS removable

/config/equipment.plist

Code: Select all

// test
(
   (
      4,
      500,
      "ILS Instrument Landing System",
      "EQ_ILS",
      "ILS will guide your ship into the dock of the station you targeted. The speed controls are in your hand so you can ignite Injectors to arrive faster or stop to avoid collisions.",
       {
	   "available_to_all" = yes;
	   "available_to_NPCs" = yes;
	   "available_to_player" = yes;
	   "damage_probability" = 1.0;
	   "fast_affinity_defensive" = no;
	   "fast_affinity_offensive" = no;
	   "portable_between_ships" = no;
	   "requires_cargo_space" = 0;
	   "requires_clean" = no;
	   "requires_empty_pylon" = no;
	   "requires_free_passenger_berth" = no;
	   "requires_full_fuel" = no;
	   "requires_mounted_pylon" = no;
	   "requires_non_full_fuel" = no;
//	   "script" = "ils.js";
	   "strict_mode_only" = no;
	   "strict_mode_compatible" = yes;
	   "visible" = yes; // listed on the F5F5 screen.
       }
    ),
// begin: added by Slartibartfast
    (
	4,
	250,
	"Remove ILS Instrument Landing System",
	"EQ_ILS_REMOVAL",
	"removes the ILS for 25 credits.",
		{
		"available_to_all" = yes;
		"requires_equipment" = "EQ_ILS";
		}
	)
// end:	added by Slartibartfast
)

/config/world-scripts.plist

Code: Select all

(
	"removescript.js",
	"ils.js"
)

/Scripts/removescript.js ( add new file )

Code: Select all

// remove script for ILS - based on beercooler

this.name           = "ILS.oxp";
this.description    = "script for removing the ILS";
this.author         = "Slartibartfast";
this.copyright      = "no© 2022 Slartibartfast";
this.license				= "CC-by-nc-sa 3.0"; // .. necessary?
this.version        = "0.1.0";


this.playerBoughtEquipment = function(equipmentKey)
{
	if(equipmentKey == "EQ_ILS_REMOVAL")
	{
		player.ship.removeEquipment("EQ_ILS");
		player.ship.removeEquipment("EQ_ILS_REMOVAL");
	}
}

[Cholmondely]

Downside Up!

Am I correct in presuming that ILS always docks upside down? Whenever there is a docking bay with a "right way up" (eg Imperial AstroFactory, SLAPU, Hathor, Transhab) often determined by writing inside the bay, for example, ILS will dock upside down.

Since one is in space without gravity, I could understand this happening half of the time. But every single time?

Experiment carried out with my usual cocktail of oxp's but also a special try-out with just ILS & the Imperial AstroFactory loaded...

[Cody]

The Coriolis docking bay has a "right way up" too!