Crash in 1.90 Fixed

[another_commander]

Yesterday we received a bug report notifying us about Oolite crashing when the Equipment by Ship Class OXP is in use. Further investigation revealed a core engine issue. It was an edge case and a rare occurrence, but it still caused termination by throwing an exception at startup. If you really need this OXP (and any OXP defining equipment in equipment.plist without an extra info dictionary), please note that this issue is now fixed as of commit 6b45ec2.

Some more information about the issue, together with a quick fix on the OXP and a link to a Win64 binary that incorporates the proper fix can be found here.

[Redspear]

Coincidentally (if belateldly), I've logged in today to post some update info about that oxp...

As the author, is this bad practice on my part?

defining equipment in equipment.plist without an extra info dictionary

If so, how does one go about remedying it?

Apologies for not RTFM but is there a page someone can point me to?

[another_commander]

As the author, is this bad practice on my part?

defining equipment in equipment.plist without an extra info dictionary

If so, how does one go about remedying it?

No, it is not bad practice, I think. It is just unusual. Most of the time there will be at least something like an "available_to_all" key or similar, so it is very rare to not have an extra info dictionary. But it happened here with a test piece of equipment. If there was one bad practice I can think of, it is leaving test stuff inside a released OXP.

Remedying it as very simple. Following the fix applied already in trunk, you don't have to act at all. If you do want to do something about it though, you can just define an empty extra info dictionary and 1.90 will accept it and move happily on.

[Redspear]

It is just unusual

Guilty m'lud

If there was one bad practice I can think of, it is leaving test stuff inside a released OXP.

I thought that might be useful for tinkerers, like leaving the comments in..?

Remedying it as very simple. Following the fix applied already in trunk, you don't have to act at all.

Awesome! Thanks