Crash in 1.90 Fixed

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6681
Joined: Wed Feb 28, 2007 7:54 am

Crash in 1.90 Fixed

Post by another_commander »

Yesterday we received a bug report notifying us about Oolite crashing when the Equipment by Ship Class OXP is in use. Further investigation revealed a core engine issue. It was an edge case and a rare occurrence, but it still caused termination by throwing an exception at startup. If you really need this OXP (and any OXP defining equipment in equipment.plist without an extra info dictionary), please note that this issue is now fixed as of commit 6b45ec2.

Some more information about the issue, together with a quick fix on the OXP and a link to a Win64 binary that incorporates the proper fix can be found here.
User avatar
Redspear
---- E L I T E ----
---- E L I T E ----
Posts: 2685
Joined: Thu Jun 20, 2013 10:22 pm
Location: On the moon Thought, orbiting the planet Ignorance.

Re: Crash in 1.90 Fixed

Post by Redspear »

Coincidentally (if belateldly), I've logged in today to post some update info about that oxp...

As the author, is this bad practice on my part?
another_commander wrote: Sat Oct 10, 2020 12:54 pm
defining equipment in equipment.plist without an extra info dictionary
If so, how does one go about remedying it?

Apologies for not RTFM but is there a page someone can point me to?
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6681
Joined: Wed Feb 28, 2007 7:54 am

Re: Crash in 1.90 Fixed

Post by another_commander »

Redspear wrote: Fri Nov 06, 2020 8:48 pm
As the author, is this bad practice on my part?
another_commander wrote: Sat Oct 10, 2020 12:54 pm
defining equipment in equipment.plist without an extra info dictionary
If so, how does one go about remedying it?
No, it is not bad practice, I think. It is just unusual. Most of the time there will be at least something like an "available_to_all" key or similar, so it is very rare to not have an extra info dictionary. But it happened here with a test piece of equipment. If there was one bad practice I can think of, it is leaving test stuff inside a released OXP. :-)

Remedying it as very simple. Following the fix applied already in trunk, you don't have to act at all. If you do want to do something about it though, you can just define an empty extra info dictionary and 1.90 will accept it and move happily on.
User avatar
Redspear
---- E L I T E ----
---- E L I T E ----
Posts: 2685
Joined: Thu Jun 20, 2013 10:22 pm
Location: On the moon Thought, orbiting the planet Ignorance.

Re: Crash in 1.90 Fixed

Post by Redspear »

another_commander wrote: Fri Nov 06, 2020 9:00 pm
It is just unusual
Guilty m'lud :lol:

another_commander wrote: Fri Nov 06, 2020 9:00 pm
If there was one bad practice I can think of, it is leaving test stuff inside a released OXP.
I thought that might be useful for tinkerers, like leaving the comments in..?

another_commander wrote: Fri Nov 06, 2020 9:00 pm
Remedying it as very simple. Following the fix applied already in trunk, you don't have to act at all.
Awesome! Thanks :P
Post Reply