About planets

An area for discussing new ideas and additions to Oolite.

Moderators: winston, another_commander

User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Re: About planets

Post by Diziet Sma »

submersible wrote:
Lestradae wrote:
So, any chance of this making its way into trunk in the foreseeable future then?
Not yet - and I've been tinkering for a while. I think the approach is right - but the coordinate space it's being applied in is wrong. The geometry is doing my head in.
Have you considered collaborating with kanthoney? Judging by the way he was able to sort out the sharp terminator problems, he seems to have some grasp of that kind of stuff.. another pair of eyeballs might be helpful.
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
User avatar
kanthoney
Commodore
Commodore
Posts: 281
Joined: Thu Nov 07, 2013 10:21 pm

Re: About planets

Post by kanthoney »

Hmmm. Nice of you to say...

I'm comfortable with matrix transforms and maths and stuff, but not that familiar with OpenGL (yet).

What I did find when digging through the planet shader thing was that a startling amount of Oolite's OpenGL code is using techniques that have been depreciated. This shouldn't matter, in theory, because OpenGL is supposed to remain backwards compatible so you can use old techniques, but the planet shader was one case where it did matter: back in days of yore, OpenGL used to work out a matrix called gl_NormalMatrix for you. This feature got depreciated - you're now supposed to work it out yourself and pass it through to the shader, I think - so some graphics cards don't bother, even if you're using compatibilty mode. The knock on effect of this was the crappy terminator. I accidentally found a bodge which changed the problem to one that's less obvious - it's now just ignoring the normal mapping of the texture instead on affected cards.

So, we could probably do with an overhaul of the OpenGL code in Oolite. The problems are 1) there's a lot of OpenGL code in Oolite and I, for one, wouldn't know where to start; and 2) if you did update it all, you'd presumably break all the third party shaders and stuff.
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4072
Joined: Fri Nov 11, 2011 6:19 pm

Re: About planets

Post by cim »

Part of it is that our official OpenGL target is 1.1: the code should run on any card which supports that level, though if there was something put in which broke that, I'm not sure we'd notice. Judging by the responses to the graphics survey, we could probably safely go to 1.3 (cube map texture support) or maybe even 1.4, but we definitely still have players on 1.4-level graphics cards.

Provided you check for the necessary OpenGL extension or version before doing things, though - and have a fallback if it's not available - you can use even OpenGL 4 features if you want. For optional effects, you could put in a new graphics quality level which required OpenGL 3 or 4, and make sure the maximum was set properly (as it is now where the shader options just don't appear if you have a 1.x card)
User avatar
submersible
Commodore
Commodore
Posts: 264
Joined: Thu Nov 10, 2011 7:49 am

Re: About planets

Post by submersible »

Pushed to github , shady-atmos branch.

Image

Image

Image

Image

Image

Image
Last edited by submersible on Sat Mar 31, 2018 11:11 pm, edited 1 time in total.
User avatar
Disembodied
Jedi Spam Assassin
Jedi Spam Assassin
Posts: 6885
Joined: Thu Jul 12, 2007 10:54 pm
Location: Carter's Snort

Re: About planets

Post by Disembodied »

Outstanding! 8)
User avatar
Griff
Oolite 2 Art Director
Oolite 2 Art Director
Posts: 2484
Joined: Fri Jul 14, 2006 12:29 pm
Location: Probably hugging his Air Fryer

Re: About planets

Post by Griff »

Amazing work submersible! That looks absolutely stunning
Zireael
---- E L I T E ----
---- E L I T E ----
Posts: 1396
Joined: Tue Nov 09, 2010 1:44 pm

Re: About planets

Post by Zireael »

This is amazing! You're putting Povray out of use, submersible!
User avatar
pagroove
---- E L I T E ----
---- E L I T E ----
Posts: 3035
Joined: Wed Feb 21, 2007 11:52 pm
Location: On a famous planet

Re: About planets

Post by pagroove »

Absolutely magnificent. When is this in the trunk? :?: :shock: :D :lol: 8)
For P.A. Groove's music check
https://soundcloud.com/p-a-groove
Famous Planets v 2.7. (for Povray)
Image
https://bb.oolite.space/viewtopic.php?f=4&t=13709
User avatar
submersible
Commodore
Commodore
Posts: 264
Joined: Thu Nov 10, 2011 7:49 am

Re: About planets

Post by submersible »

pagroove wrote:
Absolutely magnificent. When is this in the trunk? :?: :shock: :D :lol: 8)
From the right angles - it looks really good. Still making a lot of compromises. This for example sacrifices the clouds entirely. I'm considering an extra pass in additive blending mode so as to have both clouds and scattering effects. Oh- and this shader just cooks the GPU, my laptop cannot cope with it.

On trunk when. .. this year maybe?
User avatar
submersible
Commodore
Commodore
Posts: 264
Joined: Thu Nov 10, 2011 7:49 am

Re: About planets

Post by submersible »

submersible wrote: Mon Mar 17, 2014 8:54 am
On trunk when. .. this year maybe?
Worst developer estimate ever.

Looking at github - I don't think shady-planets has moved along since I lost motivation and disappeared for many years. Digging through the changelog for oolite it does not seem like anything similar has landed for planets + atmosphere and material descriptions in planetinfo.plist that are like ship material dictionaries. I'm going to try merging master back into it and survey the carnage.

Would shady-planets features still be interesting to the community given the advent of reshade and the disruption of elite-dangerous ?
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: About planets

Post by Cody »

Short answer: yes!
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6696
Joined: Wed Feb 28, 2007 7:54 am

Re: About planets

Post by another_commander »

The atmospheric scattering effects we have right now are not the result of Reshade (which is Windows only btw), but new shaders that have been added relatively recently. However, the shader we use now is a good enough approximation of scattering and is very simple in its core. If I remember right, the shady planets tried to utilize physically correct calculations. So yes, it would be very interesting to see if the atmoscattering shaders can be further improved.
Post Reply