Trunk nightly

[another_commander]

Got a bit of a scare with this, but it seems it's all good. Cody, your log is full of this stuff:

21:52:16.347 [collisionRegion.debug]: DEBUG Testing collision between <ShipEntity 0xdbddea0>{"Asteroid" position: (7715.58, 51459.2, 294834) scanClass: CLASS_ROCK status: STATUS_IN_FLIGHT} (NO) and <ShipEntity 0xdbdec30>{"Asteroid" position: (8081.83, 52011.4, 295344) scanClass: CLASS_ROCK status: STATUS_IN_FLIGHT} (NO)

What happened is that you accidentally turned on the collisions check debug flag, which is activated by pausing and pressing "b". The trunk is still stable (phew).

[Cody]

<scratches head - chortles> Pause+b? No idea how I could've done that, but there you go - thanks!

[Cody]

EDIT 2017-09-15
Good news. Just got a spare hdd to proceed with the troubleshooting.
Due to R/L priorities, I will be taking over these tasks this Monday.

Cool! I'd missed those updates as edits don't show as a new post.

[Cody]

The auto-updater seems to be working.

[Getafix]

The auto-updater seems to be working.

Well, the server is temporarily up, since there were some code updates.
It is still unstable, though.

[hoqllnq]

For me, the direction cue indicator in the HUD is broken in head of master.
Probably since 24bf8a05.

Changing this:
[[_reticleColors objectAtIndex:cueColorIndex] greenComponent]
to this:
[(OOColor*)[_reticleColors objectAtIndex:cueColorIndex] greenComponent]
(for all components in both arrays)
fixes it.

It also gets rid of compiler warnings for "Multiple Methods for xxxComponent".

Here is a diff that does just that.
This one is a bit nicer.


(OSX 10.10.5, xcode 7.1)

[another_commander]

No problem merging your fix (the second one is the good one to go with), but what exactly was broken with the direction cue before?

[hoqllnq]

what exactly was broken with the direction cue before?

It did not show up at all.

I noticed it missing, checked equipment and OXPs, then realised I ran trunk. Tried 1.84 and it was there.
So I looked at where it should be drawn, saw a bunch of warnings and a recent change. Tried this and it worked.

I don't know why. Stepping through in the debugger, it goes into OOColor, not NSColor, but afterwards, both arrays show {0,0,0,0}. Even when running debug build, which I guess doesn't optimize it away.

I could look into it a bit more later.

[another_commander]

I think your fix is OK and will commit it shortly. As far as I can tell it is the same code behaviour, which is why I asked what was wrong. It is actually quite a bit cleaner than what we had there. Also, please check your PMs in a couple of minutes.

[another_commander]

The retricle direction cue indicator should now be back on the Macs. I committed also a few more warning fixes of the same type as those corrected by hoqllnq, so now the reticle should be OK also for targeting wormholes.

[hoqllnq]

Here is another one.
It implements MyOpenGLView::stringToClipboard() for Mac,
so you can get the OXP info URLs from the manager.

By the way, is this the appropriate place to post these, seeing as it is not a bug report, or is there a 'patch submission'-thread?

[another_commander]

Here is another one.
It implements MyOpenGLView::stringToClipboard() for Mac,
so you can get the OXP info URLs from the manager.

Thanks for that. Should there be a check that the string passed to to the method is not nil or it works OK all the same? Unfortunately I cannot test it myself. If it is OK, I will commit this once we have a confirmation.

By the way, is this the appropriate place to post these, seeing as it is not a bug report, or is there a 'patch submission'-thread?

The best way to send in patches is to submit them as pull requests on github. You can find information on how to do this here.

[hoqllnq]

Should there be a check that the string passed to to the method is not nil or it works OK all the same?

I had not tested that. I have now. It works properly and makes/leaves the clipboard empty.

[another_commander]

Fantastic, patch committed. Thanks.

[Cody]

Terrastorage is down - is the latest Windows nightly missing from GitHub? Or am I missing something?