Contracts in Trunk 5595

[JazHaz]

r5595 | cim | 2012-12-30 14:53:17 +0200 | 2 lines

Fix bugs found by Eric in contracts APIs

I'm playing 5595 currently, trying to accept a cargo contract, I get the BGS sound for accepted contract, however the contract doesn't get accepted and the contracts screen redraws with the same contract again.

[another_commander]

Accepting contracts seems to work fine here. Can you provide more information? Upload the savegame maybe, with instructions what exactly one needs to do for reproducing? Also, list of OXPs?

[cim]

r5595 | cim | 2012-12-30 14:53:17 +0200 | 2 lines

Fix bugs found by Eric in contracts APIs

I'm playing 5595 currently, trying to accept a cargo contract, I get the BGS sound for accepted contract, however the contract doesn't get accepted and the contracts screen redraws with the same contract again.

Hmm... I forgot to update the cache format number with that one. Try shift-restarting to make sure you've got the up-to-date scripts.

[JazHaz]

I'm playing 5595 currently, trying to accept a cargo contract, I get the BGS sound for accepted contract, however the contract doesn't get accepted and the contracts screen redraws with the same contract again.

Hmm... I forgot to update the cache format number with that one. Try shift-restarting to make sure you've got the up-to-date scripts.

I have the "brick on my shift key" option set so it reloads the cache every time.

In my second session it all worked fine.

[cim]

Hmm... odd, then. The success sound is only played if player.ship.awardContract returns true, and it plays after the accepted contract is removed from the list. Was there anything on the "current contracts" list on F5 F5 after it failed to accept?

The BGS "accepted" and "rejected" sounds are fairly similar - is it possible that you mistook one for the other? (You should only be able to hear the "rejected" sound if another OXP adjusts your money/hold space levels between the contract details page being displayed, and you selecting "accept contract", so that's also unusual...)

[JazHaz]

Hmm... odd, then. The success sound is only played if player.ship.awardContract returns true, and it plays after the accepted contract is removed from the list. Was there anything on the "current contracts" list on F5 F5 after it failed to accept?

Yes I had a pre-existing contract. Just couldn't add a new one.

[Solonar]

While using trunk 5603 I am also having issues with the cargo contracts. It is refusing to let me accept any cargo contract involving gemstones. I clickie to accept the cargo contract but I get rejected. It seems only to be with gemstone contracts as I have taken platinum, gold, and numerous other cargo contracts with no issues.

[cim]

I bet Liquor/Wines contracts are also a problem... Thank you, that was just what I needed to track this one down. Should be fixed now (r5606)

[Solonar]

Thank you and you're welcome!