Code: Select all
var excl = new Array();
if (missionVariables.famous_planets) {
excl.push(8, 130, 40, 125, 247, 101, 56, 155, 149, 142);
}
for (var i = 0; i < excl.length; i++) this.system_info[excl[i]] = 0;
Moderators: winston, another_commander
Code: Select all
var excl = new Array();
if (missionVariables.famous_planets) {
excl.push(8, 130, 40, 125, 247, 101, 56, 155, 149, 142);
}
for (var i = 0; i < excl.length; i++) this.system_info[excl[i]] = 0;
Cmd. Cheyd wrote:Code: Select all
system.mainPlanet.texture = 'home_planet' & (((this.system_info[galaxyNumber * 256 + system.ID + 1] & 0xFF000) >> 12) + 1) & '.png';
Don't use Famous Planets so that should affect me.CaptKev wrote:Try deleting this section of code
Code: Select all
var excl = new Array(); if (missionVariables.famous_planets) { excl.push(8, 130, 40, 125, 247, 101, 56, 155, 149, 142); } for (var i = 0; i < excl.length; i++) this.system_info[excl[i]] = 0;
Thanks to Gimi, I got an eBook in my inbox tonight (31st May 2014 - Release of Elite Reclamation)!Gimi wrote:Maybe you could start a Kickstarter Campaign to found your £4500 pledge.drew wrote:£4,500 though! <Faints>
Cheers,
Drew.
It seems as bad programming to me: recognising the existance of an oxp by setting a missionVariable because that variable will stay there, even if the oxp is removed. Better check if the oxp itself is installed by checking if "worldScripts.famous_planets" exists. (Or whathever the script of famous planets is called by this.name in its script)JazHaz wrote:Don't use Famous Planets so that should affect me.CaptKev wrote:Try deleting this section of code
Code: Select all
var excl = new Array(); if (missionVariables.famous_planets) { excl.push(8, 130, 40, 125, 247, 101, 56, 155, 149, 142); } for (var i = 0; i < excl.length; i++) this.system_info[excl[i]] = 0;
Sorry, I didn't realise world scripts existed back in 2007 when System Redux was written.Eric Walch wrote:It seems as bad programming to me: recognising the existance of an oxp by setting a missionVariable because that variable will stay there, even if the oxp is removed. Better check if the oxp itself is installed by checking if "worldScripts.famous_planets" exists. (Or whathever the script of famous planets is called by this.name in its script)JazHaz wrote:Don't use Famous Planets so that should affect me.CaptKev wrote:Try deleting this section of code
Code: Select all
var excl = new Array(); if (missionVariables.famous_planets) { excl.push(8, 130, 40, 125, 247, 101, 56, 155, 149, 142); } for (var i = 0; i < excl.length; i++) this.system_info[excl[i]] = 0;
I am talking about the check in the original systemRedux. The deep horizon version of Cmd. Cheyd does check correctly for the oxp itself being installed.