Split: SR1 troubleshooting

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: winston, another_commander

User avatar
CaptKev
---- E L I T E ----
---- E L I T E ----
Posts: 519
Joined: Fri Jan 26, 2007 3:21 pm
Location: Shropshire, UK

Post by CaptKev »

Try deleting this section of code

Code: Select all

	var excl = new Array();

	if (missionVariables.famous_planets) {
		excl.push(8, 130, 40, 125, 247, 101, 56, 155, 149, 142);
	}	

	for (var i = 0; i < excl.length; i++) this.system_info[excl[i]] = 0;
Download Fighter HUD, Stingray and System Redux from the EliteWiki
User avatar
Cmd. Cheyd
---- E L I T E ----
---- E L I T E ----
Posts: 934
Joined: Tue Dec 16, 2008 2:52 pm
Location: Deep Horizon Industries Manufacturing & Research Site somewhere in G8...

Post by Cmd. Cheyd »

Apparently I'm talking to myself for the sheer joy of listening to my own keystrokes... :roll: :roll:

Edited to save folks the time of scrolling up...
Cmd. Cheyd wrote:

Code: Select all

system.mainPlanet.texture = 'home_planet' & (((this.system_info[galaxyNumber * 256 + system.ID + 1] & 0xFF000) >> 12) + 1) & '.png';
User avatar
JazHaz
---- E L I T E ----
---- E L I T E ----
Posts: 2991
Joined: Tue Sep 22, 2009 11:07 am
Location: Enfield, Middlesex
Contact:

Post by JazHaz »

CaptKev wrote:
Try deleting this section of code

Code: Select all

	var excl = new Array();

	if (missionVariables.famous_planets) {
		excl.push(8, 130, 40, 125, 247, 101, 56, 155, 149, 142);
	}	

	for (var i = 0; i < excl.length; i++) this.system_info[excl[i]] = 0;
Don't use Famous Planets so that should affect me.
JazHaz

Gimi wrote:
drew wrote:
£4,500 though! :shock: <Faints>
Cheers,
Drew.
Maybe you could start a Kickstarter Campaign to found your £4500 pledge. 8)
Thanks to Gimi, I got an eBook in my inbox tonight (31st May 2014 - Release of Elite Reclamation)!
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Post by Eric Walch »

JazHaz wrote:
CaptKev wrote:
Try deleting this section of code

Code: Select all

	var excl = new Array();

	if (missionVariables.famous_planets) {
		excl.push(8, 130, 40, 125, 247, 101, 56, 155, 149, 142);
	}	

	for (var i = 0; i < excl.length; i++) this.system_info[excl[i]] = 0;
Don't use Famous Planets so that should affect me.
It seems as bad programming to me: recognising the existance of an oxp by setting a missionVariable because that variable will stay there, even if the oxp is removed. Better check if the oxp itself is installed by checking if "worldScripts.famous_planets" exists. (Or whathever the script of famous planets is called by this.name in its script)

I am talking about the check in the original systemRedux. The deep horizon version of Cmd. Cheyd does check correctly for the oxp itself being installed.
User avatar
CaptKev
---- E L I T E ----
---- E L I T E ----
Posts: 519
Joined: Fri Jan 26, 2007 3:21 pm
Location: Shropshire, UK

Post by CaptKev »

Eric Walch wrote:
JazHaz wrote:
CaptKev wrote:
Try deleting this section of code

Code: Select all

	var excl = new Array();

	if (missionVariables.famous_planets) {
		excl.push(8, 130, 40, 125, 247, 101, 56, 155, 149, 142);
	}	

	for (var i = 0; i < excl.length; i++) this.system_info[excl[i]] = 0;
Don't use Famous Planets so that should affect me.
It seems as bad programming to me: recognising the existance of an oxp by setting a missionVariable because that variable will stay there, even if the oxp is removed. Better check if the oxp itself is installed by checking if "worldScripts.famous_planets" exists. (Or whathever the script of famous planets is called by this.name in its script)

I am talking about the check in the original systemRedux. The deep horizon version of Cmd. Cheyd does check correctly for the oxp itself being installed.
Sorry, I didn't realise world scripts existed back in 2007 when System Redux was written.

I created a template for PAGroove to use for his Famous Planets and thought I would make it compatible with my OXP.

Nobody said I was any good at programing, but I do try! :oops:
Download Fighter HUD, Stingray and System Redux from the EliteWiki
User avatar
Cmd. Cheyd
---- E L I T E ----
---- E L I T E ----
Posts: 934
Joined: Tue Dec 16, 2008 2:52 pm
Location: Deep Horizon Industries Manufacturing & Research Site somewhere in G8...

Post by Cmd. Cheyd »

I'll ask again - Can a Moderator split the SR1 troubleshooting to it's own thread?
Post Reply