Problem: Flasher with size = zero

Yrol_Denjeah · Post by **Yrol_Denjeah** » Wed Apr 28, 2010 8:03 pm

I just tried to get rid of the center yellow flasher from the
fuelstation and fuelsatellite. ( its a bit big in the station )
and think, i stumbled about a potential crasher.

I resized the flasher to size 0 and oolite wouldnt start anymore.
so i resized it again and could play again.

It could, i think, crash oolite to desktop, if a flasher is used
somewhere that changes size from 10 to 0 and then
back to 10 again.

( by the waysside... does this thread belong here or in the
Expansion thread? if the latter is the case, please move it )

Commander McLane · Post by **Commander McLane** » Thu Apr 29, 2010 10:43 am

Flashers can't change size, so there will be no problem. And usually nobody would want to define a flasher with size zero. Still, I think it should be handled gracefully.

So, thanks for the report!

JensAyton · Post by **JensAyton** » Thu Apr 29, 2010 8:05 pm

Fixed in r3244.

Wiki pages · Post by **Thargoid** » Thu Apr 29, 2010 8:19 pm

Which versions are you using (of Oolite and Fuel Station OXP)?

I did notice that the old style flashers appear larger under 1.74 than 1.73.4 - that's fixed in the 1.74 version of Fuel Station by shrinking them a bit.

JensAyton · Post by **JensAyton** » Thu Apr 29, 2010 8:47 pm

Thargoid wrote:
I did notice that the old style flashers appear larger under 1.74 than 1.73.4 - that's fixed in the 1.74 version of Fuel Station by shrinking them a bit.

They’re not supposed to, and don’t here. Could you provide screen shots?

And, you know, report bugs when things break?

Wiki pages · Post by **Thargoid** » Fri Apr 30, 2010 6:57 am

I'll see what I can do, but it's not so easy for some of them as the flashers, umm, flash.

And as for reporting, I think I mentioned it to one or two people, but Kaks seems to have enough of my bugs to work on at the minute, and you seem to be more interested in cube maps at the moment...

Post by **Cmdr James** » Fri Apr 30, 2010 8:00 am

Please report all bugs at http://developer.berlios.de/bugs/?group_id=3577 so that we have a record, and can fix it.

JensAyton · Post by **JensAyton** » Fri Apr 30, 2010 9:54 am

Thargoid wrote:
And as for reporting, I think I mentioned it to one or two people, but Kaks seems to have enough of my bugs to work on at the minute, and you seem to be more interested in cube maps at the moment...

Bugs don’t go away just because we don’t have time to fix them immediately.

Trust me, I know this from experience.

Wiki pages · Post by **Thargoid** » Fri Apr 30, 2010 1:07 pm

OK, it's submitted (with the caveat that it could also be the model that's smaller). Not going to have time to do any screenshots etc before next week, but as a test use either Fuel Station or Gates under 1.73.4 and 1.74 and spot the difference. Use the original version of the OXPs (the 1.73.4 ones) as then 1.74 beta's have the flashers shrunk a little to compensate.

JensAyton · Post by **JensAyton** » Sun May 02, 2010 11:17 am

This has nothing to do with size… just adjusted distance. Which is a function of size. Um.

Anyway, fixed, and this probably addresses a vague complaint from Frame a while back too.

Frame · Post by **Frame** » Sun May 02, 2010 12:46 pm

Ahruman wrote:
This has nothing to do with size… just adjusted distance. Which is a function of size. Um.

Anyway, fixed, and this probably addresses a vague complaint from Frame a while back too.

Complaint ?...

Please Specify

Cheers Frame...

JensAyton · Post by **JensAyton** » Sun May 02, 2010 12:55 pm

You had a problem with flashers in recessed areas of your B5ish thingummy.

Post by **Eric Walch** » Sun May 02, 2010 1:15 pm

Ahruman wrote:
This has nothing to do with size… just adjusted distance. Which is a function of size. Um.

Anyway, fixed, and this probably addresses a vague complaint from Frame a while back too.

Yep. Just looked at the fuel-pod from Cargo & Wrecks. At close range and certain angles it did shine through the mesh at some places at a wrong way.
Since your latest commit this is now corrected.

However it seems one bug to many was fixed. In space, laser light is invisible because there is no dust it can scatter on. I noticed NPC lasers now work this way. My ship gets hits but I see no laser flashes. In external views I do see the impacts on my hull. The laser of the player is visible as always. Never had this behaviour before so I expect its introduced in yesterdays/todays commit. (Probably 3259 as there are changes to visiblity)
EDIT: fixed laser fire with revision 3265. Hope I broke nothing else by reinstalling the removed check.