Arriving in a new galaxy
Moderators: winston, another_commander, Getafix
- Disembodied
- Jedi Spam Assassin
- Posts: 6885
- Joined: Thu Jul 12, 2007 10:54 pm
- Location: Carter's Snort
Arriving in a new galaxy
Not so much a bug as a typo, I think: jumping in to Galaxy 4 I got a brief flash of text welcoming me to Galaxy 3 ...
- JazHaz
- ---- E L I T E ----
- Posts: 2991
- Joined: Tue Sep 22, 2009 11:07 am
- Location: Enfield, Middlesex
- Contact:
I seem to remember that being reported before. A couple of months ago at least.
JazHaz
Thanks to Gimi, I got an eBook in my inbox tonight (31st May 2014 - Release of Elite Reclamation)!Gimi wrote:Maybe you could start a Kickstarter Campaign to found your £4500 pledge.drew wrote:£4,500 though! <Faints>
Cheers,
Drew.
- JensAyton
- Grand Admiral Emeritus
- Posts: 6657
- Joined: Sat Apr 02, 2005 2:43 pm
- Location: Sweden
- Contact:
Re: Arriving in a new galaxy
That text isn’t coming from core Oolite.Disembodied wrote:Not so much a bug as a typo, I think: jumping in to Galaxy 4 I got a brief flash of text welcoming me to Galaxy 3 ...
E-mail: [email protected]
- Disembodied
- Jedi Spam Assassin
- Posts: 6885
- Joined: Thu Jul 12, 2007 10:54 pm
- Location: Carter's Snort
Tut. You're right, it's in the Galactic Navy OXP scripts. It says
Presumably it needs to be
?
Or would that be too easy?
Code: Select all
this.playerEnteredNewGalaxy = function(galaxyNumber)
{
if(missionVariables.reserve_status == "STATUS_ENLISTED")
player.consoleMessage("Gal Navy: Transferring you to Galaxy " + galaxyNumber + "'s Naval jurisdiction.");
if(missionVariables.reserve_offer != "OFFER_OPEN" && missionVariables.reserve_offer != "MISSION_ACCOMPLISHED" && missionVariables.reserve_offer != "OBJECTIVES_COMPLETE" && missionVariables.reserve_offer != "OFFER_COMPLETED")
{
player.consoleMessage("Gal Navy: You have left the galaxy your mission was assigned in.");
player.consoleMessage("Gal Navy: Please report to the nearest SecCom station for another mission.");
this.ReserveDutyCleanup();
}
}
Code: Select all
player.consoleMessage("Gal Navy: Transferring you to Galaxy " + galaxyNumber+1 + "'s Naval jurisdiction.");
Or would that be too easy?
- Disembodied
- Jedi Spam Assassin
- Posts: 6885
- Joined: Thu Jul 12, 2007 10:54 pm
- Location: Carter's Snort
Ahruman wrote:Quite correct.
OK, fair enough. It should of course be changed to
Code: Select all
player.consoleMessage("Gal Navy: Transferring you to Galaxy " + (galaxyNumber+1) + "'s Naval jurisdiction.");
If anyone else wants to make this massive bugfix, and doesn't mind taking programming hints from Testy O'Pilot, open up the Galactic Navy OXP, open up the Scripts, find "galnavymain.js" and change
Code: Select all
player.consoleMessage("Gal Navy: Transferring you to Galaxy " + galaxyNumber + "'s Naval jurisdiction.");
Code: Select all
player.consoleMessage("Gal Navy: Transferring you to Galaxy " + (galaxyNumber+1) + "'s Naval jurisdiction.");
- Disembodied
- Jedi Spam Assassin
- Posts: 6885
- Joined: Thu Jul 12, 2007 10:54 pm
- Location: Carter's Snort
- JazHaz
- ---- E L I T E ----
- Posts: 2991
- Joined: Tue Sep 22, 2009 11:07 am
- Location: Enfield, Middlesex
- Contact:
Thanks! Although I seemed to have missed you saying that in the corrected script response!Disembodied wrote:It's in "galnavymain.js", in Galactic Navy version 5.2.2.JazHaz wrote:can't find this code. which script is it in?
JazHaz
Thanks to Gimi, I got an eBook in my inbox tonight (31st May 2014 - Release of Elite Reclamation)!Gimi wrote:Maybe you could start a Kickstarter Campaign to found your £4500 pledge.drew wrote:£4,500 though! <Faints>
Cheers,
Drew.