Arriving in a new galaxy

[Disembodied]

Not so much a bug as a typo, I think: jumping in to Galaxy 4 I got a brief flash of text welcoming me to Galaxy 3 ...

[JazHaz]

I seem to remember that being reported before. A couple of months ago at least.

[JensAyton]

Not so much a bug as a typo, I think: jumping in to Galaxy 4 I got a brief flash of text welcoming me to Galaxy 3 ...

That text isn’t coming from core Oolite.

[Disembodied]

Tut. You're right, it's in the Galactic Navy OXP scripts. It says

Code: Select all

this.playerEnteredNewGalaxy = function(galaxyNumber)
{
	if(missionVariables.reserve_status == "STATUS_ENLISTED")
		player.consoleMessage("Gal Navy: Transferring you to Galaxy " + galaxyNumber + "'s Naval jurisdiction.");

	if(missionVariables.reserve_offer != "OFFER_OPEN" && missionVariables.reserve_offer != "MISSION_ACCOMPLISHED" && missionVariables.reserve_offer != "OBJECTIVES_COMPLETE" && missionVariables.reserve_offer != "OFFER_COMPLETED")
	{
		player.consoleMessage("Gal Navy: You have left the galaxy your mission was assigned in.");
		player.consoleMessage("Gal Navy: Please report to the nearest SecCom station for another mission.");
		this.ReserveDutyCleanup();
	}
	
}

Presumably it needs to be

Code: Select all

player.consoleMessage("Gal Navy: Transferring you to Galaxy " + galaxyNumber+1 + "'s Naval jurisdiction.");

?

Or would that be too easy?

[JensAyton]

Quite correct.

[Disembodied]

Quite correct.

OK, fair enough. It should of course be changed to

Code: Select all

player.consoleMessage("Gal Navy: Transferring you to Galaxy " + (galaxyNumber+1) + "'s Naval jurisdiction.");

My new clone, Testy O'Pilot, has just jumped into Galaxy 5 and got welcomed to Galaxy 5's jurisdiction. After being surprised, on his previous flight, to receive a welcome to Galaxy 41 ...

If anyone else wants to make this massive bugfix, and doesn't mind taking programming hints from Testy O'Pilot, open up the Galactic Navy OXP, open up the Scripts, find "galnavymain.js" and change

Code: Select all

player.consoleMessage("Gal Navy: Transferring you to Galaxy " + galaxyNumber + "'s Naval jurisdiction.");

to

Code: Select all

player.consoleMessage("Gal Navy: Transferring you to Galaxy " + (galaxyNumber+1) + "'s Naval jurisdiction.");

[JazHaz]

can't find this code. which script is it in?

[Disembodied]

can't find this code. which script is it in?

It's in "galnavymain.js", in Galactic Navy version 5.2.2.

[JazHaz]

can't find this code. which script is it in?

It's in "galnavymain.js", in Galactic Navy version 5.2.2.

Thanks! Although I seemed to have missed you saying that in the corrected script response!