Core Code Bug

[Cmd. Cheyd]

Oolite 1.74.2
NO OXP's

Issue:
When flying a ship without an Advance Space Compass, the compass never changes to display the square station indicator when approaching a planet. Confirmed by 3 players in addition to myself.

Repro:
New Jameson. Launch from Station. Press \ (or your system's equivalent key).

[Cody]

It’s been a while since I had a damaged ASC… but I don’t recall it ever changing to the square without the ASC.

[another_commander]

Am I missing something? Where is the bug? This is the same behaviour as v1.65 and works as required.

[Cmd. Cheyd]

I thought (and maybe I'm wrong) that it was supposed to change to a square when within range of the planet even without the ASC.

Verified via Wiki research:
http://wiki.alioth.net/index.php/Pilot% ... ce_Compass

Edit: And apparently has been debated before too

I would argue that the behavior SHOULD be to change shape when within range of a station. You're doing no more than you already are by having the circle point to the station, but it would be more intuitive and easier for first time pilots (like my father who I finally have talked into playing and who brought this to my attention).

[Eric Walch]

Verified via Wiki research:
http://wiki.alioth.net/index.php/Pilot% ... ce_Compass

This has often been wrongly documented. And others writing reference sheets are copying those bugs. But by keeping copying wrong descriptions, it won't become true.
e.g. the current reference sheet had this also wrong in its preliminary drafts.

The only thing the code does without a space compass is switching destination from planet to station, but the icon itself never changes without the advanced compass.

[maik]

The only thing the code does without a space compass is switching destination from planet to station, but the icon itself never changes without the advanced compass.

This is also how I remember it from Elite. I corrected the Wiki.