selling a ship gives me 1 000 000 credits in oolite 1.71.2

krombart · Post by **krombart** » Sat May 24, 2008 7:24 pm

As the topic said. That happend as I sold cobra with jameson at lave with the
Realistic Ship Yards installed.

That happened without Realistic Ship Yards installed but with a lot other OXPs loaded.

Reported the bug to the berlios bug tracker.

Post by **Cmdr James** » Sat May 24, 2008 7:28 pm

I have seen something similar with the current Trunk version, where selling my Hamadryad to buy a Drake (I think it was a Drake) got me a huge lot of cash.

I think its probably an overflow thing, like the last time we saw this bug. I did start looking into it, but I got distracted by 32 and 64 bit floats, while looking to see if there was something funny going on in the type conversion.

Frame · Post by **Frame** » Sun May 25, 2008 9:04 am

Cmdr James wrote:
I think its probably an overflow thing, like the last time we saw this bug. I did start looking into it, but I got distracted by 32 and 64 bit floats, while looking to see if there was something funny going on in the type conversion.

just funny that an overflow would hit 1,000,000.00 precisely, I cant recall the largest value for an INT(even though i think this is system specific), while the credits prolly is a Double or Float.

krombart · Post by **krombart** » Sun May 25, 2008 9:07 am

Its not exactly 1 000 000 but its alway around this value sometimes 990k or even 1 006 k

Frame · Post by **Frame** » Sun May 25, 2008 9:17 am

krombart wrote:
Its not exactly 1 000 000 but its alway around this value sometimes 990k or even 1 006 k

oh clearification, love it.. then i retract my earlier comment...

Post by **another_commander** » Sun May 25, 2008 10:01 am

There seems to be an issue when Oolite tries to subtract the ship value credits from your total credits upon buying a ship. This occurs in the trunk version only. The calculation it does is

Code: Select all

credits -= 10 * (price - trade_in);

which is totally wrong. The trade_in value has been already multiplied by 10 before, so we end up overflowing. It should be

Code: Select all

credits -= 10 * price - trade_in;

The fix will go in the trunk in a few minutes.
Edit: I am unable to reproduce this in any way with 1.71.2. The equivalent part of the code for the 1.71.2 tree looks OK to me. I am beginning to suspect a possible issue with the Linux package. This is the second report of 1.71.2 behaving like the trunk version on Linux.

krombart · Post by **krombart** » Sun May 25, 2008 11:41 am

all of this happend in oolite 1.72

sorry for pretending it to be oolite 1.71.2 but I thought the autopackage

oolite-1.71.2.x86.package

would install oolite 1.71.2

JensAyton · Post by **JensAyton** » Sun May 25, 2008 12:55 pm

I’m not sure where that autopackage came from, but I’ll take the easy route and blame Winston. :-)