assigning a weapon to a weapon position by script

[dybal]

Ship Storage Helper assigns weapon string to the restored ship's weapon position:

Code: Select all

ship.forwardWeapon = storedShipArray[3];

If that weapon has a condition_script, the context that is passed to its allowAwardEquipment is "purchase" instead of "scripted"

[dybal]

Changing line 1865 of src/Core/Scripting/OOJSShip.m from

Code: Select all

            [entity setWeaponMount:facing toWeapon:sValue];

to

Code: Select all

            if (entity == PLAYER) {
                [entity setWeaponMount:facing toWeapon:sValue inContext:@"scripted"];
            } else {
                [entity setWeaponMount:facing toWeapon:sValue];
            }

solved it, but I don't know if that's the best solution, or changing the ship outfitting code in the core game to call setWeaponMount with the context "purchase" and changing the version of setWeaponMount without context (called from OJSShip.m) to default to context "scripted".

[dybal]

I have been using this fix for two weeks, so I created a Pull Request for it.