Vector 3D constructor accepting a sequence of vectors

[dybal]

I corrected a bug in an OXP yesterday that involved finding the final world-coordinates of a docking bay in a station.

The original code had something like this (I changed the variable names to make their roles clearer):

Code: Select all

Vector3D( _station.heading.direction().multiply( _subentity.position.z ), _station.vectorUp.direction().multiply( _subentity.position.y ), _station.vectorRight.direction().multiply( _subentity.position.x ) ) 

The trouble here is that:

_station.heading.direction().multiply( _subentity.position.z ) is a vector
_station.vectorUp.direction().multiply( _subentity.position.y ) is a vector
_station.vectorRight.direction().multiply( _subentity.position.x ) is a vector

So Vector3D constructor accepted a sequence of 3 vectors, which isn't a vector expression.

It should accept a sequence of operations over vectors (as each of the members of that sequence is), or a sequence of 3 scalars (which is what I think was what the bugged code was aiming at).

[cag]

I corrected a bug in an OXP
...
_station.heading.direction().multiply( _subentity.position.z ) is a vector
_station.vectorUp.direction().multiply( _subentity.position.y ) is a vector
_station.vectorRight.direction().multiply( _subentity.position.x ) is a vector

FYI, the .direction() calls are not necessary, as .heading, .vectorUp & .vectorRight are already unit vectors. Only matters if this code is in a Timer or a FrameCallback.

[dybal]

Thanks, cag!

Yes, it's in FB callback, I will adjust it (I agree with you, every little bit helps in high-freq code)