Quick check of roles for ship's OXP

[Rustem]

If you want find incorrect role in the ship's OXP quickly, then inputed in oolite console:

Code: Select all

var roles = Ship.roles();
for( var i = 0; i < roles.length; i++ ) {
 var roleKeys = Ship.keysForRole( roles[i] );
 log("roles", i + ". "+roles[i] + ": " + roleKeys );
}

Details can seen in the  Oolite JavaScript Reference wiki page (Static Methods).

I found in Latest.log file the next incorrect roles for in the my set of AddOns:

... [fighters-shark]: fighters-shark
...

... (0.04): RNRL_Stormbrewer-vigilante
...

... (0.05): classic_mussurana_hunter,classic_mussurana_pirate
...

... (0.07): RNRL_Stormbrewer-vigilante
...

... (0.3): classic_mussurana_hunter,RNRL_Stormbrewer-pirate
...

... griff_processor_subent: griff_1_pipe,griff_4_pipe

I think not should be number role. Errors is consist in space between the name roles and role weights this OXP's.

So, may fixed in shipdata.plist, roles string for OXP's: The Classic Mussurana, Stormbrewer.

[Smivs]

Hi Rustem,
Thanks for the heads-up on this. I had no idea I had spaces between the role and weight, and also had no idea that it was a problem!
It is now on my (rather long!) 'to do' list, so will be fixed when I can get round to this.

[Rustem]

It is now on my (rather long!) 'to do' list, so will be fixed when I can get round to this.

Hi, Smivs!

It is big 'to do' a deleting space .

Find space is difficult task .

I looking The GalCop MostWanted OXP code. There is use a role weights. Not sure exactly, but it seems that it affects the choice a ship for addition to GC MW list.

[phkb]

There is use a role weights. Not sure exactly, but it seems that it affects the choice a ship for addition to GC MW list.

I'm attempting to allocate ships with (kind of) the same frequency as the core code does it, so a rare ship doesn't get over-allocated. I use a similar method for Station Dock Control. I'm by no means sure I have the algorithm close to what the core code does, but it's workable.

[Smivs]

Hi, Smivs!

It is big 'to do' a deleting space .

Well, no, not in itself, but when taken in context (the number of updates I need to do!) it is. RL is crazy at the moment, but I hope to sort all of my backlog out within the next week or two.

[Cody]

RL is crazy at the moment

Fixed that for you!

[Smivs]

Ah, that explains it, then...