Some broken .plist files

[hoqllnq]

I just noticed that Oolite complains about being unable to parse some .plist files as property lists:

oolite.oxp.Commander_McLane.Anarchies.oxz/Config/shipdata.plist
oolite.oxp.Commander_McLane.Anarchies.oxz/Config/shipdata-overrides.plist
oolite.oxp.DrNil.Commies.oxz/Config/shipdata.plist
oolite.oxp.EricWalch.DeepSpaceDredger.oxz/Config/shipdata.plist
oolite.oxp.Pagroove.Superhub.oxz/Config/shipdata.plist
oolite.oxp.dertien.Z_GrOovY_SmallSystemStations.oxz/Config/shipdata-overrides.plist

Running Oolite 1.84 on MacOSX 10.10.5.
Using OXPs as served up by the manager at time of posting.


Looking into what causes the complaints, I found that they all had the same issue: missing semicolons at the end of some key/value-pairs. Adding those semicolons got rid of the errors.

Here are the fixed versions of those .plist files: http://www.jobiwan.net/XFP/repaired-plists/
It is only the modified files. (Also included the readme's that contain licenses, in case this is considered 'distribution of derivative work'.)

[phkb]

For some reason the Mac plist parser is a bit more finicky than the PC or Linux version, so it's sometimes hard for OXP devs to know when these errors have slipped in. Thanks for pointing them out, though. Good to get them fixed.

[Norby]

Thank you hoqllnq for fixing semicolon problems in Mac, I updated Anarchies and Commies.

In your DeepSpaceDredger folder I see a manifest.plist only, moreover the access is forbidden to this file.

For updating Superhub please contact Pagroove, for SmallSystemStations maybe dertien.

[hoqllnq]

In your DeepSpaceDredger folder I see a manifest.plist only, moreover the access is forbidden to this file.

It was a permissions thing. Thanks. Fixed now. chmod -R ugo+rX repaired-plists
I included the manifest for that one because it has no readme or license file, and the manifest includes a license entry.

For updating Superhub please contact Pagroove, for SmallSystemStations maybe dertien.

Done.

[Norby]

Thank you, DeepSpaceDredger is updated.

[pagroove]

In your DeepSpaceDredger folder I see a manifest.plist only, moreover the access is forbidden to this file.

It was a permissions thing. Thanks. Fixed now. chmod -R ugo+rX repaired-plists
I included the manifest for that one because it has no readme or license file, and the manifest includes a license entry.

For updating Superhub please contact Pagroove, for SmallSystemStations maybe dertien.

Done.

Thank you for fixing.
@ Norby. Could you update the Superb too as you are managing my OXZ in the manager?
Thanks you all

[Norby]

@ Norby. Could you update the Superb too as you are managing my OXZ in the manager?

In my account only a draft is exists, if I enable it then the previous version version still will be listed.

[phkb]

for SmallSystemStations maybe dertien.

Actually that one's with me. Now updated.

[spara]

I seem to be managing the current version of the SuperHub. Want to take it over, Norby? Just push a new one to the manager and I'll take down the old version.

[Norby]

Want to take it over, Norby? Just push a new one to the manager and I'll take down the old version.

Ok, new is up, please take down the old one.

Hoqllnq: could you check please if no more errors when you use the new versions from the manager?

[spara]

Want to take it over, Norby? Just push a new one to the manager and I'll take down the old version.

Ok, new is up, please take down the old one.

Thanks Norby, much appreciated.

[hoqllnq]

Hoqllnq: could you check please if no more errors when you use the new versions from the manager?

Looking good.
Updated all updatable OXPs in the manager. No more complaints on launch.
By the way, that was some very swift action from all of you.



I think I identified a different issue as well:

This is with ZygoUgo asteroids.
The two asteroids OXPs (shady & noshaders) both depend on the Asteroids-resources OXP.
The issue is with the version numbers.
In the manifest files, the versions have a letter 'v' in front of them: "v1.2.8",
but in the dependencies, they state versions without the 'v' in them: "1.2.7".


Resources OXP version is "v1.2.8":

Code: Select all

{
	"identifier" = "oolite.oxp.ZygoUgo.Asteroids_resources";
	"title" = "ZygoUgo's Asteroids resources";
	"version" = "v1.2.8";
	...

Shady OXP depends on "1.2.7" without the 'v'.

Code: Select all

{
	"identifier" = "oolite.oxp.ZygoUgo.shadyAsteroids";
	"title" = "ZygoUgo's Asteroids - shady";
	"version" = "v1.2.7";
	...
	...
	"requires_oxps" = (
		{
			"identifier" = "oolite.oxp.ZygoUgo.Asteroids_resources";
			"version" = "1.2.7";
			"description" = "needs ZygoUgo Asteroid resources 1.2.7 or above";
		}
	);
}

The result is that the manager complains about 'unmet requirement', and tells me I need to resolve this manually.
All ZygoUgo OXPs have a 'v' in front of their version, except for "Zygo Cinematic Sky & Nebulas", which is "1.3".

Should I notify ZygoUgo / Amah, or have these also been adopted by a new maintainer?

[Norby]

Should I notify ZygoUgo / Amah

Imho yes. The "v" should not be in the version, all other authors use numbers and dots only.

Note you can check all manifests in one file in ~/GNUstep/Library/Caches/org.aegidian.oolite/Oolite-manifests.plist , this is where the game save them when you update the list. Alhough it should be exactly the same as the content of manifest.plist files in oxzs, it can be different due to mistake.

For example when you try to install a new package then you see the description from the big list which come from the central database, but when you try to remove a package, that list is generated directly from your installed oxzs. Differences are possible if the author mistyped something, like "Ambiences" instead of "Ambience" etc. Please report if you see one.

[hoqllnq]

I made a plist parser and serialiser.

You can upload a plist file (the openstep kind; does not work for xml) and it will parse it and serialise it back out. The parser is very forgiving and a bit stupid. It is not a validator and to some extent it is garbage-in, garbage-out. I tested it on the files mentioned in post #1 and it works for those.

[hoqllnq]

Should I notify ZygoUgo / Amah

Imho yes.

ZygoUgo replied to me.
Says he no longer really looks after these OXPs and that we are free to do with them as we will. (And glad to see Oolite is still going strong. )

Any takers?