Possible bug with AI logic for destinationSystem (Resolved)

[phkb]

This is a possible bug in Oolite 1.80. (I haven't had time to test in 1.81 yet).

I'm in Raleor (G5, planet ID 50). Nearby systems are Anleis (ID 0) and Tiqu (ID 202).

If I launch from a station and run this code:

Code: Select all

	var ships = system.addShips("[cobra3-trader]", 1, p.position.add(p.vectorForward.multiply(10000)), 1000);
	ships[0].fuel = 7;
	ships[0].setCargoType("PLENTIFUL_GOODS");
	ships[0].homeSystem = system.ID;
	ships[0].destinationSystem = 202;

I see a Cobra Mark 3 appear in front of me, and then take off and zip through a worm hole.

But if I launch and run this code:

Code: Select all

	var ships = system.addShips("[cobra3-trader]", 1, p.position.add(p.vectorForward.multiply(10000)), 1000);
	ships[0].fuel = 7;
	ships[0].setCargoType("PLENTIFUL_GOODS");
	ships[0].homeSystem = system.ID;
	ships[0].destinationSystem = 0;

The Cobra turns around and heads back into the station.

Note that in both these cases the Cobra is created a short distance from the main station. I don't know if that plays a big part or not.

I suspect (and I'm not sure) that the AI logic that's working out whether to jump to witchspace is doing a check of the destinationSystem and if it's greater than zero then it will do the jump. But I think the check should be greater than or equal to zero.

Have I done something wrong here? The code seems pretty straightforward. Does anyone else see this on their systems?

[Smivs]

Maybe the pilot heard that Anleis is "...plagued by a lethal disease." and decided it was best to cancel the trip!

[cim]

Thanks. Should be fixed in tonight's build.

[phkb]

There was a bug? Oh, that's a relief! I thought I was going crazy. I was almost to the point of using strong language to get the ships to jump out!

[phkb]

I just tested in 1.82 (latest build) but it appears the bug is still present. I also tested launching ships from a station and it appears to impact those ships as well. Any ship that has "0" (zero) set as their destination system will just go back to the main station either when created directly or launched from a station. At least, on my PC it does...

[cim]

Thanks. I've fixed a few more issues around this for tonight's build.

[phkb]

Tested, and confirmed - it's working!