Is this a bug?

[phkb]

Having a look at "oolite-populator.js" as I code up my docking info OXP, but came across this:
When a trader-courier or trader-smuggler is created, it runs the this._nearbySystem function to determine what the home system and destination system will be for the ship. It passes a "range" parameter to this function, but "range" is never used in the function. So, regardless of whether "7" or "25" is passed to the function (at lines 1435, 1441, 1457, 1464, 1466, 1493, 1498) it will only ever return a system ID that is in range, as the $populatorLocals variable is always set to system.info.systemsInRange();
Is my logic correct here?

I think the _nearbySystem function should actually look like this:

Code: Select all

this._nearbySystem = function(range)
{
	if (range != 7)
	{
		var poss = system.info.systemsInRange(range);
	} 
	else 
	{
		var poss = this.$populatorLocals;
	}
	if (poss.length == 0)
	{
		return system.ID;
	}
	return poss[Math.floor(Math.random()*poss.length)].systemID;
}

[phkb]

Another in the "Is this a bug" items...

Again, in the oolite-populator.js file, in the this._addIndependendPirate function, there is this code:

Code: Select all

		if (!pos.isStation && !pos.isPlanet)
		{
			pg.ships[i].setCargoType("PIRATE_GOODS");
			<snip>
		}

And in the this._addPiratePack function, there is this code:

Code: Select all

	if (!pos.isStation && !pos.isPlanet)
	{
		lead[0].setCargoType("PIRATE_GOODS");
	}

My reading of this is that if the position where the pirates are being created is not at a station and not at a planet, then give this ship some "PIRATE_GOODS". The trouble is, there is no case for when the pirate is launching from a station. In that case, they don't seem to get any goods. Is that correct? A pirate group launching from a station will leave with nothing in the hold?

[cim]

The first one is a bug - and you're right about the fix too. I'll add it in.

The second one is intentional - pirates added in deep space are either doing their job or returning from a raid to another system. They may therefore have cargo on board from their victims. Pirates launching from their base - planet or station - will have empty holds so that they can grab the maximum amount of cargo on this trip.

[UK_Eliter]

pirates added in deep space [. . .]

I may not be paying enough attention, but, if Oolite itself now adds deep space pirates, should I uninstall the Deep Space Pirates OXP (wonderful though it is or at least was)?

[cim]

adds deep space pirates

Sorry - by this I meant "pirates added a long way from a station or planet" - they're all still added on or near the lanes, so you still need that OXP to cover other locations.