sunskim-traders as pirate victims

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

sunskim-traders as pirate victims

Post by Commander McLane »

I just noticed that "sunskim-trader" is lacking as a role in Oolite's pirate-victim-roles.plist. The plist covers some OXP roles, and sunskimmers is another classic OXP, so I feel the role should be added. As it is now, all additional sunskimmers will not be attacked by pirates, which somehow defeats the purpose of sunskimmers.oxp.

A case of a new Oolite version accidentally breaking an OXP. (Although it's by no means new; the plist was added many versions ago.)
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: sunskim-traders as pirate victims

Post by JensAyton »

Commander McLane wrote:
A case of a new Oolite version accidentally breaking an OXP.
Er, no. Prior to test release 1.70, only plain traders were considered pirate victims.
User avatar
Commander McLane
---- E L I T E ----
---- E L I T E ----
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: sunskim-traders as pirate victims

Post by Commander McLane »

Ahruman wrote:
Commander McLane wrote:
A case of a new Oolite version accidentally breaking an OXP.
Er, no. Prior to test release 1.70, only plain traders were considered pirate victims.
Ah, you're right. Expanding this was what the pirate victim roles were for in the first place. :oops:

So, any reservations against the addition (I think it was an oversight at the time, as sunskimmers.oxp predates 1.70)?
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: sunskim-traders as pirate victims

Post by JensAyton »

It’s already done. :-)
Post Reply