Oolite Bulletins

Lestradae wrote:

1) Would you mind letting me know the changes you made to the caduceus autorepair (the missing function in timer replaced)?

And could you inform ClymAngus and Cmdr Wyvern of your findings and ask them if they might want to update their oxp(s) accordingly?

Screet wrote:

it looks like something still has evaded previous fixings...at line 165 the autorepair-script tries to install a timer for this.repairNode which does not exist. I think it was meant to call this.repairShip - is this correct?

Lestradae wrote:

2) Are you sure that that Behemoth did try to dock? I have seen such giants sometimes accidentally ram something while in battle, with cataclysmic results, usually. Perhaps it didn't want to dock at all? Goes without saying it's AI shouldn't / doesn't tell it to anyways normally ...

matthewfarmery wrote:

I was in Ritila, heading past the planet, after which it crashed, I was doing nothing special, I was in a dog fight a previous jump back and that was ok, so not sure why it crashed, anymore info please ask, not sure what else to tell you?

// Ships that are added to the system, and to interstellar space
this.setUpGlobalShips = function()
{
 //       this.addNavyPatrolShips();
 //       this.addMissionaryShips();
 //       this.addDredgerShip();
        this.addHardPirateShips();
 //       this.pimpMySystem();
}

// Ships to be added to the system
this.setUpSystemShips = function()
{
//        this.addOoBayShips();
        this.addInraPatrolShips();
 //       this.addNavyPatrolShips();
        this.addSIRFYardStation();
//        this.addFrogRickshawShip();
//        this.addMissionaryShips();
//        this.addClipperShip();
//        this.addDredgerShip();
//        this.addExecutiveFlightShips();
//        this.addSalezaShips();
//        this.addSuperCobraShips();
//        this.addIxianShips();
        this.addHardPirateShips();
        this.addFreeTradeZone();
        this.addPirateCove();
//        this.pimpMySystem();
}

// add global and system ships
this.setUpShips = function () {
       if (system.isInterstellarSpace) {
			this.setUpGlobalShips();
            return;
        }
        this.setUpSystemShips();
};

Screet wrote:

Code: Select all

// Ships that are added to the system, and to interstellar space
this.setUpGlobalShips = function()
{
    ...
}

// Ships to be added to the system
this.setUpSystemShips = function()

    ...
}

// add global and system ships
this.setUpShips = function () {
       if (system.isInterstellarSpace) {
			this.setUpGlobalShips();
            return;
        }
        this.setUpSystemShips();
};

pmw57 wrote:

// add global and system ships
this.setUpShips = function () {
if (system.isInterstellarSpace) {
this.setUpGlobalShips();
return;
}
this.setUpSystemShips();
};

Someone has added a return statement to the setUpShips method, resulting in an incorrect comment for the global ships section.

// add global and system ships
this.setUpShips = function () {
        this.setUpGlobalShips();
        if (system.isInterstellarSpace) {
                return;
        }
        this.setUpSystemShips();
};

Lestradae wrote:

Screet & pmw57, could you two compare the script versions you are testing, with each other, again, please? The above differences have made me a tad paranoid

Hope to find out about the difference

Lestradae wrote:

Could you two both post a link to the OSE-populator.js, please, so that I can compare versions?

I'd have a look and come back with questions.



L

Lestradae wrote:

The scripts were only worked on by Screet & pmw57 - which should I use as the "definite" version now? Or where does the difference come from?

Screet wrote:

Use those of pmw57. What I did write is only for people experiencing crashes with that so that they either can run it crash-free or help to find out where the crash comes from by re-enabling one of the outcommented lines after another until the crashes are back.

Lestradae wrote:

Thanks, guys

// Ships to be added to interstellar space
this.setupInterstellarShips = function()
{
	this.addNavyPatrolShips();
	this.addMissionaryShips();
	this.addDredgerShip();
	this.addHardPirateShips();
	this.pimpMySystem();
}

// Ships to be added to the system
this.setupSystemShips = function()
{
	this.addOoBayShips();
	this.addInraPatrolShips();
	this.addSIRFYardStation();
	this.addFrogRickshawShip();
	this.addMissionaryShips();
	this.addClipperShip();
	this.addDredgerShip();
	this.addExecutiveFlightShips();
	this.addSalezaShips();
	this.addSuperCobraShips();
	this.addIxianShips();
	this.addHardPirateShips();
	this.addFreeTradeZone();
	this.addPirateCove();
	this.pimpMySystem();
}

// add interstellar or system ships
this.setUpShips = function () {
	if (system.isInterstellarSpace) {
		this.setupInterstellarShips();
	} else {
		this.setupSystemShips();
	}
};