Oolite Bulletins

4) Out of the "station bought" screen, on your "missions" screen now a line should appear saying "You own an X station in system Y in galactic sector Z. Income per WJ: AAAAA Cr"

That doesn't work. It does in the XML version. The script new simply doesn't do this. As I don't understand java script well enough to repair it, no idea why not.

...

6) If you do a witchjump, the amount of credits it said in the equipment screen and says on your missions screen should be transferred to your account at arrival. (If you own multiple stations, the sum total of all their incomes should arrive) You will not get additional screen messages or somesuch. Your credits will simply rise the amount.

The new script doesn't do that. Also, your legal status should get raised or lowered for some stations. The script also doesn't do that.

<key>Stations_owned_show_HAH</key>
        <array>
        <dict>

        <key>conditions</key>
        <array>
              <string>mission_playerstation_HAH equal 1</string>
        </array>

        <key>do</key>
        <array>
              <string>setMissionDescription: Station_HAH_owned</string>
        </array>

        </dict>
        <dict>

        <key>conditions</key>
        <array>
              <string>mission_playerstation_HAH undefined</string>
        </array>

        <key>do</key>
        <array>
              <string>clearMissionDescription</string>
        </array>

        </dict>
        </array>

<key>Stations_owned_income_HAH</key>

        <array>
        <dict>

        <key>conditions</key>
        <array>
              <string>status_string equal STATUS_EXITING_WITCHSPACE</string>
              <string>mission_playerstation_HAH equal 1</string>
        </array>

        <key>do</key>
                  <array>
                     <string>awardCredits: 75000</string>
                  </array>

        </dict>
        </array>

<key>Stations_owned_legal_HAH</key>

        <array>
        <dict>

        <key>conditions</key>
        <array>
              <string>status_string equal STATUS_EXITING_WITCHSPACE</string>
              <string>mission_playerstation_HAH equal 1</string>
              <string>legalStatus_number lessthan 70</string>
        </array>

        <key>do</key>
                  <array>
                     <string>setLegalStatus: 600</string>
                  </array>

        </dict>
        </array>

A & B: Do nothing

C: Raise player bounty 5 points per jump if (see McLane's post) * the jump actually arrives in another system and not interstellar space

D: Raise player bounty 20 points per jump * (-> see above)

E: Lower player bounty 3 points per jump *

F: Raise player bounty 40 points per jump *

G: Lower player bounty 6 points per jump *

H: Raise player bounty 70 points per jump *

I: Do nothing

J: Lower player bounty 12 points per jump *

K & L: Lower player bounty 6 points per jump *

this.processOwnedStations = function () {
        var leftChars = 'ABCDEFGHIJKL',
                midChars = 'AB',
                rightChars = 'ABCDEFGH',
                stationIncome = {
                        'A': 4000, 'B': 8000, 'C': 12000, 'D': 21000, 'E': 20000, 'F': 36000,
                        'G': 40000, 'H': 75000, 'I': 100000, 'J': 130000, 'K': 250000, 'L': 500000
                },
                stationBounty = {
                        'A': 0, 'B': 0, 'C': 5, 'D': 20, 'E': -3, 'F': 40,
                        'G': -6, 'H': 70, 'I': 0, 'J': -12, 'K': -6, 'L': -6
                },
                i, j, k,
                playerStation,
                income,
                bounty,
                totalBounty = 0;
        for (i = 0; i < leftChars.length; i++) {
                for (j = 0; j < midChars.length; j++) {
                        for (k = 0; k < rightChars.length; k++) {
                                playerStation = leftChars.charAt(i) + midChars.charAt(j) + rightChars.charAt(k);
                                income = stationIncome[leftChars[i]];
                                bounty = stationBounty[leftChars[i]];
                                if (missionVariables['playerstation_' + playerStation] == 1) {
                                        player.credits += income;
                                        totalBounty += bounty;
                                }
                        }
                }
        }
        if (player.bounty + totalBounty < 0) {
                player.bounty = 0;
        } else {
                player.bounty += bounty;
        }
};
this.showOwnedStation = function (station) {
        var leftChars = 'ABCDEFGHIJKL',
                midChars = 'AB',
                rightChars = 'ABCDEFGH',
                i, j, k,
                playerStation;
        for (i = 0; i < leftChars.length; i++) {
                for (j = 0; j < midChars.length; j++) {
                        for (k = 0; k < rightChars.length; k++) {
                                playerStation = leftChars.charAt(i) + midChars.charAt(j) + rightChars.charAt(k);
                                if (missionVariables['playerstation_' + playerStation] == 1) {
                                        mission.runMissionScreen('Station_' + playerStation + '_owned');
                                }
                        }
                }
        }
};

Kaks wrote:

From the code he's produced already I'd say he is the 'capable help to solve this' you're saying you're looking for...

Lestradae wrote:

Btw, as pmw57 has just also translated about fifteen ship oxps' (and also the hoopy casino oxps') from XML to .js, perhaps it could be a good idea to update these oxps with the new .js version, too? Then players of the original oxps could also enjoy the resulting speed gain!

I only know that the current Hoopy version had already a much improved xml script compared with the original. Some months ago there were reported bugs in hoopy here and I uploaded a new version. Just a pity that the translation is now based on the one with the bug and still contains the bug. The main problem is that when a player launches from within a gamescreen, he is denied access in future. The current version is not only free from this bug but also fixes saved games that contain a wrong entry.

One other thing that happens when translating to JS is that the timing is completely different. The legacy scripting makes sure that scripts are not run on an arrival_report. With JS one need to check in the script for this condition. You now loose all messages on captured escape capsules. Not the most important stuff and good enough for ose probably. But the original should be as flawless as possible when changing. And certainly not be worse than original.

pmw57 just is unaware of some specific Oolite rules.

e.g. when defining a mission description it is saved with the name of the script. When putting all in one script, there can only be one mission description. ... One other problem with the old and new script is that is in totally incompatible with mission oxp's. It refuges to check for existing mission screens but just overwrites them. I already wrote pmw57 that this is not a problem itself but the readme should clearly warn to not use ose.oxp in combination with mission oxp's.

And 6 oxp's of the OSE-XML.plist use already a JS script in their current version.

Screet wrote:

About the playerstations:
1) The code does check for the playerstation key to be INTEGER 1, while it is as STRING 1 in the save file. The if clauses to find the stations need to check for "1" instead of 1
2) The code that does create the string for the f5 mission screen does not activate after loading, only after docking, and then it shows a mission screen for the stations (including "press space") instead of adding the ship to the f5 mission screen.

Lestradae wrote:

@Screet:

Screet wrote:

About the playerstations:
1) The code does check for the playerstation key to be INTEGER 1, while it is as STRING 1 in the save file. The if clauses to find the stations need to check for "1" instead of 1
2) The code that does create the string for the f5 mission screen does not activate after loading, only after docking, and then it shows a mission screen for the stations (including "press space") instead of adding the ship to the f5 mission screen.

Screet, do you think you could provide a fix for the abovementioned two errors?

I assume that if your newer hoopy version is much improved,

Can you point me to which parts of the translated scripts could produce such lost messages?

Again, I would ask you to point me to the oxps for which this is the case. Because then I can & will update them to current standards.

Lestradae wrote:

@Screet:
Your explanation is enough so that I might even attempt to repair the player stations part of the java script. If I don't manage, I'd have to let this part stay as it is - in XML