About planets

[DaddyHoggy]

Cool planet - was wondering why there's a desert around the large lake - surely there'd be some greenery around its edges?

[Star Gazer]

...unless it were a 'salt' lake?

[submersible]

Kaks was working on having planets use the same / similar rendering code as ships, and so would have all the same support / features that ships do.... Normal Maps, shaders, etc...

Has there been any recent movement on shaders for planets ? I'm looking at the source and it would seem not yet. I am interested in both planet surface and the atmosphere surrounding it.

[Kaks]

First, a disclaimer: Ahruman did write the majority of the 'new planets' code. Admittedly I did do some extensive tinkering to that code, though!

Anyway, we did shelve the project about 2/3 of the way in, in order to get on with all the other features that did find their way onto 1.76 (& 1.75 - & 1.74 too, iirc!).

There are already vague plans to complete the new planets stuff, but we devs seem to be collectively hampered by too much RL at the moment...

[submersible]

First, a disclaimer: Ahruman did write the majority of the 'new planets' code. Admittedly I did do some extensive tinkering to that code, though!

Anyway, we did shelve the project about 2/3 of the way in, in order to get on with all the other features that did find their way onto 1.76 (& 1.75 - & 1.74 too, iirc!).

There are already vague plans to complete the new planets stuff, but we devs seem to be collectively hampered by too much RL at the moment...

Is new planets in git hub or somewhere I can take a look. I'm not a wizard with C or objective C , however I do have a colleague that provides me much useful advice about such things . Looking at the existing PlanetEntity/PlanetDrawable on trunk - I might just be able to make sense of it.

[another_commander]

submersible: The new planets code is already in the current source, guarded by the NEW_PLANETS macro, currently set to 0.

[Eric Walch]

submersible: The new planets code is already in the current source, guarded by the NEW_PLANETS macro, currently set to 0.

I tried to activate it last week. But, currently it creates syntax errors when set to 1

[submersible]

submersible: The new planets code is already in the current source, guarded by the NEW_PLANETS macro, currently set to 0.

I tried to activate it last week. But, currently it creates syntax errors when set to 1

Code: Select all

src/Core/OOPlanetData.h 
src/Core/OOPlanetData.c

are both empty. Perhaps this is the beginning of the last 1/3 ?

[Kaks]

Hmm, the last time I looked at it that part of the code was compiling OK.

Seems one of us did more - yep, unfinished - work on it!

[submersible]

Hmm, the last time I looked at it that part of the code was compiling OK.

Seems one of us did more - yep, unfinished - work on it!

Code: Select all

------------------------------------------------------------------------
r4203 | ahruman | 2011-01-31 18:37:51 +1100 (Mon, 31 Jan 2011) | 1 line

Blanked currently-unused OOPlanetData files (see bug #5254).
[code]

This was removed last year.
For the life of me - I cannot find this bug. Could it be a typo in the commit message?

[another_commander]

You can retrieve the two blanked files either by donwloading them from an SVN revision earlier than 4203 or by generating them locally. The project responsible for creating these two files is icosmesh, located inside trunk/tools.

[Kaks]

Hmm, however I believe those two files don't really affect OOPlanetTextureGenerator as is. However, quite a number of weird and wonderful texture code changes have been committed to trunk in the last year and a half, and our new_planets texture generator is no longer compatible with its underlying class. I'll defer to Ahruman, who implemented those changes in the aforementioned underlying class!

If Jens hasn't got round to it by the weekend, I'll have a go to at least get it to compile properly with NEW_PLANETS set to 1.

Cheers,

Kaks.

[Eric Walch]

Hmm, the last time I looked at it that part of the code was compiling OK.
....
Hmm, however I believe those two files don't really affect OOPlanetTextureGenerator as is. However, quite a number of weird and wonderful texture code changes have been committed to trunk in the last year and a half, and our new_planets texture generator is no longer compatible with its underlying class.

Last time? I tried with 1.74 maintenance. There already I had compile errors with NEW_PLANETS = 1. Unless I set it to 1 on the wrong place. It must be set to 1 in 'OOStellarBody.h' or not?
Anyhow, back than, the generated planets already looked amazing.

[another_commander]

Eric: Yup, that's the right place to activate the macro.

[Kaks]

Well, I couldn't resist the challenge, and I did get the code to compile with NEW_PLANETS set to 1.
Still, though the seas are better than I remembered (Ahruman did some extra work on the seas which I didn't notice at the time), all the NEW_PLANETS land portion is very much featureless now, so we can't see the 3D mountain ranges anymore...

I'll look some more into the matter, hopefully I'll figure out what happened between then (2 years - & change - ago) and now.

PS: Yes, bug #5254 seems to be a typo, can't quite figure out what bug Ahruman was referring to.

PPS: The NEW_PLANETS stuff now compiles in rev4805, so if you really, really want to you can start playing with that code now!