Page 9 of 12

Posted: Sat May 17, 2008 6:01 pm
by goran
Just a quick note:

PAGroove_Stations_v1.1.oxp doesn't work on 1.72 testreleases. OK on 1.71.2.

Posted: Sun May 18, 2008 2:19 am
by pagroove
Ok, I'il test it. I will report back

Posted: Sun May 18, 2008 2:38 pm
by pagroove
Just playing it on a testrelease. But we have a new version. Didn't took the time to release it yet. Can you say which version you have exactly?

Posted: Sun May 18, 2008 7:22 pm
by goran
Oolite 1.72 revision 1640 (from repository). It works ok with 1.71.2.

Posted: Thu May 22, 2008 8:12 pm
by pagroove
At last Griff and P.A. Groove present:

PAGroove_Stations_v1.2.1.oxp

This is te latest upgrade to our OXP:

Downloadable at the Wiki
http://wiki.alioth.net/index.php/P.A._G ... ations_OXP

I also added some (basic) extra info on the Dodo and ICO station WIKI pages here:

Dodo info:
http://wiki.alioth.net/index.php/Dodo_s ... 8Oolite%29
ICO info
http://wiki.alioth.net/index.php/Ico_station

Posted: Thu May 22, 2008 8:31 pm
by pagroove
Bear in mind that it has only been tested on the stable releases

Posted: Fri May 23, 2008 7:01 am
by Commander McLane
pagroove wrote:
Bear in mind that it has only been tested on the stable releases
:?: :?: :?:

I am sure you mean "test releases" up to 1.71.2 (as opposed to the trunk that is currently being worked upon and therefore doesn't yet bear any release number)? The only stable release currently available is 1.65! Everything after that is explicitely not stable.

Anyway: Thanks! :D

Posted: Fri May 23, 2008 8:14 pm
by pagroove
Hi Commander McLane,

Yes that's exactly what I mean. It was because I haven't trief it on 1.72 yet.

:D

Posted: Sat May 24, 2008 6:50 am
by goran
Not working on 1.7.2. Still the same: initialising universe -> hud and crosshairs on screen -> crash to desktop.

Posted: Sat May 24, 2008 6:55 am
by Gareth3377
Nice stations. The red one is certainly a shocker on the eye! Keep up the good work!

Posted: Sat May 24, 2008 8:23 am
by Commander McLane
pagroove wrote:
Hi Commander McLane,

Yes that's exactly what I mean. It was because I haven't trief it on 1.72 yet.

:D
Well, what I mean is that there is no such thing as "1.72". So it is best not to confuse people by talking about it, as if it existed. It doesn't.

And 1.71.2, 1.71.1, 1.71, 1.70, etc. etc., back to 1.66 are all not stable releases, but development releases.

Posted: Sat May 24, 2008 9:13 am
by Griff
I'm not able to build the cutting edge (trunk?) version so i can't test the oxp with it, hopefully it's just something broken in that build of oolite that will get fixed by the time it's released as a test on GURPO.

Posted: Sat May 24, 2008 10:03 am
by JensAyton
Using my l33t power of reading the log – people really should try it sometime – I see:
[shipData.load.error]: ***** ERROR: the shipdata.plist entry "PAGroove-icosahedron-reference" specifies no roles, ignoring.
[shipData.load.error]: ***** ERROR: the shipdata.plist entry "PAGroove-coriolis-reference" specifies no roles, ignoring.
[shipData.load.error]: ***** ERROR: the shipdata.plist entry "PAGroove-dodecahedron-reference" specifies no roles, ignoring.
[shipData.merge.failed]: ***** ERROR: one or more shipdata.plist entries have like_ship references that cannot be resolved: {(
"PAGroove_Redtec_coriolis",
"PAGroove_dodo_Trontechvulcan",
"PAGroove_ICO_Constelation",
"PAGroove_ICO_Frontierworldsranger1",
"PAGroove_Metaforce_coriolis",
"PAGroove_dodo_Axtech",
"PAGroove_dodo_lx5",
"PAGroove_Ra_TechGold_coriolis",
"PAGroove_Waspline_coriolis",
"PAGroove_Solartec_coriolis",
"Griff_ICO",
"PAGroove_ICO_Worldbuildersx1l",
"PAGroove_dodo_GASECBlue",
"PAGroove_Greenline_coriolis"
)}

[ship.setUp.like_ship]: ***** Error: like_ship found in ship dictionary in -[ShipEntity setUpShipFromDictionary:], when it should have been resolved already. This is an internal error, please report it.
[shipEntity.notDict]: Ship <StationEntity 0xc96200>{"(null)" "(null)" ID: 0 position: (-49515.3, 60769.4, 427622) scanClass: CLASS_STATION status: STATUS_ACTIVE} was not set up from dictionary.
The second last one is a bug in the new ship set-up code. The last is a side-effect of that bug, which is probably the direct cause of the crash. The other messages are caused by… interesting… design decisions in the OXP: a base ship with no roles is used as a template for concrete ships which do have roles.

I’m not sure how to proceed here. The easiest way would be to declare the OXP buggy; it could be fixed by adding an otherwise unused role (such as “PAGroove-station-template”) to the templates. Another way would be to put the loader phase that rejects ships with no roles after the like_ships resolution phase. This would still result in error messages, though, unless an extra clunky thing was added to track which ships had been used in like_ships references and suppressing messages for those.

Fortunately for me, I don’t have to decide now since I won’t be home for the rest of the weekend.

Posted: Sat May 24, 2008 10:08 am
by Commander McLane
I think, as the wiki already somewhere declares the roles-key as a necessary key for all entities, the indeed easiest way would be to give the template-entries dummy-roles. They wouldn't actually be used in a script, but they would have to be there.

Posted: Sat May 24, 2008 10:17 am
by pagroove
Ok, But we (Griff and I ) are not that good in scripting. Can someone make a fix for the 1.72 and up in return of eternal fame (mentioned in the readme and on the WIKI) 8) :D ???