That stray 'true' was in the wrong place and the verifier flagged it up...
Wait, I possibly see what you mean: in objective-c YES & true are the same thing, and it's a bit confusing seeing YES instead of true. Hmmm, while I can't think of a quick or easy way to get the verifier to distinguish between the two, maybe someone else can!
Well, I have one possible approach.
First, check the whole file as a string and verify its structure using various rules.
That's what I did with my tool. It checks if there are strings, inegers and such where they should be. (I might finish it soon.. just need some coffee)
Not to many "<true/>", as it belonged to the missing one with: "smooth". It was just misplaced. I assume because something was pasted in between.
For your info: I just updated the bandersnatch this week. I corrected this bug and also renamed some files as the key "wing" is likely to conflict with any other oxp that uses that same key name.
ps. when quoting code you better use "code" "/code" for enclosing. That way quoted code is often better readable.
Last edited by Eric Walch on Wed Nov 11, 2009 10:51 pm, edited 1 time in total.
The root problem here is that Oolite 1.73 and earlier (back to about 1.62) accept malformed XML property lists.
If you look a bit further up in the log, you should see a message about the file being syntactically invalid and the “homebrew plist parser” being used. This won’t happen in trunk, since the homebrew parser has been removed.
Not to many "<true/>", as it belonged to the missing one with: "smooth". It was just misplaced. I assume because something was pasted in between.
Actually, I moved the "smooth" beneath the "model", (after I added "true"). My mistake was adding one too many "true". (one was missing.. not two)
Eric Walch wrote:
For your info: I just updated the bandersnatch this week. I corrected this bug and also renamed some files as the key "wing" is likely to conflict with any other oxp that uses that same key name..
I've already downloaded it. It was a while since I last updated my installed OXPs, but that is not the issue here.
I was testing my tool that batch-verifies the oxps, and I came across missing "true" that made verifier hmm "confused". Afterwards I added 2 "true"s and this happened.
Eric Walch wrote:
ps. when quoting code you better use "code" "/code" for enclosing. That way quoted code is often better readable.
Seems like verifier disregards "like_ship" keys and reports errors where there are none. (e.g. "Required keys (model, roles) missing from dictionary")
Also, says that "is_template" is an unknown key.
Correction:
Both 1.73.4 and trunk report "is_template" as unknown, while only trunk ignores "like_ship" keys.
Last edited by Chaky on Thu Nov 12, 2009 12:09 am, edited 1 time in total.
