Moderators: winston, another_commander, Getafix
Code: Select all
this.playerWillExitSystem = function () {
if (this.cloakingTimer) {
this.cloakingTimer.stop();
delete this.cloakingTimer;
}
};Code: Select all
this.startTimer = function (timerName) {
var timerSettings;
if (this[timerName]) {
this[timerName].start();
return this[timerName];
} else if (this.timerSettings[timerName]) {
timerSettings = this.timerSettings[timerName];
return new Timer(this, timerSettings.func, timerSettings.delay, timerSettings.interval);
}
return null;
};
this.stopTimer = function (timerName) {
if (this[timerName]) {
this[timerName].stop();
delete this[timerName];
}
};
Code: Select all
this.timerSettings = {
'damageControlTimer': {func: this.repairShip, delay: 60, interval: 300}
};Code: Select all
this.shipExitedWitchspace = this.shipLaunchedFromStation = function () {
if (player.ship.hasEquipment("EQ_DCN")) {
this.damageControlTimer = this.startTimer('damageControlTimer');
}
};Code: Select all
this.playerWillExitSystem = function () {
this.stopTimer('damageControlTimer');
this.stopTimer'(damageNodeTimer');
};The current release version of Fuel station and fuel satellite scripts (and presumably PlayerFuelStation_station, although I didn't write that) already tidy up after themselves when the player leaves the system, hence should be no risk for crashes.pmw57 wrote:While updating OSE we found several NPC ship scripts that use timers, and inadvertantly crash the game due to the timer still going after the NPC ship has died.
The scripts that are involved with this are:
This thread is to keep track of information related to these NPC timer scripts.
Code: Select all
this.playerWillEnterWitchspace = this.playerGone = function()
{
if(this.scanTimer)
{
this.scanTimer.stop();
delete this.scanTimer;
}
}
.My apologies for tarring you with that brush. I shall narrow the scope by saying only "some of which" instead.Thargoid wrote:The current release version of Fuel station and fuel satellite scripts (and presumably PlayerFuelStation_station, although I didn't write that) already tidy up after themselves when the player leaves the system, hence should be no risk for crashes.
Please show me your proof that their script timers are crashing the game.
.I'm coming not from an engineering background, but a programming background. Code needs to change. Why? How much code is good enough to stay around for decades without change? Virtually none of it. Code that doesn't improve becomes buggy, and broken.Thargoid wrote:Just apply the engineering addage - if it isn't broken, don't fix it. Unless you want to risk starting to upset people.
.
No, look at the wiki page about handlers.pmw57 wrote:By the way, do you think that playerWillExitSystem should be used instead of playerWillEnterWitchspace, as advised by Commander McLane?
You know T, I am a bit surprised. Please read your above statements after counting to ten, and then perhaps once or twice again after counting to ten. How do they feel?Thargoid wrote:... you're coming across via the cold medium of the internet as rather arrogant at the moment. It doesn't exactly inspire a desire to collaborate. ... At the moment all of this is rapidly escalating the option of removing support and goodwill towards the OSE project, at least from me.
The wiki page about handlers seems to be light on the topic.Eric Walch wrote:No, look at the wiki page about handlers.pmw57 wrote:By the way, do you think that playerWillExitSystem should be used instead of playerWillEnterWitchspace, as advised by Commander McLane?
