Did you ever wish for just a little more space in your hold?

pmw57 · Post by **pmw57** » Fri Oct 09, 2009 11:56 am

Kaks wrote:
Ok, unless there are any objections, I'm going to make the following changes to add / remove equipment:

Adding the large cargo bay via script will add extra space, and removing it via script will remove the extra cargo space, as defined by the ships extra cargo space overrides. Same thing will happen with passengers berths added / removed via script.

However, if the present cargo can't fit inside the changed cargo bay space, no changes will be made, add / remove equipment will return false, and a message will be added to the log.

What do you guys think?

I'm all for this.

Post by **Eric Walch** » Fri Oct 09, 2009 11:58 am

Kaks wrote:
Ok, unless there are any objections, I'm going to make the following changes to add / remove equipment:

...However, if the present cargo can't fit inside the changed cargo bay space, no changes will be made, add / remove equipment will return false, and a message will be added to the log.

Sounds good to me. Alternatively one could eject the surplus of barrels or let the surplus evaporate together with the bay.

Post by **Kaks** » Fri Oct 09, 2009 12:11 pm

I thought about it, but... if we have different types of cargo on board, how do we decide about which surplus to eject / evaporate?

We could decide it randomly, but it might not be too clever an idea...

Post by **Eric Walch** » Fri Oct 09, 2009 12:31 pm

Kaks wrote:
We could decide it randomly, but it might not be too clever an idea...

When you press Dump cargo it is also a random item. (Unless you have scooped items on board)

Looking at your code it suggest you don't correct inside addEquipment. I would do it there as all ways of removing items end there and you won't miss an exception. But the problem was more in removing as in adding as addEquipent already corrects things correctly as far as I know.

pmw57 · Post by **pmw57** » Fri Oct 09, 2009 12:33 pm

Eric Walch wrote:
When you press Dump cargo it is also a random item. (Unless you have scooped items on board)

I thought that Dump cargo dumped the last thing that was added, that that before dumping you can cycle through your cargo to select what will get dumped.

Website · Post by **Cody** » Fri Oct 09, 2009 12:38 pm

Kaks wrote:
I thought about it, but... if we have different types of cargo on board, how do we decide about which surplus to eject / evaporate?

We could decide it randomly, but it might not be too clever an idea...

A very non-expert comment: surely you should only be able to change cargo space when said cargo space is empty.

Post by **Eric Walch** » Fri Oct 09, 2009 12:43 pm

pmw57 wrote:
Eric Walch wrote:
When you press Dump cargo it is also a random item. (Unless you have scooped items on board)
I thought that Dump cargo dumped the last thing that was added, that that before dumping you can cycle through your cargo to select what will get dumped.

Therefor my addition: (Unless you have scooped items on board)

Post by **Kaks** » Fri Oct 09, 2009 1:00 pm

Hmmm, doing changes to the cargo space only if there's no cargo in the way does sound like the simplest way to implement this...

We already have award / remove equipment fail silently and just return false if not successful, so as long as the OXP script checks that the equipment change is successful, we should be ok...

pmw57 · Post by **pmw57** » Fri Oct 09, 2009 1:07 pm

Kaks wrote:
Hmmm, doing changes to the cargo space only if there's no cargo in the way does sound like the simplest way to implement this...

If the size of the cargo bay is greater than or equal to the space available on the ship, then go right ahead.

There doesn't seem to be any ways that that could go wrong.

Post by **Eric Walch** » Fri Oct 09, 2009 3:30 pm

Kaks wrote:
We already have award / remove equipment fail silently and just return false if not successful, so as long as the OXP script checks that the equipment change is successful, we should be ok...

And in case of a selEquipment.oxp we have a requires cargo space. When setting that at 15 or 20 tons, the removal item will not be offered. It still needs the script check as the extra bay is 15 tons by default but could have an other value when explicit specified for that ship. (None of the native ships use this customised bay size, but there could be some around)

Post by **Kaks** » Fri Oct 09, 2009 7:18 pm

Ok, the following is now in trunk:

award/remove passenger berths & cargo space via script now do change the available cargo space.
If there's cargo (or passengers!) in the way of the refit, no change is made, and the functions return false.

The extra cargo space is allocated / removed in accordance to the extra_cargo ship key.

In addition to that, the passenger berth modification is recognised inside .hasEquipment too. Before it was left in a sort of limbo.

Once we have a 1.74 release (or 1.73.5, if we must!) Commander McLane's OXP will once more allow captains everywhere to sell cargo bay extensions, this time without falling prey to (ok, taking undue advange of) quantum bay phenomena...

Lestradae · Post by **Lestradae** » Fri Oct 09, 2009 9:50 pm

Kaks wrote:
Ok, the following is now in trunk:

award/remove passenger berths & cargo space via script now do change the available cargo space.

Does that mean that additionally extended cargo bay options could be scripted via that?

Post by **Kaks** » Fri Oct 09, 2009 10:15 pm

extra_cargo is a key inside the shipdata that tells oolite by how much is the cargo bay going to be expanded, if the player has got the Large Cargo Bay as equipment.

It's been there since before 1.70, but so far no-one has set it higher than the standard 15 tons...

Beyond that, I'm really not sure what you mean by additionally extended cargo bay options...

Lestradae · Post by **Lestradae** » Fri Oct 09, 2009 10:37 pm

I see, I'm already using the extra cargo bay option for specific ships.

My question was if this made it possible to script specific cargo bay extensions in addition to the Large Cargo Bay. I.e. "Subspace Compression Cargo Bay" that adds another (second) extra cargo unit to the first (the standard LCB).

Your answer translates to me as "no", and I assume that my idea that this could become possible is also open to discussion if that would even be desirable.

Cheers

L

Post by **Kaks** » Fri Oct 09, 2009 10:48 pm

All this makes possible is to give / remove a cargo bay and passenger berth without the player having to click anything.

Before this change you could try, but the cargo bay size wouldn't be modified at all, and in the case of passenger berths, no change whatsoever would happen at all.

This opens up a few more scripted ship changes, as in "we're refitting your ship as a luxury cruiser for our ambassador to travel with you to planet xyz..." or "we took the liberty to remove your extra cargo bay, our lads needed the extra space. Don't worry about not having any space for your cargo, we took that as well, for no extra charge..."