Question concerning trunk

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
Screet
---- E L I T E ----
---- E L I T E ----
Posts: 1883
Joined: Wed Dec 10, 2008 3:02 am
Location: Bremen, Germany

Question concerning trunk

Post by Screet »

Hi,

when I tried to look wether my modified values for some definitions are still in place after an svn up, I stumbled over something which looks strange to me:

#define PLAYER_PLASMA_RANGE (MAIN_PLASMA_DURATION * PLAYER_PLASMA_RANGE)

and the same thing for NPCs.

Should that not be PLAYER_PLASMA_SPEED being used?

If PLAYER_PLASMA_RANGE would be a variable that is initialized, OK (then it would be PLAYER_PLASMA_RANGE *= MAIN_PLASMA_DURATION), but it's a definition without prior value...

Screet
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: Question concerning trunk

Post by Eric Walch »

Screet wrote:
Should that not be PLAYER_PLASMA_SPEED being used?

If PLAYER_PLASMA_RANGE would be a variable that is initialized, OK (then it would be PLAYER_PLASMA_RANGE *= MAIN_PLASMA_DURATION), but it's a definition without prior value...
I think you are right. But a project search showed that PLAYER_PLASMA_RANGE or NPC_PLASMA_RANGE is nowhere used in the code yet. Not a real problem then.

Speed (m/s) * Duration (s) = Range (m)
User avatar
Lestradae
---- E L I T E ----
---- E L I T E ----
Posts: 3095
Joined: Tue Apr 17, 2007 10:30 pm
Location: Vienna, Austria

..

Post by Lestradae »

Is there a plan to make plasma ranges scriptable or ship-dependent?

I think that carriers loosening plasma volleys that reached 15kms would look pretty impressive in space battles ...

Cheers

L
User avatar
Cmdr James
Commodore
Commodore
Posts: 1357
Joined: Tue Jun 05, 2007 10:43 pm
Location: Berlin

Post by Cmdr James »

I dont think there is a plan to do that. I guess its possible, but I havent heard anyone mention it.
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Re: ..

Post by JensAyton »

Lestradae wrote:
Is there a plan to make plasma ranges scriptable or ship-dependent?
I hereby declare my bold and decisive plan not to do that.
Post Reply