Planetfall bug or feature?
Moderators: winston, another_commander
- wackyman465
- ---- E L I T E ----
- Posts: 831
- Joined: Thu Nov 06, 2008 10:15 pm
- Location: Currently hunting you down in an Imperial Courier
Planetfall bug or feature?
It appears I can land on the sun. I didn't try but I got the landing clearance message while sunskimming...
I shot him back first. That is to say, I read his mind and fired before he would have fired on me. No, sir, he wasn't a fugitive.
It's a bug if it happens, although there is (or at least should be) code in place to recognise the sun and suppress the message.
What Oolite version, OS and and Planetfall version are you running?
What Oolite version, OS and and Planetfall version are you running?
My OXPs via Boxspace or from my Wiki pages .
Thargoid TV
Dropbox Referral Link
Thargoid TV
Dropbox Referral Link
- wackyman465
- ---- E L I T E ----
- Posts: 831
- Joined: Thu Nov 06, 2008 10:15 pm
- Location: Currently hunting you down in an Imperial Courier
Try 1.2 that I uploaded yesterday, that works better with 1.73.
I checked the code and there are checks for !isSun before all communications, so it may possibly be something broken in trunk, as it doesn't do this on 1.72.2 on my machine. I will check on 1.73 when I get some time.
As a side-note, please indicate you're using trunk when reporting possible OXP bugs - it sometimes can save a lot of hassle when the problem is in the trunk rather than the OXP.
I checked the code and there are checks for !isSun before all communications, so it may possibly be something broken in trunk, as it doesn't do this on 1.72.2 on my machine. I will check on 1.73 when I get some time.
As a side-note, please indicate you're using trunk when reporting possible OXP bugs - it sometimes can save a lot of hassle when the problem is in the trunk rather than the OXP.
My OXPs via Boxspace or from my Wiki pages .
Thargoid TV
Dropbox Referral Link
Thargoid TV
Dropbox Referral Link
- Eric Walch
- Slightly Grand Rear Admiral
- Posts: 5536
- Joined: Sat Jun 16, 2007 3:48 pm
- Location: Netherlands
I think it is your check:Thargoid wrote:It's a bug if it happens, although there is (or at least should be) code in place to recognise the sun and suppress the message.
What Oolite version, OS and and Planetfall version are you running?
Code: Select all
if(!planet.isSun && !planet.hasOwnProperty("solarGasGiant"))
Code: Select all
if(!(planet.isSun || planet.hasOwnProperty("solarGasGiant")))
Last edited by Eric Walch on Fri Aug 28, 2009 4:33 pm, edited 1 time in total.
UPS-Courier & DeepSpacePirates & others at the box and some older versions
If planet is a regular planet:
if(!planet.isSun && !planet.hasOwnProperty("solarGasGiant")) = true [if (!false && !false) = if (true && true) = if (true)]
if planet is a sun:
if(!planet.isSun && !planet.hasOwnProperty("solarGasGiant")) = false [if (!true && !false) = if (false && true) = if (false) ]
if planet is a gas giant:
if(!planet.isSun && !planet.hasOwnProperty("solarGasGiant")) = false [if (!false && !true) = if (true && false) = if (false) ]
if planet is a gas giant sun:
if(!planet.isSun && !planet.hasOwnProperty("solarGasGiant")) = false [(if !true && !true) = if (false && false) = if (false) ]
I think if you work out the logic the two statements above are actually the same, although yours is clearer than mine.
if(!planet.isSun && !planet.hasOwnProperty("solarGasGiant")) = true [if (!false && !false) = if (true && true) = if (true)]
if planet is a sun:
if(!planet.isSun && !planet.hasOwnProperty("solarGasGiant")) = false [if (!true && !false) = if (false && true) = if (false) ]
if planet is a gas giant:
if(!planet.isSun && !planet.hasOwnProperty("solarGasGiant")) = false [if (!false && !true) = if (true && false) = if (false) ]
if planet is a gas giant sun:
if(!planet.isSun && !planet.hasOwnProperty("solarGasGiant")) = false [(if !true && !true) = if (false && false) = if (false) ]
I think if you work out the logic the two statements above are actually the same, although yours is clearer than mine.
My OXPs via Boxspace or from my Wiki pages .
Thargoid TV
Dropbox Referral Link
Thargoid TV
Dropbox Referral Link
- Eric Walch
- Slightly Grand Rear Admiral
- Posts: 5536
- Joined: Sat Jun 16, 2007 3:48 pm
- Location: Netherlands
After writing it down I already had my doubts.You are right, they are the same. I was probably to convinced the cause must lie in this line.Thargoid wrote:I think if you work out the logic the two statements above are actually the same, although yours is clearer than mine.
UPS-Courier & DeepSpacePirates & others at the box and some older versions
Just tested isSun (working correctly), and also Planetfall 1.2 (also working correctly under WinXP).
So can you describe in exact detail how you got your problem to occur Wacky?
So can you describe in exact detail how you got your problem to occur Wacky?
My OXPs via Boxspace or from my Wiki pages .
Thargoid TV
Dropbox Referral Link
Thargoid TV
Dropbox Referral Link
- wackyman465
- ---- E L I T E ----
- Posts: 831
- Joined: Thu Nov 06, 2008 10:15 pm
- Location: Currently hunting you down in an Imperial Courier
I was meaning which system you were in, whether you have any system modifying OXPs (system redux, orbits, farsun etc) in place and *ahem* useful things like that.
I can't replicate your problem on my trunk WinXP using PF 1.2 (and the sun test code hasn't changed there from 1.12), and neither can Eric on his Mac as he kindly tested it for me as a back-up that it wasn't a Mac thing.
I can't replicate your problem on my trunk WinXP using PF 1.2 (and the sun test code hasn't changed there from 1.12), and neither can Eric on his Mac as he kindly tested it for me as a back-up that it wasn't a Mac thing.
My OXPs via Boxspace or from my Wiki pages .
Thargoid TV
Dropbox Referral Link
Thargoid TV
Dropbox Referral Link
- wackyman465
- ---- E L I T E ----
- Posts: 831
- Joined: Thu Nov 06, 2008 10:15 pm
- Location: Currently hunting you down in an Imperial Courier