Trunk: NPCs not jumping out

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Cmdr Wyvern
---- E L I T E ----
---- E L I T E ----
Posts: 1649
Joined: Tue Apr 11, 2006 1:47 am
Location: Somewhere in the great starry void

Trunk: NPCs not jumping out

Post by Cmdr Wyvern »

I've noticed that NPC ships, instead of flying away from the station and jumping out when undocking, instead fly away from the station a short distance then engage docking sequence.
Running Oolite buttery smooth & rock stable w/ tons of eyecandy oxps on:
ASUS Prime X370-A
Ryzen 5 1500X
16GB DDR4 3200MHZ
128GB NVMe M.2 SSD (Boot drive)
1TB Hybrid HDD (For software and games)
EVGA GTX-1070 SC
1080P Samsung large screen monitor
Top
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: Trunk: NPCs not jumping out

Post by Eric Walch »

Cmdr Wyvern wrote:
I've noticed that NPC ships, instead of flying away from the station and jumping out when undocking, instead fly away from the station a short distance then engage docking sequence.
Which revision are you using? I fixed that already a few weeks back. But that must always have been wrong before.

Reason for the returning is that some ships had no fuel, only when defined in shipdata. Those ships failed their hyperspace jump and returned. All oolites internal ships that had a trader role were defined with full tank but not all oxp traders.

I now changed it in a way that all trader-ships having zero fuel, in their definition, launch with a full tank. Ships that do have a fuel definition, are unaffected. It could be that some ships are defined with a partially filled tank. I consider that deliberately from the author and don't want to change the jump distance of those ships. Sometimes it is an oxp bug because a full tank is 70 units and not 7 units of fuel.

I noticed the same and haven't seen a returning ship since my change.
Top
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6683
Joined: Wed Feb 28, 2007 7:54 am

Post by another_commander »

Fixed. SVN2285.
Top
User avatar
Cmdr Wyvern
---- E L I T E ----
---- E L I T E ----
Posts: 1649
Joined: Tue Apr 11, 2006 1:47 am
Location: Somewhere in the great starry void

Re: Trunk: NPCs not jumping out

Post by Cmdr Wyvern »

Eric Walch wrote:
Which revision are you using? I fixed that already a few weeks back. But that must always have been wrong before.
Rev. 2281.
I've been seeing the glitch as far back as rev. 2263, when I started using Dizzy's installer. The bug affected the native ships as well as oxp ships.
Running Oolite buttery smooth & rock stable w/ tons of eyecandy oxps on:
ASUS Prime X370-A
Ryzen 5 1500X
16GB DDR4 3200MHZ
128GB NVMe M.2 SSD (Boot drive)
1TB Hybrid HDD (For software and games)
EVGA GTX-1070 SC
1080P Samsung large screen monitor
Top
User avatar
Cmdr Wyvern
---- E L I T E ----
---- E L I T E ----
Posts: 1649
Joined: Tue Apr 11, 2006 1:47 am
Location: Somewhere in the great starry void

Post by Cmdr Wyvern »

another_commander wrote:
Fixed. SVN2285.
Awesome. Now I'll see if Dizzy updated yet...
Running Oolite buttery smooth & rock stable w/ tons of eyecandy oxps on:
ASUS Prime X370-A
Ryzen 5 1500X
16GB DDR4 3200MHZ
128GB NVMe M.2 SSD (Boot drive)
1TB Hybrid HDD (For software and games)
EVGA GTX-1070 SC
1080P Samsung large screen monitor
Top
User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Post by Diziet Sma »

Cmdr Wyvern wrote:
another_commander wrote:
Fixed. SVN2285.
Awesome. Now I'll see if Dizzy updated yet...
He has now.. :D
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
Top
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Re: Trunk: NPCs not jumping out

Post by Eric Walch »

Cmdr Wyvern wrote:
Rev. 2281.
I've been seeing the glitch as far back as rev. 2263, when I started using Dizzy's installer. The bug affected the native ships as well as oxp ships.
You are right. When I noticed a launching ships immediately returning, it was a Hamadryad. When analysing why I noticed it had no fuel defined Fixed this in 2255. Than in 2259 I changed something else and used a wrong string comparison in the same trader launching. But for some reason that comparison was always true on the mac (at least on my system) and false on windows because I tested something else than I thought.
I specifically tested that line to be sure it returned true. A_C spotted the bug in that line immediately.
Top
Post Reply

Return to “Testing and Bug reports”