escort list is wrong in trunk

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

escort list is wrong in trunk

Post by Eric Walch »

I just noticed the some buoyRepair traders behaved wrong with the current trunk version. Looking for the reason it seemed that the mother-ship was included in the list of escorts. Even ships with no escorts now have themselves on their escort-list. This leads to strange behaviour with scripts that do things with escorts.

(In buoyRepair some mothers park their escorts by changing the AI of their escorts. Now they get this escortAI themselves and start hanging idle.)

Targeting the station and asking for all escorts results in:

Code: Select all

> player.ship.target.escorts
[Station "GRS Buoy Factory" "GRS Buoy Factory" ID: 460 position: (28719.7, 28719.7, 382911) scanClass: CLASS_STATION status: STATUS_IN_FLIGHT],[Ship "GRS Shuttle" ID: 598 position: (29547.1, 30201.3, 383981) scanClass: CLASS_NOT_SET status: STATUS_IN_FLIGHT],[Ship "GRS Armadillo" ID: 0 position: (0, 0, 0) scanClass: CLASS_NOT_SET status: STATUS_IN_FLIGHT],[Ship "GRS Armadillo" ID: 0 position: (0, 0, 0) scanClass: CLASS_NOT_SET status: STATUS_IN_FLIGHT],[Ship "GRS Armadillo" ID: 0 position: (0, 0, 0) scanClass: CLASS_NOT_SET status: STATUS_IN_FLIGHT],[Ship "GRS Shuttle" ID: 0 position: (0, 0, 0) scanClass: CLASS_NOT_SET status: STATUS_IN_FLIGHT],[Ship "Griff Boa" ID: 0 position: (0, 0, 0) scanClass: CLASS_NOT_SET status: STATUS_IN_FLIGHT],[Ship "GRS Shuttle" ID: 0 position: (0, 0, 0) scanClass: CLASS_NOT_SET status: STATUS_IN_FLIGHT],[Ship "GRS Controller" ID: 0 position: (0, 0, 0) scanClass: CLASS_NOT_SET status: STATUS_IN_FLIGHT],[Ship "GRS Shuttle" ID: 0 position: (0, 0, 0) scanClass: CLASS_NOT_SET status: STATUS_IN_FLIGHT]
Apparently the array does not only contain the escorts but all ships in the group.
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Post by JensAyton »

Fixed in r2221.
Post Reply