Joystick speed - missing value check

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
Screet
---- E L I T E ----
---- E L I T E ----
Posts: 1883
Joined: Wed Dec 10, 2008 3:02 am
Location: Bremen, Germany

Joystick speed - missing value check

Post by Screet »

Hi,

Oolite sometimes does not react properly to joystick speed settings. This especially becomes visible if the game is slowing down.

I had a look at PlayerEntityControls.m and it does check for speed settings below 0 and sets them to 0 in that case. However, that code block is not active for joystick speed settings.

It should be copied right after line 565 or the code being cleaned up to only check this once, regardless of the type of speed control mechanism, as there are already several those checks in, just none for stick speed control.

Screet
User avatar
Diziet Sma
---- E L I T E ----
---- E L I T E ----
Posts: 6312
Joined: Mon Apr 06, 2009 12:20 pm
Location: Aboard the Pitviper S.E. "Blackwidow"

Post by Diziet Sma »

8) Fixing this should solve that slight reverse-thrust problem that happens becomes apparent whenever using a fuel station or satellite with a joystick...

Well-spotted, Screet!
Most games have some sort of paddling-pool-and-water-wings beginning to ease you in: Oolite takes the rather more Darwinian approach of heaving you straight into the ocean, often with a brick or two in your pockets for luck. ~ Disembodied
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Post by JensAyton »

Fixed in r2210.
Post Reply