Ship.shipDisplayName

Lestradae · Post by **Lestradae** » Wed May 27, 2009 8:35 am

I am having regular crashes to desktop when launching from a station, usually the main station.

And the Log always tells me that javascript-wise "Ship.shipDisplayName" is deprecated. Two or ten times after each other.

I know that this command is not used by any of the .js scripts in OSE, has anyone an idea which oxp this might be from, or is it even from an oxp? And how could it be related to the desktop crash on main station launch trouble?

I would really care for more info, thanks in advance

L

Post by **another_commander** » Wed May 27, 2009 8:47 am

Totally unrelated to the crash to desktop, as already discussed countless times till now. If you look closely at the message, it is a warning, not an error and Oolite is just letting you know before it goes ahead and uses the equivalent non-deprecated method, which in this case would be Ship.displayName.

Wiki pages · Post by **Thargoid** » Wed May 27, 2009 8:48 am

It's just a warning, it shouldn't do anything for crashes. Currently the game will automatically do the substitution to the correct command, although this will change in 1.73 when the command is no longer recognised (hence the warnings all through 1.72.x's life).

As to which are using it, depends what you've got installed (a huge list iirc) but also if your versions are up to date (most OXP writers will update their scripts for such depreciations).

Simplest way is probably to use a decent search tool to look for that string within the files in your add-on folder (you can limit the search to *.js files). Then all you need to do is modify those files and change shipDisplayName to displayName if I remember correctly.

Lestradae · Post by **Lestradae** » Wed May 27, 2009 9:07 am

Thargoid wrote:
Currently the game will automatically do the substitution to the correct command, although this will change in 1.73 when the command is no longer recognised (hence the warnings all through 1.72.x's life).

Hm, I didn't provide important information: Those crashes only happen with my trunk 1.73 build from yesterday, not with my used-for-gaming 1.72.2!

So if that command is no longer recognised, still no chance of it producing a crash to desktop somehow?

another_commander wrote:
as already discussed countless times till now

Huh, don't stone me as yet, A_C *ducks trumble barrage*

Didn't mention I was talking about the 1.73 trunk, my bad ...

Post by **another_commander** » Wed May 27, 2009 9:31 am

The statement stands. The command is still automatically recognized and substituted and it is not the reason for your crash to desktop.

For future reference, the JavaScript warnings about deprecated methods do NOT result in crashes to desktop.

Lestradae · Post by **Lestradae** » Wed May 27, 2009 9:36 am

another_commander wrote:
For future reference, the JavaScript warnings about deprecated methods do NOT result in crashes to desktop.

OK, got it!

Website · Post by **DaddyHoggy** » Wed May 27, 2009 9:42 am

Confused (easy I know).

If the warnings in 1.72.2 about Ship.shipDisplayName being deprecated are because they will no longer be supported in 1.73 onwards and Lestradae is testing with the 1.73 trunk, then either they haven't been deprecated/removed in 1.73 or I'm missing something...

Wiki pages · Post by **Thargoid** » Wed May 27, 2009 9:47 am

Ditto, hence my original comments above.

I too thought that things that were depreciated in 1.72.x would be removed in 1.73.x? Or am I missing probably the same point as DH?

Although such an error I agree will at worse just stop that particular script, and not cause a desktop crash.

Post by **another_commander** » Wed May 27, 2009 9:49 am

I am not sure when exactly Ahruman was planning to remove the deprecated methods from circulation, but the only sure thing is that they are still in for now.

Post by **Cmdr James** » Wed May 27, 2009 9:50 am

I dont think 1.73 exsits as such. It is simply the name of the current trunk, isnt it?

Wiki pages · Post by **Thargoid** » Wed May 27, 2009 9:54 am

Ah OK, that's rather clearer.

They possibly (or probably) won't be in the 1.73 official final test release, but they are currently in the WIP build-it-yourself release that we're colloquially calling 1.73 at the moment.

Post by **Cmdr James** » Wed May 27, 2009 11:03 am

Deprecated methods should not be used, and whilst it should be assumed that they will be removed, it is not safe to depend on them no longer existing.

It is quite likely that some of the deprecated methods will be removed quickly, as few people use them, and others may live longer due to a larger number of legacy OXP dependencies.

Overall the message is not to use anything deprecated in new work, and for legacy OXPs remove references as soon as practicable.

Lestradae · Post by **Lestradae** » Wed May 27, 2009 12:07 pm

Cmdr James wrote:
Overall the message is not to use anything deprecated in new work, and for legacy OXPs remove references as soon as practicable.

Thargoid wrote:
Simplest way is probably to use a decent search tool to look for that string within the files in your add-on folder (you can limit the search to *.js files).

I know that nothing deprecated is in 1.72.2 OSE V0.4 atm, but there sure is in oxps I'm using.

Can anyone recommend me a good and cheap/gratis search tool for this?

Wiki pages · Post by **Thargoid** » Wed May 27, 2009 12:22 pm

Try starting with the one built into Vista?

The one in XP has enough brainpower to find phrases within files, so I guess unless they've been up to their usual lobotomising form the one in Vista should do likewise?

Screet · Post by **Screet** » Wed May 27, 2009 12:46 pm

Lestradae wrote:
Can anyone recommend me a good and cheap/gratis search tool for this?

http://notepad-plus.sourceforge.net/uk/site.htm

Screet

Oolite Bulletins

Ship.shipDisplayName

Ship.shipDisplayName

...

..

.

Re: .