Planet Texture Coloring (Was: Planet Texture bug?)

Post by **Micha** » Tue Apr 21, 2009 8:13 am

The sky colours weren't reset in 1.72 when a texture was being set and the polar_color_factor was deterministically set from the land_hsb_color. So in 1.72 we had a similar problem, just one which nobody reported: if one OXP sets atmospheric colours it will affect another OXP which provides a planetary texture.

We could specify a complete duplicate set of colour parameters to be used when a texture is provided, although that might be a bit overkill.

The problem with just asking a texture-providing OXP to specify a complete set of the standard colour parameters in order to display the texture as designed is that we can't guarantee what order the OXPs load in, so a later OXP may override an earlier OXPs settings.

How does everyone else feel it should work? On the one hand I presume we want to render a fully coloured planetary texture as designed by the graphic artist, on the other, we may want to provide a mechanism to specify a more generic planetary texture and then modify it by specifying colour parameters.

PS. Any way to change the title of this thread? It's now a discussion about a feature rather than a bug, as we've clarified that it's not a bug.

Post by **another_commander** » Tue Apr 21, 2009 8:25 am

Moved you out of Testing and Bug Reports, as requested. Discussion continues in... ehm... Discussion.

pagroove · Post by **pagroove** » Tue Apr 21, 2009 4:58 pm

Well I was not bothered by the bug. At first it did look a little odd but it's easy to get used to it. I like the procedural s in 1.73 they seem better than ever before, however they still are not as good as oxp textured planets. So keep in mind that people want to personalize the Ooniverse. I actually like to see a sort of System Redux 2 with a switch so that it not always creates a textured planet but also sometimes a procedural one. So the Mechanism then has to be that it works good in both environments.

Post by **Micha** » Thu Apr 23, 2009 6:10 am

pagroove wrote:
Well I was not bothered by the bug. At first it did look a little odd but it's easy to get used to it.

Ok, well, if even the author of an OXP which gets affected by this doesn't really mind whether or not his textures get modified unintentionally, I'll just revert the code back to the original rewrite. It will save a lot of complexity in the planetinfo.plist.

pagroove · Post by **pagroove** » Thu Apr 23, 2009 6:33 pm

Mmmmm....mmmmmmmmmmmmmmmmmmmm..

Well it's better to have the textures as original as meant by the author. But if it's very very very much work then shift it to a lower priority.