Wrong float notation

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
Screet
---- E L I T E ----
---- E L I T E ----
Posts: 1883
Joined: Wed Dec 10, 2008 3:02 am
Location: Bremen, Germany

Wrong float notation

Post by Screet »

Hi,

sadly, this time I don't know which oxp is the cause. Maybe the author can identify it by the values?

I copied the previous and next line, too...just in case that one of these has to do with the wrong number format (using both . and , for float). I'm afraid, though, that those other two lines don't have anything to do with it.

Code: Select all

[Fuel Collector]: Number of globes is 1
[strings.conversion.vector]: ***** ERROR cannot make vector from '0.0 -20, 22': could not scan a float value.
[shipRegistry.selection.profile]: Hit slow path in ship selection for role "trader", having selected ship "redback-trader". Now 60 of 334 on slow path (17.964072%).
EDIT: Found a "find in files" in Notepad++ ;)

[C:\Oolite\AddOns\neolite.oxp\Config\olddata.plist]
Line 25 : missile_launch_position = "0.0 -20, 22";
Line 50 : missile_launch_position = "0.0 -20, 22";
[C:\Oolite\AddOns\neolite.oxp\Config\shipdata.plist]
Line 144 : missile_launch_position = "0.0 -20, 22";
Line 185 : missile_launch_position = "0.0 -20, 22";

From the other vectors I've seen, it's a missing comma behind 0.0!

Screet
User avatar
Kaks
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 3009
Joined: Mon Jan 21, 2008 11:41 pm
Location: The Big Smoke

Post by Kaks »

Indeed! Simon B should be told! :)
Hey, free OXPs: farsun v1.05 & tty v0.5! :0)
Screet
---- E L I T E ----
---- E L I T E ----
Posts: 1883
Joined: Wed Dec 10, 2008 3:02 am
Location: Bremen, Germany

Post by Screet »

Kaks wrote:
Indeed! Simon B should be told! :)
Sent a PM after editing that message above... ;)

I'm really happy with those ships, they make the game not only look much better but also far more interesting as it's more difficult to shoot his ships down because of the slim models!

Screet
User avatar
Simon B
---- E L I T E ----
---- E L I T E ----
Posts: 836
Joined: Thu Oct 23, 2008 5:54 am
Location: Red Beach NZ
Contact:

Post by Simon B »

Line 185 : missile_launch_position = "0.0 -20, 22";

From the other vectors I've seen, it's a missing comma behind 0.0!
Good detective work, thanks - however, there should be no comma after the 20. (Commas denote the end of a row.)

The offending lines are in the anaconda entries of the shipdata.plist
They should read:

missile_launch_position = "0.0 -20.0 22.0";

I've mostly not worried about that vector since the missile is there very briefly - if you are close enough to notice the difference you're probably dead. Sometimes the launch position ends up in a wierd place - inside the model or a couple of model-distances away ... which can look odd. I've changed the one's I've noticed.

Anyone noticing funny-looking launches feel free to correct the effect and tell me about it.

Ta.
Simon Bridge
[re2dux] [neolite]
"Everything is perfect down to every last flaw..."
HBT: The Book of Verse - Principia Discordia
Post Reply