Strange thing in interstelar space

[Ark]

Today I encountered the strangest oolite bug ever

I went to interstellar space where there was a huge battle between Gal navy and the thargoids. I destroyed a thargoid invader (everything normal so far) and after that I start shooting a nearby thargoid carrier. For every hit with my laser in the carrier I received the bounty of 2000 cr. Until I completely destroyed it I almost had collected the amount of 100.000 crs?

If I remember correctly in interstellar space there was a lot of thargoids some members of a tigers gung (hotrods oxp) and some civilian ships asking for help (interstellar help oxp)

I was unable to replicate this (in normal space with a thargoid carrier or in witchspace) but I am suspect that is either a very rare exotic bug of oolite or some strange interaction of oxps that populate interstellar space. During my attempts to replicate this and while I was in interstellar space I had a crash to the desktop (nothing in the logs – as usual)

Another strange thing was that when I attempted to dock into a behemoth in interstellar space, during the docking procedure I had a message from Aronar station (the system I was before withspace) that “We have uploaded docking procedures …”

I have the latest version of all oxps

Does anybody suspect something?

[Rimbaud]

Today I encountered the strangest oolite bug ever

I went to interstellar space where there was a huge battle between Gal navy and the thargoids. I destroyed a thargoid invader (everything normal so far) and after that I start shooting a nearby thargoid carrier. For every hit with my laser in the carrier I received the bounty of 2000 cr. Until I completely destroyed it I almost had collected the amount of 100.000 crs?

If I remember correctly in interstellar space there was a lot of thargoids some members of a tigers gung (hotrods oxp) and some civilian ships asking for help (interstellar help oxp)

I was unable to replicate this (in normal space with a thargoid carrier or in witchspace) but I am suspect that is either a very rare exotic bug of oolite or some strange interaction of oxps that populate interstellar space. During my attempts to replicate this and while I was in interstellar space I had a crash to the desktop (nothing in the logs – as usual)


Does anybody suspect something?

Have a look at this thread here: https://bb.oolite.space/viewtopic.php?t=4592&highlight=

[Ark]

Yes it is the same bug

[another_commander]

Another strange thing was that when I attempted to dock into a behemoth in interstellar space, during the docking procedure I had a message from Aronar station (the system I was before withspace) that “We have uploaded docking procedures …”

This one is now fixed. Oolite would accept as a main system station the first station-capable entity generated, even when in witchspace. This would make the Behemoth a main station and thus, you were receiving station messages instead of carrier ones.

[Commander McLane]

And if I'm right with my analysis over there, the other bug should be relatively easy to fix as well:

Yes, I had the same thing with the Thargoid Carrier once. The target inspector revealed that it had an energy below ZERO. For every consecutive hit the energy sank more below 0 and I was awarded another 2000 Cr.

Seems that the bounty-rewarding mechanism checks for energy <= 0 and awards a bounty, while the ship-explosion mechanism probably only checks for energy = 0. If it somehow misses the moment (although I have no idea why and how it could do that), the ship won't be removed from the Ooniverse, and continue with negative energy forever. (The energy-recharge mechanism seems to check for energy > 0, so the Carrier in question never gained any energy anymore, so indeed it had to exist forever.)

Changing the explosion mechanism so that it triggers on energy <= 0 should fix it.

[JensAyton]

Changing the explosion mechanism so that it triggers on energy <= 0 should fix it.

Everyone’s an expert. ;-)

That’s exactly how explosions are triggered. However, in the specific case of the main station, the method responsible for the actual explosion does nothing. The bug was that carriers were being treated as the main station – so another_commander’s fix covers your bug.

[Commander McLane]

Even better!

(Although in my case it happened with a Carrier in normal space, with the main station present as well.)

And I did start with saying 'if I'm right with my analysis'.