Oolite v1.72 is_template weirdness

[Griff]

I don't think is_template is working properly in Oolite v1.72
I've been testing it with the pagroove stations oxp.

In the reference object entry in the shipdata.plist:

is_template ="true";
no model & role keys specified.
result
the stations do not appear and no errors in log

is_template ="true";
model keys set to model = "PAGroove_coriolis_station.dat";
role key not specified
result
the stations do not appear and no errors in log

is_template ="true";
model key not specified
role key set to roles = "PAGroove_coriolis_reference";
result
the stations do not appear and no errors in log

is_template ="true";
model keys set to model = "PAGroove_coriolis_station.dat";
role key set to roles = "PAGroove_coriolis_reference";
result
the stations do not appear and no errors in log

is_template ="false";
no model & role keys specified.
result
the stations appear but this error in log:
[shipData.load.error]: ***** ERROR: the shipdata.plist entry "PAGroove_coriolis_reference" specifies no roles, ignoring.

is_template ="false";
model key not specified.
role key set to roles = "PAGroove_coriolis_reference";
result
the stations appear but this error in log:
[shipData.load.error]: ***** ERROR: the shipdata.plist entry "PAGroove_coriolis_reference" specifies no model, ignoring.

is_template ="false";
model keys set to model = "PAGroove_coriolis_station.dat";
role key not specified.
result
the stations appear but this error in log:
shipData.load.error]: ***** ERROR: the shipdata.plist entry "PAGroove_coriolis_reference" specifies no roles, ignoring.

is_template ="false";
model keys set to model = "PAGroove_coriolis_station.dat";
role key set to roles = "PAGroove_coriolis_reference";
result
the stations appear but this error in log:
[shipData.load.error]: ***** ERROR: the shipdata.plist entry "PAGroove_coriolis_reference" specifies no model, ignoring.

[nijineko]

i believe i read somewhere that is_template removes the model in question from consideration when creating entities for a solar system.

[Griff]

yeah, i'll have to dig about in the pagroove stations oxp a bit deeper, maybe i've got something wrong in there, it's just that any new ship or station that i like_ship to another ship or station that has is_template="true"; in it's entry doesn't appear in game but there are no errors or anything that might explain why being reported in the log

[Thargoid]

I'm seeing (I think) a similar issue with the missile rack OXP. They use templates and like_ships too. These appear in the available equipment, but you can't seem to buy them (at least they don't show up in the missile pylons).

[LittleBear]

I've worked round this for Random Hits by just including the model and role in the template entry. Doesn't make any difference to game play as the model and role in the template are overwritten anyway by the model and role assigned to the varients and only the varients actually appear in game.

BTW playing on 1.72, I come accross PA_Grove stations working normally, so they seem OK on my system even if they are generating comments in the log file.

[Thargoid]

Thanks, but that doesn't seem to help. Looking deeper in the logs (through the mess of warnings from other OXPs about player --> player.ship) yields:

Code: Select all

[equip.buy.mounted.failed]: Could not find ship for mounted weapon role EQ_IRACK_3_MISSILE
[equip.buy.mounted.failed]: Could not find ship for mounted weapon role EQ_NRACK_3_MISSILE
[equip.buy.mounted.failed]: Could not find ship for mounted weapon role EQ_NRACK_3_MISSILE
[equip.buy.mounted.failed]: Could not find ship for mounted weapon role EQ_IRACK_3_MISSILE
[equip.buy.mounted.failed]: Could not find ship for mounted weapon role EQ_IRACK_3_MISSILE

so there's something else still not right in there. I guess my mileage may be different as they're equipment-based items rather than plain ships.

Update - I tried adding roles and models to everything (template and like_ship) and it still failed with the above error. However if I take out the is_template = true line, then they work again.

So I'm afraid that line's coming out again for the moment, as it breaks the OXP.

[JensAyton]

Resolved: the is_template key was being inherited through like_ship (d’oh).

[Commander McLane]

Resolved: the is_template key was being inherited through like_ship (d’oh).