IFF add on OXP.. Bounty Information

[Frame]

Just a quick note that in the latest trunk version, I think you need to change the script to player.ship.target.bounty as player.target.bounty does not seem to work.

Thanks...

does player.ship work in 1.71.2 ? In that case I will make the corrections right away...

Edit

Answering that one myself.. and that is a negative... player.ship.target.bounty does not work in 1.71

Code: Select all

----- JavaScript warning: reference to undefined property player.ship
2008-08-19 20:58:18.928 oolite.exe[3796] [script.javaScript.warning.162]:       AddOns/BountyScanner.oxp/Scripts/BountyScanner.js, line 43.

Edit

added Version detection... instead

Code: Select all

this.startUp = function()
{
	//log("BountyScanner.js","Oolite version "+oolite.version)
	if(oolite.version == "1,71" || oolite.version == "1,71,2")
	{
		//log("BountyScanner.js","detected 1.71 or1.71.2")
		this.Theplayership = player
	}	
	else
	this.Theplayership = player.ship
}

[Eric Walch]

Just a quick note that in the latest trunk version, I think you need to change the script to player.ship.target.bounty as player.target.bounty does not seem to work.

This change will affect more that 50% of the oxp's with JS. e.g. all mission oxp's won't work proper anymore. Most check for "player.docked" which becomes "player.ship.docked".

I already started changing things in some of my oxp's to let them work with both Oolite versions, I a similar way as Frame showed above.

[Cmdr James]

Most JS methods should still work in trunk, but may give warnings. For some reason a few of them dont work properly. I think player.target is one of them. But it could be that I have broken it in my copy

[JensAyton]

Code: Select all

this.startUp = function()
{
	//log("BountyScanner.js","Oolite version "+oolite.version)
	if(oolite.version == "1,71" || oolite.version == "1,71,2")
	{
		//log("BountyScanner.js","detected 1.71 or1.71.2")
		this.Theplayership = player
	}	
	else
	this.Theplayership = player.ship
}

You spelled the version numbers wrong, and missed 1.71.1. The correct way to do this is:

Code: Select all

if (0 < oolite.compareVersion("1.72"))
{
    // 1.71.x or earlier
    this.thePlayerShip = player;
}
else
{
    // 1.72 or later
    this.thePlayerShip = player.ship;
}

Just a quick note that in the latest trunk version, I think you need to change the script to player.ship.target.bounty as player.target.bounty does not seem to work.

Weird, player.target.bounty works here (with a warning). Have you rebuilt the cache since I last changed the prefix script? :-)

[Frame]

Code: Select all

this.startUp = function()
{
	//log("BountyScanner.js","Oolite version "+oolite.version)
	if(oolite.version == "1,71" || oolite.version == "1,71,2")
	{
		//log("BountyScanner.js","detected 1.71 or1.71.2")
		this.Theplayership = player
	}	
	else
	this.Theplayership = player.ship
}

You spelled the version numbers wrong, and missed 1.71.1. The correct way to do this is:

Code: Select all

if (0 < oolite.compareVersion("1.72"))
{
    // 1.71.x or earlier
    this.thePlayerShip = player;
}
else
{
    // 1.72 or later
    this.thePlayerShip = player.ship;
}

yeah missed 1.71.1, but when i print out to tthe debug console, i get "1,71,2" not "1.71.2".. so does this mean we got different outputs for mac and windows, or can this might be keyboard langauge related ?

[JensAyton]

I’m rather surprised that it happens in that context, but this is down to a bug in the C standard library implementation in Windows – in violation of the spec, it applies locale settings in certain contexts by default. Anyway, you’ll get commas or points depending on system language settings, but only under Windows, and your test won’t work at all on English-language installations. It’s entirely possible that this means oolite.compareVersion() and requires.plist don’t work properly in non-English versions of Windows, though.

[Eric Walch]

I’m rather surprised that it happens in that context,

The same with me on a Mac. When I type "oolite.version" in the console I get the version comma separated. But compare version works for me. There I use points however.

[JensAyton]

Hey look, it happens here too. :-p

The reason is simple: oolite.version is not a string but an array. oolite.versionString is a string. The idea that [1, 72] == "1,72" hadn’t occurred to me.

[Thargoid]

V1.03 still seems to be reporting a spawned Thargoid Warship (role "oolite-thargoid") as a bounty of 460c, even though on nuking it yields 100c?

[Frame]

V1.03 still seems to be reporting a spawned Thargoid Warship (role "oolite-thargoid") as a bounty of 460c, even though on nuking it yields 100c?

i´ll make a special check for thargoids with bounty more than 100 cr... and show the correct bounty awarded, which will be maximum 100 cr... in version 1.04...

[Lestradae]

... show the correct bounty awarded, which will be maximum 100 cr... in version 1.04...

Why the 100Cr maximum?

[Frame]

... show the correct bounty awarded, which will be maximum 100 cr... in version 1.04...

Why the 100Cr maximum?

dunno, just is so... Thargoid bounty is max 100, not sure for the robot fighters though... i known theire bounty goes up if they hit a police ship... wheter or not it maxs out at 100, i dont know.

in case anyone wonders. this has nothing to do with this OXP, it is a hard-coded max bounty for Thargoids...

[dalek501]

Is that for all Thargoids or just standard original ones? I'm sure I destroyed a battle cruiser type and got far more than 100cr.

[Frame]

Is that for all Thargoids or just standard original ones? I'm sure I destroyed a battle cruiser type and got far more than 100cr.

Can´t speak for OXP ships... but i think it only counts for the build in ones... or those OXP ships that mimics them..

[dalek501]

I see.