Sound.stopMusic() and event-handler

[Svengali]

I'm currently overhauling the Hyperradio and spotted one thing:

Code: Select all

this.shipWillDockWithStation = function()
 {
   Sound.stopMusic(this.hyperradio_current);
 }

Works superb, but when I use the same in this.shipDockedWithStation the sound won't stop. Is it a bug or a feature?

[JensAyton]

Bug. When the player docks, the game attempts to play “OoliteDocked.ogg” if there is a file by that name. However, the code that plays the music loses track of the currently-playing music when given a non-existant file name. This is a general problem not limited to that particular case.

The fix looks trivial, but I need to write a test case. :-)

[Svengali]

Thanks Ahruman.

If we know that it isn't working on some points then we could use the working event-handlers. Thanks for your time and I really like the new stuff :-)

BTW: While testing the new Sound.playMusic I've spotted that sometimes - after playing a song there is a stutter, as if Oolite tries to play something again. It's short (<0.5secs) but you can hear it.

[JensAyton]

Fixed for 1.71.2 amd 1.72.

[JensAyton]

BTW: While testing the new Sound.playMusic I've spotted that sometimes - after playing a song there is a stutter, as if Oolite tries to play something again. It's short (<0.5secs) but you can hear it.

I suspect this is SDL’s fault. (You’re on Windows, are you not?)

[Svengali]

I suspect this is SDL’s fault. (You’re on Windows, are you not?)

To my shame - yes :-)

[Svengali]

Now (v1.71.2) it has changed. this.shipWillDockWithStation doesn't work without error and this.shipDockedWithStation works superb. Again only for Sound.stopMusic(this.hyperradio_current).

[JensAyton]

*grumblegrumblebahhumbug*