ZZZZ9999_load_this_last

An area for discussing new ideas and additions to Oolite.

Moderators: winston, another_commander

Post Reply
User avatar
Cmdr James
Commodore
Commodore
Posts: 1357
Joined: Tue Jun 05, 2007 10:43 pm
Location: Berlin

ZZZZ9999_load_this_last

Post by Cmdr James »

We know that oolite reads files alphabetically and its a last file wins system for deciding which of the same-named files is used.

I cant help thinking it might be useful to have a warning message written to the log telling us that oolite has found > 1 file of the same name, and is ignoring the first.

On the other hand, I know that this feature is used deliberately to override behaviour in {someting}.oxp with something else, such as the realistic shipyards oxp
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6683
Joined: Wed Feb 28, 2007 7:54 am

Post by another_commander »

I think it is a very reasonable thing to have a warning that more than one files with the same name have been found, even in the case of it happening deliberately. In the cases where this happens deliberately, we can just ignore the message, but in the other cases, it would be very helpful to know what's going on.

You would only want to limit this to files found in the AddOns folder, though or you would be getting warnings for conflict with the core game files. Additionally, it would probably be better to pop the warning only in the case of same entries found in files with the same name. It is perfectly ok to have two shipdata.plists in two different folders, but the real problem would only start if both shipdata.plists have a reference to, for example, a Cobra MkIII.
User avatar
JensAyton
Grand Admiral Emeritus
Grand Admiral Emeritus
Posts: 6657
Joined: Sat Apr 02, 2005 2:43 pm
Location: Sweden
Contact:

Post by JensAyton »

Hmm… I suppose the dictionary merger could keep a mutable set of stuff-already-seen-in-non-built-in-files.
Post Reply