Shield-Tails don't count as kills?

[Cmdr James]

Eric, there are 2 different things here.

All ships become CARGO when the pilot ejects. That might be a good thing, maybe not. I guess this could cause some weird effects, as ships without a pilot are not really cargo in any meaningful way.

The shield tail, when killed has a commodity amount of 10, most other ships normally have a commodity amount not > 0.

The commodity amount = 10 is caused by the cargo_carried in the plist being set to 10gold.
Also, the Purple Haze has 100 gold, and this causes commodity amount to be 100, and of course suffers from the same problem.

As the commodity amount is > 0, and it is cargo, the shield tail is not awarding a kill.


2nd issue: There is some custom handling for tharglets, but it is never used.

[another_commander]

The scanclass of tharglets is bad looking: They turn white to indicate that it is scanclass cargo. (The command: BecomeUncontrolledThargoid is doing that) The exception is needed because the have alien cargo but should count as a kill.

OK, this makes sense. The check for tharglets inside the killIsCargo is indeed meaningful, then.