PR to cleanup/simplify build flags

[mcarans]

I've made a PR to clean up and simplify the build flags: https://github.com/OoliteProject/oolite/pull/523

Fix typo DOO_FOV_INFLIGHT_CONTROL_ENABLEDD

Remove FEATURE_REQUEST_5496 as no references in code

Replace OO_EXCLUDE_DEBUG_SUPPORT with NDEBUG in code for consistency - previously if you set NDEBUG (eg. BUILD_WITH_DEBUG_FUNCTIONALITY no) but not OO_EXCLUDE_DEBUG_SUPPORT, then compile failed.

Remove BUILD_WITH_DEBUG_FUNCTIONALITY as duplicates OO_EXCLUDE_DEBUG_SUPPORT (which equals NDEBUG). The simplification means that OO_EXCLUDE_DEBUG_SUPPORT effectively becomes a more human readable version of NDEBUG for use in config.make and using NDEBUG alone does not break builds.

Tested on Windows and Linux including building, installing and running package

[mcarans]

I've updated this PR with the changes that have since been added to Oolite master. It's ready for merge.

[another_commander]

Thanks for that, I hope you don't mind waiting a bit on it, unless someone else gets to review it first. Some things going on here and I was working on a new feature at the same time, so didn't have time to act on this - or any other open PR.

[mcarans]

Thanks for that, I hope you don't mind waiting a bit on it, unless someone else gets to review it first. Some things going on here and I was working on a new feature at the same time, so didn't have time to act on this - or any other open PR.

Sure, no problem. Who are the other maintainers of Oolite?

[MrFlibble]

Thanks for that, I hope you don't mind waiting a bit on it, unless someone else gets to review it first. Some things going on here and I was working on a new feature at the same time, so didn't have time to act on this - or any other open PR.

Sure, no problem. Who are the other maintainers of Oolite?

I'm not, but have a PR or two to add from my fork. Waiting for one of the other devs to sanity check while I try to make sure that my diffs don't bork the windoze build Will meanwhile, if time permits, attempt to roll your changes into my fork to see if there are any obvious issues.

[another_commander]

Sure, no problem. Who are the other maintainers of Oolite?

At this time it is phkb and hiran.

[another_commander]

PR #523 has now been merged.