AI Trading Assistant

[Wildeblood]

I've said quite clearly I've no intention of updating this OXP for Oolite 1.82

For those of us who experiment with v.1.77.1 etc.

what exactly are the various different members of this horde?

We currently have:

AI Trading Assistant 2.15.1
AI Trading Autotrade Report 0.5.3
AI Trading Backup Datalogger 2.12.3
AI Trading Legality Reminder 1.0
AI Trading Purchase Book 2.12
AI Trading Turbotrader 1.0
AI Trading with Yoda 1.0

Are they just all retitled versions of the same thing?

I admire your penchant for thread necromancy, Chompers, but you're either brave or foolhardy re-awakening this one. But since you asked...

1.77.1 won't do, you'll need either Oolite 1.80 or (maybe) 1.79.

All of those you listed are plug-ins I was using to test new features, before deciding to include them into Trading Assistant or drop them in the "yeah, nah" bin. They all worked, and they were all different. If you want to give it a try, you'll need either AI Trading Assistant 2.15.1 (the last version) or AI Trading Assistant 2.13 (the last "stable" version) - 2.14 was buggy.

AI Trading Backup Datalogger 2.12.3
Does what it says - quietly logs data, while being invisible in-game. You install this alongside the main OXP, then forget about it. When you want to try out Market Observer OXP, you remove AI Trading Assistant OXP, but leave the backup logger. When you realize you've made a horrible mistake, you put AI Trading Assistant OXP back, remove Market Observer OXP, and (like magic!) there's no gap in your data. Everything carries on as though you had never strayed. ("It's alright, Pam, it was just a dream.")

AI Trading Turbotrader 1.0
Doubled the speed of Autotrade - instead of starting after 22 seconds and trading every 9 seconds, it started after 11 seconds, and traded every four seconds. You could edit it to one second if you enjoyed the bell sound - ding-ding-ding-ding-ding!

AI Trading Legality Reminder 1.0
Added tut-tut messages if you bought one of the three illegal commodities. Unnecessary, as that feature got incorporated into the main OXP.

AI Trading Purchase Book 2.12
This one changed the display of the prices you had paid for goods, from an average price to the actual specific prices, and sold them dearest one first. This feature got incorporated into Market Observer OXP, and (I think, don't quote me) into AI Trading Assistant 2.15.1... I'm honestly unsure whether it was in the main OXP, or still required the plug-in.

AI Trading with Yoda 1.0
Changed the grammar of the messages, it did. (See also: AI Trading, Your Majesty.)

AI Trading Autotrade Report 0.5.3
I don't know, but its version number is zero, not one. Possibly, either it printed the current state of the pricing registers to Latest.log, or it displayed a list of recently visited systems, the same as Thargoid's Flight Log OXP. That feature was in there somewhere. Thargoid hadn't updated Flight Log to use the F4 screen yet - you still invoked his mission screen with a specific sequence of screen changes (manifest screen to system data screen, possibly) and I got tired of waiting for him to fix it, so I added that feature into AI Trading Assistant.

Other things it did:-
Autotrade could stop short of filling the hold and leave some space, if you anticipated scooping asteroids along the way.

AI Trading Assistant 2.15.1 monitored cargo contracts, and warned you if you inadvertently sold some goods you were contracted to deliver elsewhere. That's floating around as a separate OXP somewhere, too.

Also, at start up Autotrade compiled a list of other OXPs that were listening for playerBoughtCargo or playerSoldCargo, and politely notified them of the trades it made, so it didn't disrupt whatever they were doing. (If you knew how, you could run Autotrade with Market Observer instead of AI Trading Assistant.)

Is there anything else you'd like to know?

[Cholmondely]

1.77.1 won't do, you'll need either Oolite 1.80 or (maybe) 1.79.

As I recall (6 months or so ago), it worked just fine with 1.77.1 - I was whizzing around G2 looking for flying Vectors and your "Assistant" just chuntered along doing its thing. Made a nice change.

I should point out: some of the salutations were a bit "off". But then the software was obviously not painstakingly handcrafted in glorious Lesser Walshingham, written out by quill-armed scribes on embossed and watermarked paper, with the to-be-expected distinctions in address between "Most Honourable" and "Right Honourable". Maybe it, too, needs a Digebitian variation? What say you?

I've not dared to touch v.1.80 yet - even with a barge-pole. With my crummy combat capabilities it sounds rather like an exercise in painful suicide.




On another note, it must be quite grim reading all this without a computer which you can load up Oolite on. I'd find it quite infuriating. What happened to your old one? Was it the Witchspace Lobster yet again?

[Wildeblood]

1.77.1 won't do, you'll need either Oolite 1.80 or (maybe) 1.79.

As I recall (6 months or so ago), it worked just fine with 1.77.1 - I was whizzing around G2 looking for flying Vectors and your "Assistant" just chuntered along doing its thing. Made a nice change.

I find that hard to believe, but probably I'm misremembering when the cargo related events were added to javascript. But now I'm irritated; if you already knew about it, why did you ask?

On another note, it must be quite grim reading all this without a computer which you can load up Oolite on. I'd find it quite infuriating. What happened to your old one? Was it the Witchspace Lobster yet again?

I have a box of dead laptops around the house somewhere. The first laptop I ever bought lasted years longer than any of the others since have. Now I just have this little six inch square box that sits under the TV, with just enough grunt to run a web browser (slowly).

[Cholmondely]

1.77.1 won't do, you'll need either Oolite 1.80 or (maybe) 1.79.

As I recall (6 months or so ago), it worked just fine with 1.77.1 - I was whizzing around G2 looking for flying Vectors and your "Assistant" just chuntered along doing its thing. Made a nice change.

I find that hard to believe, but probably I'm misremembering when the cargo related events were added to javascript. But now I'm irritated; if you already knew about it, why did you ask?

I thought that what I asked was what the rest of the clan did - not which version of Oolite it worked with. And when you were hoping to transmogrify them into a hundred-strong horde for crewing an Anaconda.

On another note, it must be quite grim reading all this without a computer which you can load up Oolite on. I'd find it quite infuriating. What happened to your old one? Was it the Witchspace Lobster yet again?

I have a box of dead laptops around the house somewhere. The first laptop I ever bought lasted years longer than any of the others since have. Now I just have this little six inch square box that sits under the TV, with just enough grunt to run a web browser (slowly).

Sounds rather sad. Does the Church of Giles the Creator do revivifications? I find that my AppleMacs last and last and last. Due to the curse of software updates I end being able to do less and less with them, but at least they jolly well work.

[Wildeblood]

I thought that what I asked was what the rest of the clan did - not which version of Oolite it worked with.

Well, let's hope my answer was satisfactory then.

And when you were hoping to transmogrify them into a hundred-strong horde for crewing an Anaconda.

Not a hundred. My ambition ran to two: AI Trading Assistant with Autotrade, and AI Combat Assistant with Autotrack. If I could have got them both finished, I would have never looked at javascript again, and just concentrated on editing planetinfo.list to make the ooniverse a better place.

[Cholmondely]

And when you were hoping to transmogrify them into a hundred-strong horde for crewing an Anaconda.

Not a hundred. My ambition ran to two: AI Trading Assistant with Autotrade, and AI Combat Assistant with Autotrack. If I could have got them both finished, I would have never looked at javascript again, and just concentrated on editing planetinfo.list to make the ooniverse a better place.

What would you have wished to do with the planetinfo.plist? What were you hoping to achieve?

[Cholmondely]

I'm back playing on v.1.77.1 and have this OXP loaded.

My latest log reads: 11:54:46.778 [plist.parse.failed] OOPropertyListFromData (OOPListParsing.m:74): Failed to parse .../Library/Application Support/Oolite/AddOns/oolite.oxp.Wildeblood.ai_trading_2.15.1.oxp/Config/missiontext.plist as a property list.
Unexpected character { at line 1

When I use Terminal to "plutil" the missiontext.plist I get this:

Code: Select all

... % plutil /.../Oolite/AddOns/oolite.oxp.Wildeblood.ai_trading_2.15.1.oxp/Config/missiontext.plist
2024-10-07 13:23:10.216 plutil[53431:8921315] CFPropertyListCreateFromXMLData(): Old-style plist parser: missing semicolon in dictionary on line 17. Parsing will be abandoned. Break on _CFPropertyListMissingSemicolon to debug.
.../Library/Application Support/Oolite/AddOns/oolite.oxp.Wildeblood.ai_trading_2.15.1.oxp/Config/missiontext.plist: Unexpected character { at line 1

Now the reference to line 17 might well be to line 16 - but I can see nothing wrong with either. I am, of course, running all this on a dreaded AppleMac.

The missiontext.plist reads as follows:

Code: Select all

{
//	Use [autotrade_Commodity] for initial capital letter, [autotrade_commodity] for lower-case letter:
	"autotrade_purchase_recommendation" = "I recommend buying [autotrade_commodity], boss.";
//	"autotrade_purchase_recommendation" = "[autotrade_Commodity] would be the thing to buy, boss.";
	"autotrade_sale_recommendation"     = "I recommend selling the [autotrade_commodity], boss.";
	"autotrade_sale_actual_premium"     = " You will gain [autotrade_actual_premium] credits per unit if you sell them all.";

	"autotrade_ethical_start"  = "Ethical automatic trading will begin in [autotrade_countdown] seconds. I will not recommend controlled goods.";
	"autotrade_ruthless_start" = "Fully automatic trading will begin in [autotrade_countdown] seconds.";
	"autotrade_learning_start" = "I am watching to learn from you, boss."; // Can use [autotrade_countdown] here, too.

	"autotrade_options_interface_title"   = "Trading assistant (Autotrade [autotrade_current_mode])";
	"autotrade_options_interface_summary" = "Options to configure your Trading Assistant AI for fully automatic trading. Make money fast!";
	"autotrade_options_title" = "Trading Assistant AI";

	"autotrade_options_when_on" = {
	"21_OFF"   = {text = "OFF: no recommendations or automatic trading"; alignment = "LEFT"};   // <-- Line #17
	"22_ADVICE"= {text = "ADVICE: buy and sell recommendations only"; alignment = "LEFT"};
	"23_SLOW"  = {text = "SLOW: automatic trading of cargo one unit at a time"; alignment = "LEFT"};
	"24_FAST"  = {text = "FAST: fully automatic trading of cargo"; alignment = "LEFT"};
	"25_BUY"   = {text = "BUY: automatic buying of cargo"; alignment = "LEFT"};
	"26_SELL"  = {text = "SELL: automatic selling of cargo"; alignment = "LEFT"};
	"70_BLANK" = "";
	"71_ETHICS"= {text = "Observational learning: will watch and mimic your trading style"; alignment = "LEFT"};
	"81_ETHICS"= {text = "Ethical trading: will not trade in controlled goods"; alignment = "LEFT"};
	"82_ETHICS"= {text = "Situational trading: will not buy controlled goods at GalCop stations"; alignment = "LEFT"};
	"83_ETHICS"= {text = "Ruthless trading: will trade controlled goods at any station"; alignment = "LEFT"};
	"89_BLANK" = "";
	"90_SPACE" = {text = "Reserve no space for extra cargo"; alignment = "LEFT"};
	"91_SPACE" = {text = "Reserve space for 1 extra cargo pod"; alignment = "LEFT"};
	"92_SPACE" = {text = "Reserve space for 2 extra cargo pods"; alignment = "LEFT"};
	"95_SPACE" = {text = "Reserve space for 5 extra cargo pods"; alignment = "LEFT"};
	"98_BLANK" = "";
	"99_EXIT"  = "No change"};

	"autotrade_options_when_off" = {
	"1_EXIT"    = "No change";
	"22_ADVICE" = "ADVICE: buy and sell recommendations only            "; // Don't delete the extra white space.
	"23_SLOW"   = "SLOW: automatic trading of cargo one unit at a time";
	"24_FAST"   = "FAST: fully automatic trading of cargo                       "};

	"autotrade_mode_off"    = "off";
	"autotrade_mode_advice" = "advice";
	"autotrade_mode_slow"   = "slow";
	"autotrade_mode_fast"   = "fast";
	"autotrade_mode_buy"    = "buy";
	"autotrade_mode_sell"   = "sell";

	"tradingAI_oppcost_number" = "This is the [tradingAI_ordinal_number] station we\u2019ve visited since you first acquired those [tradingAI_commodity].";
	"tradingAI_oppcost_many"   = "We\u2019ve visited many, many stations since you first acquired those [tradingAI_commodity].";

	"tradingAI_history_interface_title"   = "Docking history (latest [tradingAI_history_length] stations)";
	"tradingAI_history_interface_summary" = "View a list of stations whence you have recently docked.";
	"tradingAI_history_title"             = "Docking History";

	"tradingAI_report_interface_title"   = "Trading assistant";
	"tradingAI_report_interface_summary" = "View your trading summary and options to configure your Trading Assistant AI for fully automatic trading. Make money fast!";
	"tradingAI_report_title"             = "Trading Assistant AI";

	"tradingAI_manifest_long"  = "You have cargo aboard which cost a total of [tradingAI_manifest_cost] credits, and would realize a total of [tradingAI_manifest_value] credits if all sold at this station.";
	"tradingAI_manifest_short" = "You have cargo aboard which cost a total of [tradingAI_manifest_cost] credits.";
	"tradingAI_manifest_none"  = "I\u2019m not really sure what\u2019s currently in the hold, boss.";
}

[Wildeblood]

I'm back playing on v.1.77.1 and have this OXP loaded.

You do this just to hurt me, don't you?

Wildeblood.ai_trading_2.15.1.oxp

My recollection was that the last version was 2.15.2, but whatevs. Line 17 is where it was up to when parsing failed, but it's unlikely the mistake in the mark-up is on that line. Try the end of that block, the line that reads:
"99_EXIT" = "No change"};

Try inserting a semi-colon before the brace:-
"99_EXIT" = "No change";};

And the following block, labelled "autotrade_options_when_off", has the same structure, with no semi-colon inside the closing brace:
"24_FAST" = "FAST: fully automatic trading of cargo "};

Try inserting a semi-colon before the brace:-
"24_FAST" = "FAST: fully automatic trading of cargo ";};

Make those two changes, and it will either be parsed without complaint or produce a plethora of new error messages we can discuss.

And bear in mind, a cocoanut fell on my head and I may well be mis-remembering everything I ever knew about XML.

[Cholmondely]

Umm...

Newly mangled missiontext.plist:

Code: Select all

{
//	Use [autotrade_Commodity] for initial capital letter, [autotrade_commodity] for lower-case letter:
	"autotrade_purchase_recommendation" = "I recommend buying [autotrade_commodity], boss.";
//	"autotrade_purchase_recommendation" = "[autotrade_Commodity] would be the thing to buy, boss.";
	"autotrade_sale_recommendation"     = "I recommend selling the [autotrade_commodity], boss.";
	"autotrade_sale_actual_premium"     = " You will gain [autotrade_actual_premium] credits per unit if you sell them all.";

	"autotrade_ethical_start"  = "Ethical automatic trading will begin in [autotrade_countdown] seconds. I will not recommend controlled goods.";
	"autotrade_ruthless_start" = "Fully automatic trading will begin in [autotrade_countdown] seconds.";
	"autotrade_learning_start" = "I am watching to learn from you, boss."; // Can use [autotrade_countdown] here, too.

	"autotrade_options_interface_title"   = "Trading assistant (Autotrade [autotrade_current_mode])";
	"autotrade_options_interface_summary" = "Options to configure your Trading Assistant AI for fully automatic trading. Make money fast!";
	"autotrade_options_title" = "Trading Assistant AI";

	"autotrade_options_when_on" = {
	"21_OFF"   = {text = "OFF: no recommendations or automatic trading"; alignment = "LEFT"};
	"22_ADVICE"= {text = "ADVICE: buy and sell recommendations only"; alignment = "LEFT"};
	"23_SLOW"  = {text = "SLOW: automatic trading of cargo one unit at a time"; alignment = "LEFT"};
	"24_FAST"  = {text = "FAST: fully automatic trading of cargo"; alignment = "LEFT"};
	"25_BUY"   = {text = "BUY: automatic buying of cargo"; alignment = "LEFT"};
	"26_SELL"  = {text = "SELL: automatic selling of cargo"; alignment = "LEFT"};
	"70_BLANK" = "";
	"71_ETHICS"= {text = "Observational learning: will watch and mimic your trading style"; alignment = "LEFT"};
	"81_ETHICS"= {text = "Ethical trading: will not trade in controlled goods"; alignment = "LEFT"};
	"82_ETHICS"= {text = "Situational trading: will not buy controlled goods at GalCop stations"; alignment = "LEFT"};
	"83_ETHICS"= {text = "Ruthless trading: will trade controlled goods at any station"; alignment = "LEFT"};
	"89_BLANK" = "";
	"90_SPACE" = {text = "Reserve no space for extra cargo"; alignment = "LEFT"};
	"91_SPACE" = {text = "Reserve space for 1 extra cargo pod"; alignment = "LEFT"};
	"92_SPACE" = {text = "Reserve space for 2 extra cargo pods"; alignment = "LEFT"};
	"95_SPACE" = {text = "Reserve space for 5 extra cargo pods"; alignment = "LEFT"};
	"98_BLANK" = "";
	"99_EXIT"  = "No change";}; //changed as per Wildeblood's post

	"autotrade_options_when_off" = {
	"1_EXIT"    = "No change";
	"22_ADVICE" = "ADVICE: buy and sell recommendations only            "; // Don't delete the extra white space.
	"23_SLOW"   = "SLOW: automatic trading of cargo one unit at a time";
	"24_FAST"   = "FAST: fully automatic trading of cargo                       ";}; //changed as per Wildeblood's post

	"autotrade_mode_off"    = "off";
	"autotrade_mode_advice" = "advice";
	"autotrade_mode_slow"   = "slow";
	"autotrade_mode_fast"   = "fast";
	"autotrade_mode_buy"    = "buy";
	"autotrade_mode_sell"   = "sell";

	"tradingAI_oppcost_number" = "This is the [tradingAI_ordinal_number] station we\u2019ve visited since you first acquired those [tradingAI_commodity].";
	"tradingAI_oppcost_many"   = "We\u2019ve visited many, many stations since you first acquired those [tradingAI_commodity].";

	"tradingAI_history_interface_title"   = "Docking history (latest [tradingAI_history_length] stations)";
	"tradingAI_history_interface_summary" = "View a list of stations whence you have recently docked.";
	"tradingAI_history_title"             = "Docking History";

	"tradingAI_report_interface_title"   = "Trading assistant";
	"tradingAI_report_interface_summary" = "View your trading summary and options to configure your Trading Assistant AI for fully automatic trading. Make money fast!";
	"tradingAI_report_title"             = "Trading Assistant AI";

	"tradingAI_manifest_long"  = "You have cargo aboard which cost a total of [tradingAI_manifest_cost] credits, and would realize a total of [tradingAI_manifest_value] credits if all sold at this station.";
	"tradingAI_manifest_short" = "You have cargo aboard which cost a total of [tradingAI_manifest_cost] credits.";
	"tradingAI_manifest_none"  = "I\u2019m not really sure what\u2019s currently in the hold, boss.";
}

And AppleMac's termnial plutil result:

Code: Select all

... ~ % plutil ...Oolite/AddOns/oolite.oxp.Wildeblood.ai_trading_2.15.1.oxp/Config/missiontext.plist
2024-10-07 21:49:21.647 plutil[78046:9140776] CFPropertyListCreateFromXMLData(): Old-style plist parser: missing semicolon in dictionary on line 17. Parsing will be abandoned. Break on _CFPropertyListMissingSemicolon to debug.
...Oolite/AddOns/oolite.oxp.Wildeblood.ai_trading_2.15.1.oxp/Config/missiontext.plist: Unexpected character { at line 1

I presume that I misunderstood your instructions...

[Wildeblood]

I presume that I misunderstood your instructions...

Nuh-uh. You did as I asked. Now I'm intrigued.

missiontext.plist: Unexpected character { at line 1

So, it's telling us that it's reading more { than } in the file.

Unexpected character { at line 1

means it never found a } to close that block, so the opening { is "unexpected".

OR, MAYBE, it's literally truthful and it's the actual { on the first line, and } on the last line it's objecting to!?

Did you try deleting those?

If that's it, why the heck does it get all the way to line 17 before parsing fails!?

(Is that really the last version I made?)

[Cholmondely]

Now I'm intrigued.

Am awaiting further instruction...

[Wildeblood]

I think I see it now. It's all of them, every line. 17 was just the first. Try copying these two blocks in; I think I got every line, I added 14 semi-colons, I think.

Code: Select all

	"autotrade_options_when_on" = {
	"21_OFF"   = {text = "OFF: no recommendations or automatic trading"; alignment = "LEFT";};   // <-- Line #17
	"22_ADVICE"= {text = "ADVICE: buy and sell recommendations only"; alignment = "LEFT";};
	"23_SLOW"  = {text = "SLOW: automatic trading of cargo one unit at a time"; alignment = "LEFT";};
	"24_FAST"  = {text = "FAST: fully automatic trading of cargo"; alignment = "LEFT";};
	"25_BUY"   = {text = "BUY: automatic buying of cargo"; alignment = "LEFT";};
	"26_SELL"  = {text = "SELL: automatic selling of cargo"; alignment = "LEFT";};
	"70_BLANK" = "";
	"71_ETHICS"= {text = "Observational learning: will watch and mimic your trading style"; alignment = "LEFT";};
	"81_ETHICS"= {text = "Ethical trading: will not trade in controlled goods"; alignment = "LEFT";};
	"82_ETHICS"= {text = "Situational trading: will not buy controlled goods at GalCop stations"; alignment = "LEFT";};
	"83_ETHICS"= {text = "Ruthless trading: will trade controlled goods at any station"; alignment = "LEFT";};
	"89_BLANK" = "";
	"90_SPACE" = {text = "Reserve no space for extra cargo"; alignment = "LEFT";};
	"91_SPACE" = {text = "Reserve space for 1 extra cargo pod"; alignment = "LEFT";};
	"92_SPACE" = {text = "Reserve space for 2 extra cargo pods"; alignment = "LEFT";};
	"95_SPACE" = {text = "Reserve space for 5 extra cargo pods"; alignment = "LEFT";};
	"98_BLANK" = "";
	"99_EXIT"  = "No change";};

	"autotrade_options_when_off" = {
	"1_EXIT"    = "No change";
	"22_ADVICE" = "ADVICE: buy and sell recommendations only            "; // Don't delete the extra white space.
	"23_SLOW"   = "SLOW: automatic trading of cargo one unit at a time";
	"24_FAST"   = "FAST: fully automatic trading of cargo                       ";};

[Cholmondely]

plutil just gave this fix the thumbs up!

Thank you.


In the past, when there have been mistakes in several lines of code, the response from plutil was different - either the problem on line 1 (only) or listing the next line with a problem (if I'm lucky). I confess to finding it a tad confusing.

[Wildeblood]

plutil just gave this fix the thumbs up!

I do not understand, though. You've used this OXP before, with Oolite 1.77, so how is this an issue now?

[Cholmondely]

plutil just gave this fix the thumbs up!

I do not understand, though. You've used this OXP before, with Oolite 1.77, so how is this an issue now?

I don't recall it being an in-game issue last time - but this time I was noticing errors in the latest.log. There are a number of no-shows (eg. Imperial Astrofactories, Nephthys and Hathor stations, etc.). I did not notice any problems with your OXP functioning last time - but what would I know?