BroadcastComms MFD [Release]

[phkb]

OK, v1.3.3 is now available. Fingers crossed I fixed everything this time!

[Old Murgh]

OK, v1.3.3 is now available. Fingers crossed I fixed everything this time!

Still, no comms show up (except request docking..) when I use the verbatim lines. I tried both EM download and again with the oxp from the wiki, checked that it is indeed 1.3.3. It refuses. Maybe you need another tester to verify it isn't a Mac thing?

Anyway, it still runs well with my abbreviated display lines, and still that error pops up in the log even though I now have disabled #4.
Flummoxing.

[phkb]

OK, v1.3.3 is now available. Fingers crossed I fixed everything this time!

Still, no comms show up (except request docking..) when I use the verbatim lines. I tried both EM download and again with the oxp from the wiki, checked that it is indeed 1.3.3. It refuses. Maybe you need another tester to verify it isn't a Mac thing?

Anyway, it still runs well with my abbreviated display lines, and still that error pops up in the log even though I now have disabled #4.
Flummoxing.

I might need to see a version of your WIP so I can debug against that. My own testing scenarios aren’t showing up the issue.

[Old Murgh]

I might need to see a version of your WIP so I can debug against that. My own testing scenarios aren’t showing up the issue.

Sure, if it helps I can make a lite-version available for you tomorrow afternoon.

[Old Murgh]

OK, v1.3.3 is now available. Fingers crossed I fixed everything this time!

Still, no comms show up (except request docking..) when I use the verbatim lines. I tried both EM download and again with the oxp from the wiki, checked that it is indeed 1.3.3. It refuses. Maybe you need another tester to verify it isn't a Mac thing?

Anyway, it still runs well with my abbreviated display lines, and still that error pops up in the log even though I now have disabled #4.
Flummoxing.

I might need to see a version of your WIP so I can debug against that. My own testing scenarios aren’t showing up the issue.

I am pleased and embarrassed to report that it now works perfectly as advertised. As I was testing my lite version to provide you, the error didn't appear, and when I went back to my bulky version, this too did what it was supposed to do. I have no other explanation than maybe yesterday I didn't hold in shift long enough to clear my cache. Sorry for my false alarm.
Anyway, hurrah, and thanks for your great work.

[Cody]

I didn't hold in shift long enough to clear my cache.

You need always-flush-cache added to your .GNUstepDefaults file (if that's possible on Jobsian devices).

[Old Murgh]

You need always-flush-cache added to your .GNUstepDefaults file (if that's possible on Jobsian devices).

Not sure, but my log frequently informs me it starts off with a cache refreshment even though I don't ask for it.
I know much too little about these things.

[Cody]

Not sure, but my log frequently informs me it starts off with a cache refreshment even though I don't ask for it.

That's the code messing with your head. According to my log, the cache gets flushed twice.

[Milo]

I'm seeing a few of these in my log, possibly correlated with when I target a wormhole:

Code: Select all

23:30:55.451 [script.javaScript.exception.unexpectedType] ReportJSError: ***** JavaScript exception (BroadcastCommsMFD 1.3.3): TypeError: t.scriptInfo is undefined
23:30:55.451 [script.javaScript.exception.unexpectedType] ReportJSError:       E:\Oolite/oolite.app/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.phkb.BroadcastCommsMFD.oxz/Scripts/broadcastcomms_mfd.js, line 717.

[phkb]

I'm seeing a few of these in my log, possibly correlated with when I target a wormhole:

Thanks! I'll get an update out shortly.

[Milo]

Code: Select all

Exception: TypeError: t.scriptInfo is undefined
    Active script: BroadcastCommsMFD 1.3.3
    broadcastcomms_mfd.js, line 717:
    		if (t.scriptInfo.hasOwnProperty("bcc_disable_defaults") && Array.isArray(t.scriptInfo.bcc_disable_defaults)) disable_defaults = t.scriptInfo.bcc_disable_defaults;
targeted wormhole undefined who has 0 energy
shipTargetAcquired, new target (undefined), index: 0, IdentKeyPress: 0: [Wormhole destination: Usralaat ttl: 37.51s arrival: 2084866:05:07:21]

[Milo]

Code: Select all

got message from Kirin Sport 32256 : Let me go and I'll give you 1 credit.
attacked by Hognose: Rosalind 5 17158 277+576 shield and 640 energy left
got message from Hognose: Rosalind 5 17158 : All right. I accept.
Exception: TypeError: pirateship.group is null
    Active script: BroadcastCommsMFD_Equipment 1.3.3
    broadcastcomms_mfd.js, line 2215:
    	var ships = pirateship.group.ships;

The ship in question:

[Ship "Hognose" position: (79603.3, -53034.6, 642511) scanClass: CLASS_NEUTRAL status: STATUS_IN_FLIGHT]

> player.ship.target.isPirate
false

> player.ship.target.isTrader
true

> player.ship.target.bounty
0

[Cholmondely]

Just thought that this belonged here

Interactions with NPCs are basically "shoot/flee" or "ignore", and a clean player will be picking "ignore" almost all the time. Some inter-ship chatter (including news, trading tips, comments based on the player's reputation etc.) could make NPC encounters a little less same-y.

Murgh's work on his Scrubs (Iron Ass Vol 5) & his unfinished Refugee Adders are a case in point.

[phkb]

Version 1.3.4 has just been released which should address the two most recent issues with JS errors.

[NorthenderPNE]

Was just playing Oolite Trunk 1.91 up to date as of today and it crashed with this line in the log. I was heading for a wormhole to LAVE that was about to collapse with seconds to go and I arrived almost on collapse, almost.

Typical that it happened as I've just started to play Oolite again after a long time away from it.

Code: Select all

18:57:21.912 [script.javaScript.exception.unexpectedType]: ***** JavaScript exception (BroadcastCommsMFD 1.3.4): TypeError: t.script is undefined
18:57:43.116 [oolite-populator]: system.government 3
18:57:43.116 [oolite-populator]: system.economy 5 ------------------ CRASHED! Last line of the log file.

Just tried again, restarted the game and went though a wormhole successfully with 40secs on the countdown this time as opposed to almost no time on the clock previously. Unfortunately ended up in witchspace, it's not my day it seems.

The error was again in the log but no crash this time. Hope it helps.