Backwardness of version info in expansion installer list

[arquebus]

So, for reasons that I can no longer remember, I have all of my OXPs in the Managed AddOns directory, including the ones that I did not install through the in-game installer.

Specifically for the issue I'm noticing now, Telescope.

The version installed is 2.0.1, whereas the one from the install manager in Oolite is 1.15 I believe.

Well, the manager shows the INSTALLED version to be -- (em-dash), and the AVAILABLE version to be 2.0.1.

At the very least the available version should be 1.15, ideally it should be 2.0.1 and 1.15 respectively (installed, available).

Probably someone else has noticed this already.

[phkb]

I tried to recreate your scenario, but putting Telescope 2.0 (and related OXP's) into my Managed Addons folder, and then checking what I can see in the manager.

First, it should be noted that Telescope 1.15 and Telescope 2.0 have different ID's: while there might be a traceable family history between the two OXP's, Telescope 2.0's ID is completely different to Telescope 1.15, so it will never show as being an upgrade to 1.15.

Secondly, Telescope 2.0 is not in the Manager yet. I can only see Telescope 2.0 on my Manager screen if I change the view to "List installed expansion packs". On the "Install expansion pack" view, Telescope 2.0 does not appear at all, which is because v2.0 hasn't been added yet.

cag has also put conflict notices in v2.0, so, in the event someone manages to get both versions installed, only one version will be active in an actual game.

Does that clear things up a bit?

[hiran]

I tried to recreate your scenario, but putting Telescope 2.0 (and related OXP's) into my Managed Addons folder, and then checking what I can see in the manager.

First, it should be noted that Telescope 1.15 and Telescope 2.0 have different ID's: while there might be a traceable family history between the two OXP's, Telescope 2.0's ID is completely different to Telescope 1.15, so it will never show as being an upgrade to 1.15.

Secondly, Telescope 2.0 is not in the Manager yet. I can only see Telescope 2.0 on my Manager screen if I change the view to "List installed expansion packs". On the "Install expansion pack" view, Telescope 2.0 does not appear at all, which is because v2.0 hasn't been added yet.

cag has also put conflict notices in v2.0, so, in the event someone manages to get both versions installed, only one version will be active in an actual game.

Does that clear things up a bit?

What you mention makes absolute sense and would imply that there is no confusion or misbehaviour. Yet a user got confused about this. I am guessing now...

The expansion manager does not display the OXP IDs, it rather shows the human readable name. If the two OXPs are treated as two different and not related OXPs, they should cover two different lines in the expansion list, with
- Telescope Installed: ---- Available: 1.15
- Telescope: Installed: 2.0 Available: ---

Probably the above is what happened, despite the fact the second OXP was not displayed since it is not part of the downloaded expansion list.
For some reason the user would have expected

- Telescope: Installed: 2.0 Available: 1.15

which is only to be expected if the two OXPs are clearly one line and therefore have the same ID.

The situation of one OXP being installed but not in the expansion manager list could be that a user installed manually (as we heard above), but it could also evolve for someone having installed an OXP that later gets removed from the expansion manager. I believe it is worth that such cases are handled without confusing the user.

Result:

I assume the expansion manager downloads the list of available OXPs, then scans the filesystem and complements the list with installed versions.
As a change, it should probably add OXPs that are installed even if they are not part of the download list. This should lead to the above situation where two lines "Telescope" are visible.

[phkb]

Telescope 2.0 does have a different name - it’s offical name is “Telescope v2”, so it would be a completely separate item on the Manager when it gets there.

[hiran]

Telescope 2.0 does have a different name - it’s offical name is “Telescope v2”, so it would be a completely separate item on the Manager when it gets there.

when it gets there
I think that is the point. The two OXPs are already impacting that installation. One because it is installed, the other because it can be installed (and we are talking about the Expansion Manager being active and this point in time).
Oolite should download the available OXPs AND scan the locally installed OXP list, then MERGE the two lists.

Currently I believe it does not. It just downloads the available OXP list, then complements it with version numbers in case one of the OXPs is already installed. That is the reason why right now there were no two lines saying

Telescope: Installed --- Available: 1.15
Telescope v2: Installed: 2.0 Available: ---

which would have indicated to the user the real situation.

[arquebus]

In an ideal world, the expansion manager should let you toggle any and all expansions off without deleting them. "Remove" should be split into "remove" and "deactivate."